From 0f5f15a5ceb224766e65a83e71d82f1a198057c0 Mon Sep 17 00:00:00 2001 From: topjohnwu Date: Fri, 7 Dec 2018 21:56:54 -0500 Subject: [PATCH] Stop signing module zips Nobody should be using the signature verification in recoveries --- .../com/topjohnwu/magisk/asyncs/DownloadModule.java | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/app/src/full/java/com/topjohnwu/magisk/asyncs/DownloadModule.java b/app/src/full/java/com/topjohnwu/magisk/asyncs/DownloadModule.java index 5b8cb4b60..6f914b0b2 100644 --- a/app/src/full/java/com/topjohnwu/magisk/asyncs/DownloadModule.java +++ b/app/src/full/java/com/topjohnwu/magisk/asyncs/DownloadModule.java @@ -9,12 +9,10 @@ import com.topjohnwu.magisk.Const; import com.topjohnwu.magisk.Data; import com.topjohnwu.magisk.FlashActivity; import com.topjohnwu.magisk.MagiskManager; -import com.topjohnwu.magisk.R; import com.topjohnwu.magisk.components.BaseActivity; import com.topjohnwu.magisk.components.ProgressNotification; import com.topjohnwu.magisk.container.Repo; import com.topjohnwu.magisk.utils.WebService; -import com.topjohnwu.magisk.utils.ZipUtils; import com.topjohnwu.superuser.ShellUtils; import java.io.BufferedInputStream; @@ -42,21 +40,12 @@ public class DownloadModule { ProgressNotification progress = new ProgressNotification(output.getName()); try { MagiskManager mm = Data.MM(); - File temp1 = new File(mm.getCacheDir(), "temp.zip"); - HttpURLConnection conn = WebService.mustRequest(repo.getZipUrl()); ProgressInputStream pis = new ProgressInputStream(conn.getInputStream(), conn.getContentLength(), progress); removeTopFolder(new BufferedInputStream(pis), - new BufferedOutputStream(new FileOutputStream(temp1))); + new BufferedOutputStream(new FileOutputStream(output))); conn.disconnect(); - progress.getNotification() - .setProgress(0, 0, true) - .setContentTitle(mm.getString(R.string.zip_process_msg)) - .setContentText(""); - progress.update(); - ZipUtils.signZip(temp1, output); - temp1.delete(); if (install) { progress.dismiss(); Intent intent = new Intent(mm, Data.classMap.get(FlashActivity.class));