From 147264822ca732b3f4b6674a1d530e8968735b21 Mon Sep 17 00:00:00 2001 From: Viktor De Pasquale Date: Sun, 14 Apr 2019 12:29:07 +0200 Subject: [PATCH] Fixed leaking base instance to the event listener --- .../main/java/com/topjohnwu/magisk/ui/base/MagiskViewModel.kt | 4 ---- .../main/java/com/topjohnwu/magisk/ui/home/HomeViewModel.kt | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskViewModel.kt b/app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskViewModel.kt index 8c1349c68..2f7d29fcd 100644 --- a/app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskViewModel.kt +++ b/app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskViewModel.kt @@ -7,10 +7,6 @@ import timber.log.Timber abstract class MagiskViewModel : LoadingViewModel(), Event.AutoListener { - init { - Event.register(this) - } - override fun onEvent(event: Int) = Timber.i("Event of $event was not handled") override fun getListeningEvents(): IntArray = intArrayOf() diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/home/HomeViewModel.kt b/app/src/main/java/com/topjohnwu/magisk/ui/home/HomeViewModel.kt index e257874b9..3278f171a 100644 --- a/app/src/main/java/com/topjohnwu/magisk/ui/home/HomeViewModel.kt +++ b/app/src/main/java/com/topjohnwu/magisk/ui/home/HomeViewModel.kt @@ -69,6 +69,7 @@ class HomeViewModel( private val latest = resources.getString(R.string.latest_version) init { + Event.register(this) refresh() }