From 2cabb2666be8e21d16fe4924a7df85df1d165aa0 Mon Sep 17 00:00:00 2001 From: tonymanou Date: Mon, 9 Jan 2017 20:08:37 +0100 Subject: [PATCH] Avoid possible NPE --- .../java/com/topjohnwu/magisk/adapters/ReposAdapter.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/topjohnwu/magisk/adapters/ReposAdapter.java b/app/src/main/java/com/topjohnwu/magisk/adapters/ReposAdapter.java index 62218368e..a3983be60 100644 --- a/app/src/main/java/com/topjohnwu/magisk/adapters/ReposAdapter.java +++ b/app/src/main/java/com/topjohnwu/magisk/adapters/ReposAdapter.java @@ -7,6 +7,7 @@ import android.content.Context; import android.content.Intent; import android.net.Uri; import android.support.v7.widget.RecyclerView; +import android.text.TextUtils; import android.util.DisplayMetrics; import android.view.LayoutInflater; import android.view.View; @@ -92,7 +93,7 @@ public class ReposAdapter extends RecyclerView.Adapter } }); holder.changeLog.setOnClickListener(view -> { - if (!repo.getLogUrl().isEmpty()) { + if (!TextUtils.isEmpty(repo.getLogUrl())) { new WebWindow(mContext.getString(R.string.changelog), repo.getLogUrl(), mContext); } }); @@ -111,12 +112,12 @@ public class ReposAdapter extends RecyclerView.Adapter .show(); }); holder.authorLink.setOnClickListener(view -> { - if (!repo.getDonateUrl().isEmpty()) { + if (!TextUtils.isEmpty(repo.getDonateUrl())) { mContext.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse(repo.getDonateUrl()))); } }); holder.supportLink.setOnClickListener(view -> { - if (!repo.getSupportUrl().isEmpty()) { + if (!TextUtils.isEmpty(repo.getSupportUrl())) { mContext.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse(repo.getSupportUrl()))); } });