TheArchive/Magisk
1
0
Fork 0
mirror of https://github.com/topjohnwu/Magisk.git synced 2025-12-12 03:22:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix random return value of faccessat() in x86

Browse Source 
faccessat() should return 0 when success, but it returns random number with errno == 0 in x86 platform.

It’s a side effect of commit bf80b08b5f when magisk binaries ‘corretly’ linked with library of API16 .. lol

Co-authored-by: John Wu <topjohnwu@gmail.com>
This commit is contained in:
Shaka Huang
2021-04-04 18:04:09 +08:00
committed by GitHub
parent dfe1f2c108
commit 3da318b48e
3 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
native/jni/utils/xwrap.cpp
View File

@@ -359,6 +359,20 @@ ssize_t xreadlinkat(int dirfd, const char *pathname, char *buf, size_t bufsiz) {
#endif
}
int xfaccessat(int dirfd, const char *pathname) {
int ret = faccessat(dirfd, pathname, F_OK, 0);
if (ret < 0) {
PLOGE("faccessat %s", pathname);
}
#if defined(__i386__) || defined(__x86_64__)
if (ret > 0 && errno == 0) {
LOGD("faccessat success but ret is %d\n", ret);
ret = 0;
}
#endif
return ret;
}
int xsymlink(const char *target, const char *linkpath) {
int ret = symlink(target, linkpath);
if (ret < 0) {