TheArchive/Magisk
1
0
Fork 0
mirror of https://github.com/topjohnwu/Magisk.git synced 2025-12-11 22:22:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Guard su request IPC

Browse Source 
Previously `read_string()` calls `std::string.resize()` with a int read from remote process. When I/O error occurs, -1 will be used for resizing the string, `std::bad_alloc` is thrown and since magisk is compiled with `-fno-exceptions`, it will crash the whole daemon process.

May fix topjohnwu#5681
This commit is contained in:
canyie
2022-04-03 13:09:23 +08:00
committed by John Wu
parent 3f840f53a0
commit 448384af06
4 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
native/jni/include/socket.hpp
View File

@@ -21,5 +21,5 @@ int read_int_be(int fd);
void write_int(int fd, int val);
void write_int_be(int fd, int val);
std::string read_string(int fd);
void read_string(int fd, std::string &str);
bool read_string(int fd, std::string &str);
void write_string(int fd, std::string_view str);