TheArchive/Magisk
1
0
Fork 0
mirror of https://github.com/topjohnwu/Magisk.git synced 2025-04-22 12:51:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Compile with Android Q SDK

Browse Source 
We upgrade compileSdkVersion to Q, but keep targetSdkVersion as 28.
The reason is because targeting Q will no longer allow us to execute
native binaries in an app's private data, which Magisk Manager relies
a lot for performing stock boot image patches in non rooted environment.
For more information regarding this issue, check this link:
https://redd.it/b2inbu

Some workarounds has been discovered (https://github.com/termux/proot),
however for the time being there is no point to introduce these huge
hacks just for targeting Q, which we don't benefit anything.
This commit is contained in:
topjohnwu 2019-04-10 02:17:08 -04:00
parent 6128c24f96
commit 4b54cf1288
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
build.gradle
View File

@ -43,8 +43,8 @@ subprojects {
if (getPlugins().hasPlugin('com.android.library') || if (getPlugins().hasPlugin('com.android.library') ||
getPlugins().hasPlugin('com.android.application')) { getPlugins().hasPlugin('com.android.application')) {
android { android {
compileSdkVersion 28 compileSdkVersion 'android-Q'
buildToolsVersion "28.0.3" buildToolsVersion '29.0.0-rc2'
defaultConfig { defaultConfig {
if (minSdkVersion == null) if (minSdkVersion == null)