TheArchive/Magisk
1
0
Fork 0
mirror of https://github.com/topjohnwu/Magisk.git synced 2025-04-21 07:41:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added attempted fix for parsing data off default thread

Browse Source
This commit is contained in:
Viktor De Pasquale 2019-06-16 09:48:27 +02:00 committed by John Wu
parent 982a43fce1
commit 4db41e2ac4
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
app/src/main/java/com/topjohnwu/magisk/tasks/UpdateRepos.java
View File

@ -3,8 +3,6 @@ package com.topjohnwu.magisk.tasks;
import android.database.Cursor; import android.database.Cursor;
import android.util.Pair; import android.util.Pair;
import androidx.annotation.NonNull;
import com.topjohnwu.magisk.App; import com.topjohnwu.magisk.App;
import com.topjohnwu.magisk.Config; import com.topjohnwu.magisk.Config;
import com.topjohnwu.magisk.Const; import com.topjohnwu.magisk.Const;
@ -20,7 +18,6 @@ import org.json.JSONException;
import org.json.JSONObject; import org.json.JSONObject;
import java.net.HttpURLConnection; import java.net.HttpURLConnection;
import java.text.DateFormat;
import java.text.ParseException; import java.text.ParseException;
import java.text.SimpleDateFormat; import java.text.SimpleDateFormat;
import java.util.Collections; import java.util.Collections;
@ -33,16 +30,11 @@ import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.ExecutionException; import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future; import java.util.concurrent.Future;
import androidx.annotation.NonNull;
import io.reactivex.Single; import io.reactivex.Single;
@Deprecated @Deprecated
public class UpdateRepos { public class UpdateRepos {
private static final DateFormat DATE_FORMAT;
static {
DATE_FORMAT = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", Locale.US);
DATE_FORMAT.setTimeZone(TimeZone.getTimeZone("UTC"));
}
@NonNull @NonNull
private final RepoDatabaseHelper repoDB; private final RepoDatabaseHelper repoDB;
@ -71,6 +63,17 @@ public class UpdateRepos {
} }
} }
/**
* Static instance of (Simple)DateFormat is not threadsafe so in order to make it safe it needs
* to be created beforehand on the same thread where it'll be used.
* See https://stackoverflow.com/a/18383395
*/
private static SimpleDateFormat getDateFormat() {
SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", Locale.US);
format.setTimeZone(TimeZone.getTimeZone("UTC"));
return format;
}
/* We sort repos by last push, which means that we only need to check whether the /* We sort repos by last push, which means that we only need to check whether the
* first page is updated to determine whether the online repo database is changed * first page is updated to determine whether the online repo database is changed
*/ */
@ -95,10 +98,12 @@ public class UpdateRepos {
return true; return true;
try { try {
SimpleDateFormat dateFormat = getDateFormat();
for (int i = 0; i < res.getResult().length(); i++) { for (int i = 0; i < res.getResult().length(); i++) {
JSONObject rawRepo = res.getResult().getJSONObject(i); JSONObject rawRepo = res.getResult().getJSONObject(i);
String id = rawRepo.getString("name"); String id = rawRepo.getString("name");
Date date = DATE_FORMAT.parse(rawRepo.getString("pushed_at")); Date date = dateFormat.parse(rawRepo.getString("pushed_at"));
moduleQueue.offer(new Pair<>(id, date)); moduleQueue.offer(new Pair<>(id, date));
} }
} catch (JSONException | ParseException e) { } catch (JSONException | ParseException e) {