Only try to install APK when no manager is active

This commit is contained in:
topjohnwu 2020-12-09 02:15:16 -08:00
parent 1232113772
commit 7ff22c68c7

View File

@ -363,17 +363,18 @@ void boot_complete(int client) {
if (pfs_done) if (pfs_done)
auto_start_magiskhide(); auto_start_magiskhide();
if (!check_manager()) {
if (access(MANAGERAPK, F_OK) == 0) { if (access(MANAGERAPK, F_OK) == 0) {
// Install Magisk Manager if exists // Only try to install APK when no manager is installed
// Magisk Manager should be upgraded by itself, not through recovery installs
rename(MANAGERAPK, "/data/magisk.apk"); rename(MANAGERAPK, "/data/magisk.apk");
install_apk("/data/magisk.apk"); install_apk("/data/magisk.apk");
} else { } else {
// Check whether we have manager installed
if (!check_manager()) {
// Install stub // Install stub
auto init = MAGISKTMP + "/magiskinit"; auto init = MAGISKTMP + "/magiskinit";
exec_command_sync(init.data(), "-x", "manager", "/data/magisk.apk"); exec_command_sync(init.data(), "-x", "manager", "/data/magisk.apk");
install_apk("/data/magisk.apk"); install_apk("/data/magisk.apk");
} }
} }
unlink(MANAGERAPK);
} }