From 86551909fccf2f900c151440844a2c3f87ce4d40 Mon Sep 17 00:00:00 2001
From: Viktor De Pasquale <info@depasquale.wiki>
Date: Wed, 30 Oct 2019 17:54:43 +0100
Subject: [PATCH] Added safe mode notice to modules screen

---
 .../magisk/redesign/module/ModuleFragment.kt  |  3 ++
 .../magisk/redesign/module/ModuleViewModel.kt | 13 ++++-
 .../main/res/layout/fragment_module_md2.xml   | 49 +++++++++++++++++--
 app/src/main/res/values/strings_md2.xml       |  2 +
 4 files changed, 63 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/com/topjohnwu/magisk/redesign/module/ModuleFragment.kt b/app/src/main/java/com/topjohnwu/magisk/redesign/module/ModuleFragment.kt
index 51117413f..c252eaf18 100644
--- a/app/src/main/java/com/topjohnwu/magisk/redesign/module/ModuleFragment.kt
+++ b/app/src/main/java/com/topjohnwu/magisk/redesign/module/ModuleFragment.kt
@@ -1,5 +1,6 @@
 package com.topjohnwu.magisk.redesign.module
 
+import android.graphics.Insets
 import com.topjohnwu.magisk.R
 import com.topjohnwu.magisk.databinding.FragmentModuleMd2Binding
 import com.topjohnwu.magisk.redesign.compat.CompatFragment
@@ -10,6 +11,8 @@ class ModuleFragment : CompatFragment<ModuleViewModel, FragmentModuleMd2Binding>
     override val layoutRes = R.layout.fragment_module_md2
     override val viewModel by viewModel<ModuleViewModel>()
 
+    override fun consumeSystemWindowInsets(insets: Insets) = insets
+
     override fun onStart() {
         super.onStart()
 
diff --git a/app/src/main/java/com/topjohnwu/magisk/redesign/module/ModuleViewModel.kt b/app/src/main/java/com/topjohnwu/magisk/redesign/module/ModuleViewModel.kt
index 8ae35ecb0..35979b2e7 100644
--- a/app/src/main/java/com/topjohnwu/magisk/redesign/module/ModuleViewModel.kt
+++ b/app/src/main/java/com/topjohnwu/magisk/redesign/module/ModuleViewModel.kt
@@ -1,5 +1,16 @@
 package com.topjohnwu.magisk.redesign.module
 
+import com.topjohnwu.magisk.BR
+import com.topjohnwu.magisk.model.entity.recycler.ModuleRvItem
 import com.topjohnwu.magisk.redesign.compat.CompatViewModel
+import com.topjohnwu.magisk.redesign.home.itemBindingOf
+import com.topjohnwu.magisk.redesign.superuser.diffListOf
 
-class ModuleViewModel : CompatViewModel()
\ No newline at end of file
+class ModuleViewModel : CompatViewModel() {
+
+    val items = diffListOf<ModuleRvItem>()
+    val itemBinding = itemBindingOf<ModuleRvItem> {
+        it.bindExtra(BR.viewModel, this)
+    }
+
+}
\ No newline at end of file
diff --git a/app/src/main/res/layout/fragment_module_md2.xml b/app/src/main/res/layout/fragment_module_md2.xml
index aec90e437..36d00c488 100644
--- a/app/src/main/res/layout/fragment_module_md2.xml
+++ b/app/src/main/res/layout/fragment_module_md2.xml
@@ -1,8 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
-<layout xmlns:android="http://schemas.android.com/apk/res/android">
+<layout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools">
 
     <data>
 
+        <import type="com.topjohnwu.magisk.Config" />
+
         <variable
             name="viewModel"
             type="com.topjohnwu.magisk.redesign.module.ModuleViewModel" />
@@ -11,12 +15,51 @@
 
     <androidx.core.widget.NestedScrollView
         android:layout_width="match_parent"
+        android:clipToPadding="false"
         android:layout_height="match_parent"
-        android:fillViewport="true">
+        android:fillViewport="true"
+        android:paddingTop="@{viewModel.insets.top + (int) @dimen/internal_action_bar_size}"
+        android:paddingBottom="@{viewModel.insets.bottom + (int) @dimen/l2}"
+        tools:paddingTop="24dp">
 
         <androidx.constraintlayout.widget.ConstraintLayout
             android:layout_width="match_parent"
-            android:layout_height="wrap_content" />
+            android:layout_height="wrap_content">
+
+            <com.google.android.material.card.MaterialCardView
+                android:id="@+id/module_notice"
+                style="?styleCardNormal"
+                gone="@{!Config.coreOnly}"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:layout_margin="@dimen/l1"
+                android:visibility="gone"
+                app:cardBackgroundColor="?colorError"
+                app:layout_constraintTop_toTopOf="parent"
+                tools:visibility="visible">
+
+                <androidx.appcompat.widget.AppCompatTextView
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:gravity="center"
+                    android:padding="@dimen/l1"
+                    android:text="@string/module_safe_mode_message"
+                    android:textAppearance="?appearanceTextCaptionOnPrimary"
+                    android:textStyle="bold" />
+
+            </com.google.android.material.card.MaterialCardView>
+
+            <androidx.recyclerview.widget.RecyclerView
+                itemBinding="@{viewModel.itemBinding}"
+                items="@{viewModel.items}"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:layout_marginTop="@dimen/l1"
+                android:orientation="vertical"
+                app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
+                app:layout_constraintTop_toBottomOf="@+id/module_notice" />
+
+        </androidx.constraintlayout.widget.ConstraintLayout>
 
     </androidx.core.widget.NestedScrollView>
 
diff --git a/app/src/main/res/values/strings_md2.xml b/app/src/main/res/values/strings_md2.xml
index 39e731cdb..6f01e8357 100644
--- a/app/src/main/res/values/strings_md2.xml
+++ b/app/src/main/res/values/strings_md2.xml
@@ -68,4 +68,6 @@
     <string name="install_next">Next</string>
     <string name="install_start">Let\'s go</string>
 
+    <string name="module_safe_mode_message">You\'re in safe mode. None of user modules will work.\nThis message will disappear once safe mode is disabled.</string>
+
 </resources>
\ No newline at end of file