Cleanup arch classes

app/src/main/java/com/topjohnwu/magisk/arch/BaseFragment.kt

@@ -13,14 +13,12 @@ import androidx.navigation.NavDirections
 import com.topjohnwu.magisk.BR
 import com.topjohnwu.magisk.ktx.startAnimations
 
-abstract class BaseUIFragment<VM : BaseViewModel, Binding : ViewDataBinding> :
+abstract class BaseFragment<Binding : ViewDataBinding> : Fragment(), ViewModelHolder {
-    Fragment(), BaseUIComponent<VM> {
 
-    val activity get() = requireActivity() as BaseUIActivity<*, *>
+    val activity get() = requireActivity() as NavigationActivity<*>
     protected lateinit var binding: Binding
     protected abstract val layoutRes: Int
 
-    override val viewRoot: View get() = binding.root
     private val navigation get() = activity.navigation
     open val snackbarAnchorView: View? get() = null
 
@@ -64,7 +62,7 @@ abstract class BaseUIFragment<VM : BaseViewModel, Binding : ViewDataBinding> :
         super.onViewCreated(view, savedInstanceState)
         binding.addOnRebindCallback(object : OnRebindCallback<Binding>() {
             override fun onPreBind(binding: Binding): Boolean {
-                this@BaseUIFragment.onPreBind(binding)
+                this@BaseFragment.onPreBind(binding)
                 return true
             }
         })

app/src/main/java/com/topjohnwu/magisk/arch/BaseMainActivity.kt

@@ -21,8 +21,7 @@ import com.topjohnwu.superuser.Shell
 import java.util.concurrent.CountDownLatch
 import java.util.concurrent.TimeUnit
 
-abstract class BaseMainActivity<VM : BaseViewModel, Binding : ViewDataBinding>
+abstract class BaseMainActivity<Binding : ViewDataBinding> : NavigationActivity<Binding>() {
-    : BaseUIActivity<VM, Binding>() {
 
     companion object {
         private var doPreload = true

app/src/main/java/com/topjohnwu/magisk/arch/NavigationActivity.kt

@@ -0,0 +1,35 @@
+package com.topjohnwu.magisk.arch
+
+import android.view.KeyEvent
+import androidx.databinding.ViewDataBinding
+import androidx.navigation.NavController
+import androidx.navigation.NavDirections
+import androidx.navigation.fragment.NavHostFragment
+
+abstract class NavigationActivity<Binding : ViewDataBinding> : UIActivity<Binding>() {
+
+    abstract val navHostId: Int
+
+    private val navHostFragment by lazy {
+        supportFragmentManager.findFragmentById(navHostId) as NavHostFragment
+    }
+
+    protected val currentFragment get() =
+        navHostFragment.childFragmentManager.fragments.getOrNull(0) as? BaseFragment<*>
+
+    val navigation: NavController get() = navHostFragment.navController
+
+    override fun dispatchKeyEvent(event: KeyEvent): Boolean {
+        return currentFragment?.onKeyEvent(event) == true || super.dispatchKeyEvent(event)
+    }
+
+    override fun onBackPressed() {
+        if (currentFragment?.onBackPressed()?.not() == true) {
+            super.onBackPressed()
+        }
+    }
+
+    fun NavDirections.navigate() {
+        navigation.navigate(this)
+    }
+}

app/src/main/java/com/topjohnwu/magisk/arch/UIActivity.kt

@@ -4,37 +4,22 @@ import android.content.res.Resources
 import android.graphics.Color
 import android.os.Build
 import android.os.Bundle
-import android.view.KeyEvent
 import android.view.View
 import androidx.appcompat.app.AppCompatDelegate
 import androidx.core.content.res.use
 import androidx.databinding.DataBindingUtil
 import androidx.databinding.ViewDataBinding
-import androidx.navigation.NavController
-import androidx.navigation.NavDirections
-import androidx.navigation.fragment.NavHostFragment
 import com.topjohnwu.magisk.BR
 import com.topjohnwu.magisk.core.Config
 import com.topjohnwu.magisk.core.base.BaseActivity
 import rikka.insets.WindowInsetsHelper
 import rikka.layoutinflater.view.LayoutInflaterFactory
 
-abstract class BaseUIActivity<VM : BaseViewModel, Binding : ViewDataBinding> :
+abstract class UIActivity<Binding : ViewDataBinding> : BaseActivity(), ViewModelHolder {
-    BaseActivity(), BaseUIComponent<VM> {
 
     protected lateinit var binding: Binding
     protected abstract val layoutRes: Int
 
-    private val navHostFragment by lazy {
-        supportFragmentManager.findFragmentById(navHostId) as? NavHostFragment
-    }
-    private val topFragment get() = navHostFragment?.childFragmentManager?.fragments?.getOrNull(0)
-    protected val currentFragment get() = topFragment as? BaseUIFragment<*, *>
-
-    override val viewRoot: View get() = binding.root
-    open val navigation: NavController? get() = navHostFragment?.navController
-
-    open val navHostId: Int = 0
     open val snackbarView get() = binding.root
     open val snackbarAnchorView: View? get() = null
 
@@ -89,7 +74,7 @@ abstract class BaseUIActivity<VM : BaseViewModel, Binding : ViewDataBinding> :
     }
 
     fun setAccessibilityDelegate(delegate: View.AccessibilityDelegate?) {
-        viewRoot.rootView.accessibilityDelegate = delegate
+        binding.root.rootView.accessibilityDelegate = delegate
     }
 
     override fun onResume() {
@@ -97,23 +82,9 @@ abstract class BaseUIActivity<VM : BaseViewModel, Binding : ViewDataBinding> :
         viewModel.requestRefresh()
     }
 
-    override fun dispatchKeyEvent(event: KeyEvent): Boolean {
-        return currentFragment?.onKeyEvent(event) == true || super.dispatchKeyEvent(event)
-    }
-
     override fun onEventDispatched(event: ViewEvent) = when (event) {
         is ContextExecutor -> event(this)
         is ActivityExecutor -> event(this)
         else -> Unit
     }
-
-    override fun onBackPressed() {
-        if (navigation == null || currentFragment?.onBackPressed()?.not() == true) {
-            super.onBackPressed()
-        }
-    }
-
-    fun NavDirections.navigate() {
-        navigation?.navigate(this)
-    }
 }

app/src/main/java/com/topjohnwu/magisk/arch/ViewEvent.kt

@@ -18,9 +18,9 @@ interface ContextExecutor {
 }
 
 interface ActivityExecutor {
-    operator fun invoke(activity: BaseUIActivity<*, *>)
+    operator fun invoke(activity: UIActivity<*>)
 }
 
 interface FragmentExecutor {
-    operator fun invoke(fragment: BaseUIFragment<*, *>)
+    operator fun invoke(fragment: BaseFragment<*>)
 }

app/src/main/java/com/topjohnwu/magisk/arch/ViewModelHolder.kt

@@ -1,12 +1,10 @@
 package com.topjohnwu.magisk.arch
 
-import android.view.View
 import androidx.lifecycle.LifecycleOwner
 
-interface BaseUIComponent<VM : BaseViewModel> : LifecycleOwner {
+interface ViewModelHolder : LifecycleOwner {
 
-    val viewRoot: View
+    val viewModel: BaseViewModel
-    val viewModel: VM
 
     fun startObserveEvents() {
         viewModel.viewEvents.observe(this) {

app/src/main/java/com/topjohnwu/magisk/events/SnackbarEvent.kt

@@ -4,7 +4,7 @@ import android.view.View
 import androidx.annotation.StringRes
 import com.google.android.material.snackbar.Snackbar
 import com.topjohnwu.magisk.arch.ActivityExecutor
-import com.topjohnwu.magisk.arch.BaseUIActivity
+import com.topjohnwu.magisk.arch.UIActivity
 import com.topjohnwu.magisk.arch.ViewEvent
 import com.topjohnwu.magisk.utils.TextHolder
 import com.topjohnwu.magisk.utils.asText
@@ -36,7 +36,7 @@ class SnackbarEvent constructor(
         builder: Snackbar.() -> Unit
     ) = Snackbar.make(view, message, length).setAnchorView(anchor).apply(builder).show()
 
-    override fun invoke(activity: BaseUIActivity<*, *>) {
+    override fun invoke(activity: UIActivity<*>) {
         snackbar(activity.snackbarView, activity.snackbarAnchorView,
             msg.getText(activity.resources).toString(),
             length, builder)

app/src/main/java/com/topjohnwu/magisk/events/ViewEvents.kt

@@ -18,32 +18,32 @@ class PermissionEvent(
     private val callback: (Boolean) -> Unit
 ) : ViewEvent(), ActivityExecutor {
 
-    override fun invoke(activity: BaseUIActivity<*, *>) =
+    override fun invoke(activity: UIActivity<*>) =
         activity.withPermission(permission, callback)
 }
 
 class BackPressEvent : ViewEvent(), ActivityExecutor {
-    override fun invoke(activity: BaseUIActivity<*, *>) {
+    override fun invoke(activity: UIActivity<*>) {
         activity.onBackPressed()
     }
 }
 
 class DieEvent : ViewEvent(), ActivityExecutor {
-    override fun invoke(activity: BaseUIActivity<*, *>) {
+    override fun invoke(activity: UIActivity<*>) {
         activity.finish()
     }
 }
 
 class ShowUIEvent(private val delegate: View.AccessibilityDelegate?)
     : ViewEvent(), ActivityExecutor {
-    override fun invoke(activity: BaseUIActivity<*, *>) {
+    override fun invoke(activity: UIActivity<*>) {
         activity.setContentView()
         activity.setAccessibilityDelegate(delegate)
     }
 }
 
 class RecreateEvent : ViewEvent(), ActivityExecutor {
-    override fun invoke(activity: BaseUIActivity<*, *>) {
+    override fun invoke(activity: UIActivity<*>) {
         activity.recreate()
     }
 }
@@ -51,7 +51,7 @@ class RecreateEvent : ViewEvent(), ActivityExecutor {
 class MagiskInstallFileEvent(
     private val callback: (Uri) -> Unit
 ) : ViewEvent(), ActivityExecutor {
-    override fun invoke(activity: BaseUIActivity<*, *>) {
+    override fun invoke(activity: UIActivity<*>) {
         try {
             activity.getContent("*/*", callback)
             Utils.toast(R.string.patch_file_msg, Toast.LENGTH_LONG)
@@ -65,8 +65,8 @@ class NavigationEvent(
     private val directions: NavDirections,
     private val pop: Boolean
 ) : ViewEvent(), ActivityExecutor {
-    override fun invoke(activity: BaseUIActivity<*, *>) {
+    override fun invoke(activity: UIActivity<*>) {
-        (activity as? BaseUIActivity<*, *>)?.apply {
+        (activity as? NavigationActivity<*>)?.apply {
             if (pop) navigation?.popBackStack()
             directions.navigate()
         }
@@ -80,7 +80,7 @@ class AddHomeIconEvent : ViewEvent(), ContextExecutor {
 }
 
 class SelectModuleEvent : ViewEvent(), FragmentExecutor {
-    override fun invoke(fragment: BaseUIFragment<*, *>) {
+    override fun invoke(fragment: BaseFragment<*>) {
         try {
             fragment.apply {
                 activity.getContent("application/zip") {

app/src/main/java/com/topjohnwu/magisk/events/dialog/BiometricEvent.kt

@@ -1,7 +1,7 @@
 package com.topjohnwu.magisk.events.dialog
 
 import com.topjohnwu.magisk.arch.ActivityExecutor
-import com.topjohnwu.magisk.arch.BaseUIActivity
+import com.topjohnwu.magisk.arch.UIActivity
 import com.topjohnwu.magisk.arch.ViewEvent
 import com.topjohnwu.magisk.core.utils.BiometricHelper
 
@@ -16,7 +16,7 @@ class BiometricEvent(
         builder(Builder())
     }
 
-    override fun invoke(activity: BaseUIActivity<*, *>) {
+    override fun invoke(activity: UIActivity<*>) {
         BiometricHelper.authenticate(
             activity,
             onError = listenerOnFailure,

app/src/main/java/com/topjohnwu/magisk/events/dialog/DialogEvent.kt

@@ -1,13 +1,13 @@
 package com.topjohnwu.magisk.events.dialog
 
 import com.topjohnwu.magisk.arch.ActivityExecutor
-import com.topjohnwu.magisk.arch.BaseUIActivity
+import com.topjohnwu.magisk.arch.UIActivity
 import com.topjohnwu.magisk.arch.ViewEvent
 import com.topjohnwu.magisk.view.MagiskDialog
 
 abstract class DialogEvent : ViewEvent(), ActivityExecutor {
 
-    override fun invoke(activity: BaseUIActivity<*, *>) {
+    override fun invoke(activity: UIActivity<*>) {
         MagiskDialog(activity)
             .apply { setOwnerActivity(activity) }
             .apply(this::build).show()

app/src/main/java/com/topjohnwu/magisk/events/dialog/UninstallDialog.kt

@@ -4,7 +4,7 @@ import android.app.ProgressDialog
 import android.content.Context
 import android.widget.Toast
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIActivity
+import com.topjohnwu.magisk.arch.NavigationActivity
 import com.topjohnwu.magisk.ui.flash.FlashFragment
 import com.topjohnwu.magisk.utils.Utils
 import com.topjohnwu.magisk.view.MagiskDialog
@@ -45,8 +45,8 @@ class UninstallDialog : DialogEvent() {
     }
 
     private fun completeUninstall(dialog: MagiskDialog) {
-        (dialog.ownerActivity as BaseUIActivity<*, *>)
+        (dialog.ownerActivity as NavigationActivity<*>)
-            .navigation?.navigate(FlashFragment.uninstall())
+            .navigation.navigate(FlashFragment.uninstall())
     }
 
 }

app/src/main/java/com/topjohnwu/magisk/ui/MainActivity.kt

@@ -27,7 +27,7 @@ import java.io.File
 
 class MainViewModel : BaseViewModel()
 
-class MainActivity : BaseMainActivity<MainViewModel, ActivityMainMd2Binding>() {
+class MainActivity : BaseMainActivity<ActivityMainMd2Binding>() {
 
     override val layoutRes = R.layout.activity_main_md2
     override val viewModel by viewModel<MainViewModel>()

app/src/main/java/com/topjohnwu/magisk/ui/deny/DenyListFragment.kt

@@ -9,7 +9,7 @@ import android.view.View
 import androidx.appcompat.widget.SearchView
 import androidx.recyclerview.widget.RecyclerView
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIFragment
+import com.topjohnwu.magisk.arch.BaseFragment
 import com.topjohnwu.magisk.databinding.FragmentDenyMd2Binding
 import com.topjohnwu.magisk.di.viewModel
 import com.topjohnwu.magisk.ktx.hideKeyboard
@@ -17,7 +17,7 @@ import rikka.recyclerview.addEdgeSpacing
 import rikka.recyclerview.addItemSpacing
 import rikka.recyclerview.fixEdgeEffect
 
-class DenyListFragment : BaseUIFragment<DenyListViewModel, FragmentDenyMd2Binding>() {
+class DenyListFragment : BaseFragment<FragmentDenyMd2Binding>() {
 
     override val layoutRes = R.layout.fragment_deny_md2
     override val viewModel by viewModel<DenyListViewModel>()

app/src/main/java/com/topjohnwu/magisk/ui/flash/FlashFragment.kt

@@ -9,14 +9,14 @@ import android.view.*
 import androidx.navigation.NavDeepLinkBuilder
 import com.topjohnwu.magisk.MainDirections
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIFragment
+import com.topjohnwu.magisk.arch.BaseFragment
 import com.topjohnwu.magisk.core.Const
 import com.topjohnwu.magisk.core.cmp
 import com.topjohnwu.magisk.databinding.FragmentFlashMd2Binding
 import com.topjohnwu.magisk.di.viewModel
 import com.topjohnwu.magisk.ui.MainActivity
 
-class FlashFragment : BaseUIFragment<FlashViewModel, FragmentFlashMd2Binding>() {
+class FlashFragment : BaseFragment<FragmentFlashMd2Binding>() {
 
     override val layoutRes = R.layout.fragment_flash_md2
     override val viewModel by viewModel<FlashViewModel>()

app/src/main/java/com/topjohnwu/magisk/ui/home/HomeFragment.kt

@@ -5,14 +5,14 @@ import android.view.*
 import android.widget.ImageView
 import android.widget.TextView
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIFragment
+import com.topjohnwu.magisk.arch.BaseFragment
 import com.topjohnwu.magisk.core.download.DownloadService
 import com.topjohnwu.magisk.databinding.FragmentHomeMd2Binding
 import com.topjohnwu.magisk.di.viewModel
 import com.topjohnwu.magisk.events.RebootEvent
 import com.topjohnwu.superuser.Shell
 
-class HomeFragment : BaseUIFragment<HomeViewModel, FragmentHomeMd2Binding>() {
+class HomeFragment : BaseFragment<FragmentHomeMd2Binding>() {
 
     override val layoutRes = R.layout.fragment_home_md2
     override val viewModel by viewModel<HomeViewModel>()

app/src/main/java/com/topjohnwu/magisk/ui/home/HomeViewModel.kt

@@ -106,7 +106,7 @@ class HomeViewModel(
     val showTest = false
 
     fun onTestPressed() = object : ViewEvent(), ActivityExecutor {
-        override fun invoke(activity: BaseUIActivity<*, *>) {
+        override fun invoke(activity: UIActivity<*>) {
             /* Entry point to trigger test events within the app */
         }
     }.publish()

app/src/main/java/com/topjohnwu/magisk/ui/install/InstallFragment.kt

@@ -5,11 +5,11 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIFragment
+import com.topjohnwu.magisk.arch.BaseFragment
 import com.topjohnwu.magisk.databinding.FragmentInstallMd2Binding
 import com.topjohnwu.magisk.di.viewModel
 
-class InstallFragment : BaseUIFragment<InstallViewModel, FragmentInstallMd2Binding>() {
+class InstallFragment : BaseFragment<FragmentInstallMd2Binding>() {
 
     override val layoutRes = R.layout.fragment_install_md2
     override val viewModel by viewModel<InstallViewModel>()

app/src/main/java/com/topjohnwu/magisk/ui/log/LogFragment.kt

@@ -7,7 +7,7 @@ import android.view.MenuItem
 import android.view.View
 import androidx.core.view.isVisible
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIFragment
+import com.topjohnwu.magisk.arch.BaseFragment
 import com.topjohnwu.magisk.databinding.FragmentLogMd2Binding
 import com.topjohnwu.magisk.di.viewModel
 import com.topjohnwu.magisk.ui.MainActivity
@@ -16,7 +16,7 @@ import rikka.recyclerview.addEdgeSpacing
 import rikka.recyclerview.addItemSpacing
 import rikka.recyclerview.fixEdgeEffect
 
-class LogFragment : BaseUIFragment<LogViewModel, FragmentLogMd2Binding>() {
+class LogFragment : BaseFragment<FragmentLogMd2Binding>() {
 
     override val layoutRes = R.layout.fragment_log_md2
     override val viewModel by viewModel<LogViewModel>()

app/src/main/java/com/topjohnwu/magisk/ui/module/ModuleFragment.kt

@@ -3,7 +3,7 @@ package com.topjohnwu.magisk.ui.module
 import android.os.Bundle
 import android.view.View
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIFragment
+import com.topjohnwu.magisk.arch.BaseFragment
 import com.topjohnwu.magisk.databinding.FragmentModuleMd2Binding
 import com.topjohnwu.magisk.di.viewModel
 import rikka.recyclerview.addEdgeSpacing
@@ -11,7 +11,7 @@ import rikka.recyclerview.addInvalidateItemDecorationsObserver
 import rikka.recyclerview.addItemSpacing
 import rikka.recyclerview.fixEdgeEffect
 
-class ModuleFragment : BaseUIFragment<ModuleViewModel, FragmentModuleMd2Binding>() {
+class ModuleFragment : BaseFragment<FragmentModuleMd2Binding>() {
 
     override val layoutRes = R.layout.fragment_module_md2
     override val viewModel by viewModel<ModuleViewModel>()

app/src/main/java/com/topjohnwu/magisk/ui/settings/SettingsFragment.kt

@@ -3,14 +3,14 @@ package com.topjohnwu.magisk.ui.settings
 import android.os.Bundle
 import android.view.View
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIFragment
+import com.topjohnwu.magisk.arch.BaseFragment
 import com.topjohnwu.magisk.databinding.FragmentSettingsMd2Binding
 import com.topjohnwu.magisk.di.viewModel
 import rikka.recyclerview.addEdgeSpacing
 import rikka.recyclerview.addItemSpacing
 import rikka.recyclerview.fixEdgeEffect
 
-class SettingsFragment : BaseUIFragment<SettingsViewModel, FragmentSettingsMd2Binding>() {
+class SettingsFragment : BaseFragment<FragmentSettingsMd2Binding>() {
 
     override val layoutRes = R.layout.fragment_settings_md2
     override val viewModel by viewModel<SettingsViewModel>()

app/src/main/java/com/topjohnwu/magisk/ui/superuser/SuperuserFragment.kt

@@ -3,14 +3,14 @@ package com.topjohnwu.magisk.ui.superuser
 import android.os.Bundle
 import android.view.View
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIFragment
+import com.topjohnwu.magisk.arch.BaseFragment
 import com.topjohnwu.magisk.databinding.FragmentSuperuserMd2Binding
 import com.topjohnwu.magisk.di.viewModel
 import rikka.recyclerview.addEdgeSpacing
 import rikka.recyclerview.addItemSpacing
 import rikka.recyclerview.fixEdgeEffect
 
-class SuperuserFragment : BaseUIFragment<SuperuserViewModel, FragmentSuperuserMd2Binding>() {
+class SuperuserFragment : BaseFragment<FragmentSuperuserMd2Binding>() {
 
     override val layoutRes = R.layout.fragment_superuser_md2
     override val viewModel by viewModel<SuperuserViewModel>()

app/src/main/java/com/topjohnwu/magisk/ui/surequest/SuRequestActivity.kt

@@ -7,20 +7,18 @@ import android.os.Build
 import android.os.Bundle
 import android.view.Window
 import android.view.WindowManager
-import androidx.navigation.NavController
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIActivity
+import com.topjohnwu.magisk.arch.UIActivity
 import com.topjohnwu.magisk.core.su.SuCallbackHandler
 import com.topjohnwu.magisk.core.su.SuCallbackHandler.REQUEST
 import com.topjohnwu.magisk.databinding.ActivityRequestBinding
 import com.topjohnwu.magisk.di.viewModel
 import com.topjohnwu.magisk.ui.theme.Theme
 
-open class SuRequestActivity : BaseUIActivity<SuRequestViewModel, ActivityRequestBinding>() {
+open class SuRequestActivity : UIActivity<ActivityRequestBinding>() {
 
     override val layoutRes: Int = R.layout.activity_request
     override val viewModel: SuRequestViewModel by viewModel()
-    override val navigation: NavController? = null
 
     override fun onBackPressed() {
         viewModel.denyPressed()

app/src/main/java/com/topjohnwu/magisk/ui/theme/ThemeFragment.kt

@@ -8,12 +8,12 @@ import android.view.ViewGroup
 import android.widget.FrameLayout
 import com.topjohnwu.magisk.BR
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.arch.BaseUIFragment
+import com.topjohnwu.magisk.arch.BaseFragment
 import com.topjohnwu.magisk.databinding.FragmentThemeMd2Binding
 import com.topjohnwu.magisk.databinding.ItemThemeBindingImpl
 import com.topjohnwu.magisk.di.viewModel
 
-class ThemeFragment : BaseUIFragment<ThemeViewModel, FragmentThemeMd2Binding>() {
+class ThemeFragment : BaseFragment<FragmentThemeMd2Binding>() {
 
     override val layoutRes = R.layout.fragment_theme_md2
     override val viewModel by viewModel<ThemeViewModel>()