From 916e373edba1ca18b3356e51b7e0b6be9c18c5e1 Mon Sep 17 00:00:00 2001 From: akhilkedia <16665267+akhilkedia@users.noreply.github.com> Date: Thu, 20 Oct 2022 17:47:13 +0900 Subject: [PATCH] Update README.md to specify python version 3.8+ Current readme suggests python 3.6+ However, the file `build.py` on executing `build.py ndk` runs the command `shutil.copytree(src_dir, lib_dir, copy_function=cp, dirs_exist_ok=True)` This command errors out on python 3.7, because the `dirs_exist_ok` parameter is new in Python 3.8 (https://docs.python.org/3/library/shutil.html#shutil.copytree) So the README should suggest python 3.8+ --- README.MD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.MD b/README.MD index 80824624a..8abd73a75 100644 --- a/README.MD +++ b/README.MD @@ -41,7 +41,7 @@ For Magisk app crashes, record and upload the logcat when the crash occurs. - Magisk builds on any OS Android Studio supports. Install Android Studio and do the initial setups. - Clone sources: `git clone --recurse-submodules https://github.com/topjohnwu/Magisk.git` -- Install Python 3.6+ \ +- Install Python 3.8+ \ (Windows only: select **'Add Python to PATH'** in installer, and run `pip install colorama` after install) - Configure to use the JDK bundled in Android Studio: - macOS: `export JAVA_HOME="/Applications/Android Studio.app/Contents/jre/Contents/Home"`