Don't skip fd sanitization if fds_to_ignore does not exist

This commit is contained in:
Wang Han 2023-09-23 16:05:14 +08:00 committed by John Wu
parent 9b3896fd3d
commit ec115cd7e3

View File

@ -691,9 +691,10 @@ void HookContext::nativeForkAndSpecialize_pre() {
flags[APP_FORK_AND_SPECIALIZE] = true; flags[APP_FORK_AND_SPECIALIZE] = true;
if (args.app->fds_to_ignore == nullptr) { if (args.app->fds_to_ignore == nullptr) {
// if fds_to_ignore does not exist and there's no FileDescriptorTable::Create, // if fds_to_ignore does not exist, we do not have a good way to determine
// we can skip fd sanitization // whether keeping fd open during fork is allowed, as needed symbols may be
flags[SKIP_FD_SANITIZATION] = !dlsym(RTLD_DEFAULT, "_ZN19FileDescriptorTable6CreateEv"); // inlined. Better be safe than sorry.
flags[SKIP_FD_SANITIZATION] = false;
} else { } else {
int logd_fd = magiskd.get_log_pipe(); int logd_fd = magiskd.get_log_pipe();
if (logd_fd >= 0) { if (logd_fd >= 0) {