mirror of
https://github.com/topjohnwu/Magisk.git
synced 2025-02-17 18:48:30 +00:00
15 lines
1.1 KiB
Plaintext
15 lines
1.1 KiB
Plaintext
tree f51c29e72693fb46a613ebb28980a1eee13cdfa8
|
|
parent d1f301e05993fefc17a5beadd8b60378dce70901
|
|
author topjohnwu <topjohnwu@gmail.com> 1528921824 +0800
|
|
committer topjohnwu <topjohnwu@gmail.com> 1528921824 +0800
|
|
|
|
Re-implement duplicate Magisk Manager logic
|
|
|
|
Starting from the next Magisk release, it will no longer prefer the package name com.topjohnwu.magisk over a hidden manager; it will always be aware whether the hidden manager exists, so when a package named com.topjohnwu.magisk is installed alongside with the hidden manager, com.topjohnwu.magisk will not have root access by default.
|
|
This will prevent malware from using the package name com.topjohnwu.magisk to gain root access when a user is using a hidden manager.
|
|
To support this new behavior, several changes has to be done:
|
|
- Never grant com.topjohnwu.magisk in Magisk Manager (if it IS the actual manager, MagiskSU will grant it by default)
|
|
- While hidden, remove com.topjohnwu.magisk if exists
|
|
- Restore Magisk Manager (unhide) has to be done with root
|
|
- Upgrading Magisk Manager should preserve package name (implemented in a949641)
|