headscale/.golangci.yaml

---
run:
  timeout: 10m
  build-tags:
    - ts2019

issues:
  skip-dirs:
    - gen
linters:
  enable-all: true
  disable:
    - depguard

    - revive
    - lll
    - gofmt
    - gochecknoglobals
    - gochecknoinits
    - gocognit
    - funlen
    - tagliatelle
    - godox
    - ireturn
    - execinquery
    - exhaustruct
    - nolintlint
    - musttag # causes issues with imported libs
    - depguard
    - exportloopref

    # We should strive to enable these:
    - wrapcheck
    - dupl
    - makezero
    - maintidx

    # Limits the methods of an interface to 10. We have more in integration tests
    - interfacebloat

    # We might want to enable this, but it might be a lot of work
    - cyclop
    - nestif
    - wsl # might be incompatible with gofumpt
    - testpackage
    - paralleltest

linters-settings:
  varnamelen:
    ignore-type-assert-ok: true
    ignore-map-index-ok: true
    ignore-names:
      - err
      - db
      - id
      - ip
      - ok
      - c
      - tt
      - tx
      - rx

  gocritic:
    disabled-checks:
      - appendAssign
      # TODO(kradalby): Remove this
      - ifElseChain

  nlreturn:
    block-size: 4
Add golangcilint config 2021-10-27 07:07:19 +00:00			`---`
			`run:`
Align with update golangci-lint 2021-11-13 09:11:03 +00:00			`timeout: 10m`
Added ts2019 buildtag to CI config Otherwise we are getting utils.go:119:6: `decode` is unused (deadcode) Signed-off-by: Juan Font Alonso <juanfontalonso@gmail.com> 2022-11-13 12:34:08 +00:00			`build-tags:`
			`- ts2019`
Add gen explicitly to skip list 2021-10-27 07:08:24 +00:00
			`issues:`
			`skip-dirs:`
			`- gen`
Setup more linters and goals for golangci 2021-11-13 08:53:34 +00:00			`linters:`
			`enable-all: true`
			`disable:`
add annoying linter to golangci Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> 2023-07-17 09:12:59 +00:00			`- depguard`

Setup more linters and goals for golangci 2021-11-13 08:53:34 +00:00			`- revive`
			`- lll`
			`- gofmt`
			`- gochecknoglobals`
			`- gochecknoinits`
			`- gocognit`
			`- funlen`
			`- tagliatelle`
			`- godox`
fix: revert previous commit and add exclusion of linter 2022-05-16 12:29:05 +00:00			`- ireturn`
			`- execinquery`
fix: ignore exhaust linter 2022-05-16 13:13:16 +00:00			`- exhaustruct`
fix bug in #912 (#914) 2022-11-05 08:07:22 +00:00			`- nolintlint`
Remove deprecated linters + one casuing issues with imports 2023-04-04 20:24:47 +00:00			`- musttag # causes issues with imported libs`
General fixups discovered by checking errors There was a lot of tests that actually threw a lot of errors and that did not pass all the way because we didnt check everything. This commit should fix all of these cases. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> 2023-08-31 16:37:18 +00:00			`- depguard`
more linter fixups (#2212) * linter fixes Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * conf Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * update nix hash Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --------- Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> 2024-11-22 15:54:58 +00:00			`- exportloopref`
Remove deprecated linters + one casuing issues with imports 2023-04-04 20:24:47 +00:00
Setup more linters and goals for golangci 2021-11-13 08:53:34 +00:00			`# We should strive to enable these:`
			`- wrapcheck`
			`- dupl`
Remove unused params or returns 2021-11-14 17:03:21 +00:00			`- makezero`
fix: revert previous commit and add exclusion of linter 2022-05-16 12:29:05 +00:00			`- maintidx`
Setup more linters and goals for golangci 2021-11-13 08:53:34 +00:00
disable interfacebloat linter 2022-11-13 16:02:42 +00:00			`# Limits the methods of an interface to 10. We have more in integration tests`
			`- interfacebloat`

Setup more linters and goals for golangci 2021-11-13 08:53:34 +00:00			`# We might want to enable this, but it might be a lot of work`
			`- cyclop`
			`- nestif`
Move wsl, might not be feasible 2021-11-14 15:49:54 +00:00			`- wsl # might be incompatible with gofumpt`
Add and fix errorlint 2021-11-15 16:26:41 +00:00			`- testpackage`
Add and fix forcetypeassert 2021-11-15 18:42:44 +00:00			`- paralleltest`
Add exceptions to var name length 2021-11-15 16:16:16 +00:00
			`linters-settings:`
			`varnamelen:`
			`ignore-type-assert-ok: true`
			`ignore-map-index-ok: true`
			`ignore-names:`
			`- err`
			`- db`
			`- id`
			`- ip`
			`- ok`
			`- c`
chore(linter): ignore tt var as it's generated code (vscode) 2022-02-21 15:10:20 +00:00			`- tt`
more linter fixups (#2212) * linter fixes Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * conf Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * update nix hash Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --------- Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> 2024-11-22 15:54:58 +00:00			`- tx`
			`- rx`
Fix gocritic 2021-11-24 10:13:41 +00:00
			`gocritic:`
			`disabled-checks:`
			`- appendAssign`
			`# TODO(kradalby): Remove this`
			`- ifElseChain`
more linter fixups (#2212) * linter fixes Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * conf Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * update nix hash Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --------- Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> 2024-11-22 15:54:58 +00:00
			`nlreturn:`
			`block-size: 4`