From 39f03b86c808972dd42a3cce9785d0fe7a0cae33 Mon Sep 17 00:00:00 2001
From: Juan Font Alonso <juanfontalonso@gmail.com>
Date: Wed, 8 Jun 2022 18:06:25 +0200
Subject: [PATCH] Added ACL test file

---
 acls_test.go                   | 14 ++++++++++++++
 tests/acls/acl_policy_1.hujson |  1 -
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/acls_test.go b/acls_test.go
index eaf578bf..0d62cbc3 100644
--- a/acls_test.go
+++ b/acls_test.go
@@ -321,6 +321,20 @@ func (s *Suite) TestPortRange(c *check.C) {
 	c.Assert(rules[0].DstPorts[0].Ports.Last, check.Equals, uint16(5500))
 }
 
+func (s *Suite) TestProtocolParsing(c *check.C) {
+	err := app.LoadACLPolicy("./tests/acls/acl_policy_basic_protocols.hujson")
+	c.Assert(err, check.IsNil)
+
+	rules, err := app.generateACLRules()
+	c.Assert(err, check.IsNil)
+	c.Assert(rules, check.NotNil)
+
+	c.Assert(rules, check.HasLen, 3)
+	c.Assert(rules[0].IPProto[0], check.Equals, 6)  // tcp
+	c.Assert(rules[1].IPProto[0], check.Equals, 17) // udp
+	c.Assert(rules[2].IPProto[1], check.Equals, 58) // icmp v4
+}
+
 func (s *Suite) TestPortWildcard(c *check.C) {
 	err := app.LoadACLPolicy("./tests/acls/acl_policy_basic_wildcards.hujson")
 	c.Assert(err, check.IsNil)
diff --git a/tests/acls/acl_policy_1.hujson b/tests/acls/acl_policy_1.hujson
index 3ef1a477..dba403f1 100644
--- a/tests/acls/acl_policy_1.hujson
+++ b/tests/acls/acl_policy_1.hujson
@@ -35,7 +35,6 @@
         // ports on git-server or ci-server.
         {
             "action": "accept",
-            "protocol": "tcp",
             "src": [
                 "group:example2",
                 "192.168.1.0/24"