Also warn in DERP server if Websockets are not properly working

This commit is contained in:
Juan Font Alonso 2022-09-04 16:13:48 +02:00
parent a377ee14b4
commit 5c59255b41

View File

@ -99,10 +99,13 @@ func (h *Headscale) DERPHandler(
req *http.Request, req *http.Request,
) { ) {
log.Trace().Caller().Msgf("/derp request from %v", req.RemoteAddr) log.Trace().Caller().Msgf("/derp request from %v", req.RemoteAddr)
up := strings.ToLower(req.Header.Get("Upgrade")) upgrade := strings.ToLower(req.Header.Get("Upgrade"))
if up != "websocket" && up != "derp" {
if up != "" { if upgrade != "websocket" && upgrade != "derp" {
log.Warn().Caller().Msgf("Weird websockets connection upgrade: %q", up) if upgrade != "" {
log.Warn().
Caller().
Msg("No Upgrade header in DERP server request. If headscale is behind a reverse proxy, make sure it is configured to pass WebSockets through.")
} }
writer.Header().Set("Content-Type", "text/plain") writer.Header().Set("Content-Type", "text/plain")
writer.WriteHeader(http.StatusUpgradeRequired) writer.WriteHeader(http.StatusUpgradeRequired)