From 794e57f1c215b5621a2515402c27791b06153c60 Mon Sep 17 00:00:00 2001 From: Even Holthe Date: Fri, 11 Nov 2022 13:20:12 +0100 Subject: [PATCH] SSH: add test between namespaces --- integration/ssh_test.go | 250 ++++++++++++++++++++++++++++------------ 1 file changed, 178 insertions(+), 72 deletions(-) diff --git a/integration/ssh_test.go b/integration/ssh_test.go index fe364c5e..0fbebdca 100644 --- a/integration/ssh_test.go +++ b/integration/ssh_test.go @@ -7,58 +7,61 @@ import ( "time" "github.com/juanfont/headscale" + "github.com/juanfont/headscale/integration/hsic" + "github.com/juanfont/headscale/integration/tsic" ) +var retry = func(times int, sleepInterval time.Duration, doWork func() (string, error)) (string, error) { + var err error + for attempts := 0; attempts < times; attempts++ { + var result string + result, err = doWork() + if err == nil { + return result, nil + } + time.Sleep(sleepInterval) + } + + return "", err +} + func TestSSHOneNamespaceAllToAll(t *testing.T) { IntegrationSkip(t) - retry := func(times int, sleepInterval time.Duration, doWork func() (string, error)) (string, error) { - var err error - for attempts := 0; attempts < times; attempts++ { - var result string - result, err = doWork() - if err == nil { - return result, nil - } - time.Sleep(sleepInterval) - } - - return "", err - } - scenario, err := NewScenario() if err != nil { t.Errorf("failed to create scenario: %s", err) } - spec := &HeadscaleSpec{ - namespaces: map[string]int{ - "namespace1": len(TailscaleVersions) - 5, - }, - enableSSH: true, - acl: &headscale.ACLPolicy{ - Groups: map[string][]string{ - "group:integration-test": {"namespace1"}, - }, - ACLs: []headscale.ACL{ - { - Action: "accept", - Sources: []string{"*"}, - Destinations: []string{"*:*"}, - }, - }, - SSHs: []headscale.SSH{ - { - Action: "accept", - Sources: []string{"group:integration-test"}, - Destinations: []string{"group:integration-test"}, - Users: []string{"ssh-it-user"}, - }, - }, - }, + spec := map[string]int{ + "namespace1": len(TailscaleVersions) - 5, } - err = scenario.CreateHeadscaleEnv(spec) + err = scenario.CreateHeadscaleEnv(spec, + []tsic.Option{tsic.WithSSH()}, + hsic.WithACLPolicy( + &headscale.ACLPolicy{ + Groups: map[string][]string{ + "group:integration-test": {"namespace1"}, + }, + ACLs: []headscale.ACL{ + { + Action: "accept", + Sources: []string{"*"}, + Destinations: []string{"*:*"}, + }, + }, + SSHs: []headscale.SSH{ + { + Action: "accept", + Sources: []string{"group:integration-test"}, + Destinations: []string{"group:integration-test"}, + Users: []string{"ssh-it-user"}, + }, + }, + }, + ), + ) if err != nil { t.Errorf("failed to create headscale environment: %s", err) } @@ -86,38 +89,9 @@ func TestSSHOneNamespaceAllToAll(t *testing.T) { continue } - clientFQDN, _ := client.FQDN() - peerFQDN, _ := peer.FQDN() - - t.Run( - fmt.Sprintf("%s-%s", clientFQDN, peerFQDN), - func(t *testing.T) { - command := []string{ - "ssh", "-o StrictHostKeyChecking=no", "-o ConnectTimeout=1", - fmt.Sprintf("%s@%s", "ssh-it-user", peer.Hostname()), - "'hostname'", - } - - result, err := retry(10, 1*time.Second, func() (string, error) { - return client.Execute(command) - }) - if err != nil { - t.Errorf("failed to execute command over SSH: %s", err) - } - - if strings.Contains(peer.ID(), result) { - t.Logf( - "failed to get correct container ID from %s, expected: %s, got: %s", - peer.Hostname(), - peer.ID(), - result, - ) - t.Fail() - } else { - success++ - } - }, - ) + if doSSH(t, client, peer) { + success++ + } } } @@ -132,3 +106,135 @@ func TestSSHOneNamespaceAllToAll(t *testing.T) { t.Errorf("failed to tear down scenario: %s", err) } } + +func TestSSHMultipleNamespacesAllToAll(t *testing.T) { + IntegrationSkip(t) + + scenario, err := NewScenario() + if err != nil { + t.Errorf("failed to create scenario: %s", err) + } + + spec := map[string]int{ + "namespace1": len(TailscaleVersions) - 5, + "namespace2": len(TailscaleVersions) - 5, + } + + err = scenario.CreateHeadscaleEnv(spec, + []tsic.Option{tsic.WithSSH()}, + hsic.WithACLPolicy( + &headscale.ACLPolicy{ + Groups: map[string][]string{ + "group:integration-test": {"namespace1", "namespace2"}, + }, + ACLs: []headscale.ACL{ + { + Action: "accept", + Sources: []string{"*"}, + Destinations: []string{"*:*"}, + }, + }, + SSHs: []headscale.SSH{ + { + Action: "accept", + Sources: []string{"group:integration-test"}, + Destinations: []string{"group:integration-test"}, + Users: []string{"ssh-it-user"}, + }, + }, + }, + ), + ) + if err != nil { + t.Errorf("failed to create headscale environment: %s", err) + } + + nsOneClients, err := scenario.ListTailscaleClients("namespace1") + if err != nil { + t.Errorf("failed to get clients: %s", err) + } + + nsTwoClients, err := scenario.ListTailscaleClients("namespace2") + if err != nil { + t.Errorf("failed to get clients: %s", err) + } + + err = scenario.WaitForTailscaleSync() + if err != nil { + t.Errorf("failed wait for tailscale clients to be in sync: %s", err) + } + + _, err = scenario.ListTailscaleClientsFQDNs() + if err != nil { + t.Errorf("failed to get FQDNs: %s", err) + } + + success := 0 + + testInterNamespaceSSH := func(sourceClients []TailscaleClient, targetClients []TailscaleClient) { + for _, client := range sourceClients { + for _, peer := range targetClients { + if doSSH(t, client, peer) { + success++ + } + } + } + } + + testInterNamespaceSSH(nsOneClients, nsTwoClients) + testInterNamespaceSSH(nsTwoClients, nsOneClients) + + t.Logf( + "%d successful pings out of %d", + success, + ((len(nsOneClients)*len(nsOneClients))-len(nsOneClients))*2, + ) + + err = scenario.Shutdown() + if err != nil { + t.Errorf("failed to tear down scenario: %s", err) + } +} + +func doSSH(t *testing.T, client TailscaleClient, peer TailscaleClient) bool { + t.Helper() + + clientFQDN, _ := client.FQDN() + peerFQDN, _ := peer.FQDN() + + success := false + + t.Run( + fmt.Sprintf("%s-%s", clientFQDN, peerFQDN), + func(t *testing.T) { + command := []string{ + "ssh", "-o StrictHostKeyChecking=no", "-o ConnectTimeout=1", + fmt.Sprintf("%s@%s", "ssh-it-user", peerFQDN), + "'hostname'", + } + + result, err := retry(10, 1*time.Second, func() (string, error) { + result, _, err := client.Execute(command) + + return result, err + }) + if err != nil { + t.Errorf("failed to execute command over SSH: %s", err) + } + + if strings.Contains(peer.ID(), result) { + t.Logf( + "failed to get correct container ID from %s, expected: %s, got: %s", + peer.Hostname(), + peer.ID(), + result, + ) + t.Fail() + } else { + success = true + } + }, + ) + + return success +}