Cleanup some unreachable code

This commit is contained in:
Kristoffer Dalby 2022-02-28 23:00:41 +00:00
parent 379017602c
commit 82cb6b9ddc
2 changed files with 1 additions and 24 deletions

View File

@ -718,25 +718,6 @@ func (h *Headscale) RegisterMachine(machine Machine,
Str("machine_key", machine.MachineKey).
Msg("Registering machine")
// If the machine is already in the database, it is seeking
// reauthentication, and by reaching this step, has been authenticated
// and need to have an updated expiry.
var machineKey key.MachinePublic
_ = machineKey.UnmarshalText(
[]byte(MachinePublicKeyEnsurePrefix(machine.MachineKey)),
)
machineFromDatabase, _ := h.GetMachineByMachineKey(machineKey)
if machineFromDatabase != nil {
log.Trace().
Caller().
Str("machine", machine.Name).
Msg("machine already registered, reauthenticating")
h.RefreshMachine(machineFromDatabase, *machine.Expiry)
return machineFromDatabase, nil
}
log.Trace().
Caller().
Str("machine", machine.Name).
@ -758,10 +739,6 @@ func (h *Headscale) RegisterMachine(machine Machine,
machine.IPAddresses = ips
// TODO(kradalby): This field is uneccessary metadata,
// move it to tags instead of having a column.
// machine.RegisterMethod = registrationMethod
h.db.Save(&machine)
log.Trace().

View File

@ -215,7 +215,7 @@ func (h *Headscale) OIDCCallback(ctx *gin.Context) {
return
}
// retrieve machine information
// retrieve machine information if it exist
machine, err := h.GetMachineByMachineKey(machineKey)
if err != nil {
log.Error().Msg("machine key not found in database")