TheArchive/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2024-12-22 07:57:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix most nil pointers, actually make it check for unique across headscale

Browse Source 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit is contained in:
Kristoffer Dalby 2022-10-21 14:42:37 +02:00
parent 830d59fe8c
commit bc1c1f5ce8
No known key found for this signature in database
4 changed files with 33 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
grpcv1.go
View File

@ -479,7 +479,7 @@ func (api headscaleV1APIServer) DebugCreateMachine(
Hostname: "DebugTestMachine", Hostname: "DebugTestMachine",
} }
givenName, err := api.h.GenerateGivenName(namespace.Name, request.GetKey(), request.GetName()) givenName, err := api.h.GenerateGivenName(request.GetKey(), request.GetName())
if err != nil { if err != nil {
return nil, err return nil, err
} }

8
integration/general_test.go
View File

@ -71,8 +71,8 @@ func TestPingAll(t *testing.T) {
t.Logf("%d successful pings out of %d", success, len(allClients)*len(allIps)) t.Logf("%d successful pings out of %d", success, len(allClients)*len(allIps))
err = scenario.Shutdown() // err = scenario.Shutdown()
if err != nil { // if err != nil {
t.Errorf("failed to tear down scenario: %s", err) // t.Errorf("failed to tear down scenario: %s", err)
} // }
} }

21
machine.go
View File

@ -332,6 +332,15 @@ func (h *Headscale) ListMachines() ([]Machine, error) {
return machines, nil return machines, nil
} }
func (h *Headscale) ListMachinesByGivenName(givenName string) ([]Machine, error) {
machines := []Machine{}
if err := h.db.Preload("AuthKey").Preload("AuthKey.Namespace").Preload("Namespace").Find(&machines).Where("given_name = ?", givenName).Error; err != nil {
return nil, err
}
return machines, nil
}
// GetMachine finds a Machine by name and namespace and returns the Machine struct. // GetMachine finds a Machine by name and namespace and returns the Machine struct.
func (h *Headscale) GetMachine(namespace string, name string) (*Machine, error) { func (h *Headscale) GetMachine(namespace string, name string) (*Machine, error) {
machines, err := h.ListMachinesInNamespace(namespace) machines, err := h.ListMachinesInNamespace(namespace)
@ -1061,15 +1070,20 @@ func (h *Headscale) generateGivenName(suppliedName string, randomSuffix bool) (s
return normalizedHostname, nil return normalizedHostname, nil
} }
func (h *Headscale) GenerateGivenName(namespace string, machineKey string, suppliedName string) (string, error) { func (h *Headscale) GenerateGivenName(machineKey string, suppliedName string) (string, error) {
givenName, err := h.generateGivenName(suppliedName, false) givenName, err := h.generateGivenName(suppliedName, false)
if err != nil { if err != nil {
return "", err return "", err
} }
// Tailscale rules (may differ) https://tailscale.com/kb/1098/machine-names/ // Tailscale rules (may differ) https://tailscale.com/kb/1098/machine-names/
machine, _ := h.GetMachineByGivenName(namespace, givenName) machines, err := h.ListMachinesByGivenName(givenName)
if machine != nil && machine.MachineKey != machineKey && machine.GivenName == givenName { if err != nil {
return "", err
}
for _, machine := range machines {
if machine.MachineKey != machineKey && machine.GivenName == givenName {
postfixedName, err := h.generateGivenName(suppliedName, true) postfixedName, err := h.generateGivenName(suppliedName, true)
if err != nil { if err != nil {
return "", err return "", err
@ -1077,6 +1091,7 @@ func (h *Headscale) GenerateGivenName(namespace string, machineKey string, suppl
givenName = postfixedName givenName = postfixedName
} }
}
return givenName, nil return givenName, nil
} }

7
protocol_common.go
View File

@ -150,7 +150,10 @@ func (h *Headscale) handleRegisterCommon(
Bool("noise", machineKey.IsZero()). Bool("noise", machineKey.IsZero()).
Msg("New machine not yet in the database") Msg("New machine not yet in the database")
givenName, err := h.GenerateGivenName(machine.Namespace.Name, machine.MachineKey, registerRequest.Hostinfo.Hostname) givenName, err := h.GenerateGivenName(
machineKey.String(),
registerRequest.Hostinfo.Hostname,
)
if err != nil { if err != nil {
log.Error(). log.Error().
Caller(). Caller().
@ -374,7 +377,7 @@ func (h *Headscale) handleAuthKeyCommon(
} else { } else {
now := time.Now().UTC() now := time.Now().UTC()
givenName, err := h.GenerateGivenName(machine.Namespace.Name, MachinePublicKeyStripPrefix(machineKey), registerRequest.Hostinfo.Hostname) givenName, err := h.GenerateGivenName(MachinePublicKeyStripPrefix(machineKey), registerRequest.Hostinfo.Hostname)
if err != nil { if err != nil {
log.Error(). log.Error().
Caller(). Caller().