integration: replace time.Sleep with assert.EventuallyWithT (#2680)

hscontrol/mapper/mapper.go

@@ -500,7 +500,7 @@ func (m *Mapper) ListPeers(nodeID types.NodeID, peerIDs ...types.NodeID) (types.
 }
 
 // ListNodes queries the database for either all nodes if no parameters are given
-// or for the given nodes if at least one node ID is given as parameter
+// or for the given nodes if at least one node ID is given as parameter.
 func (m *Mapper) ListNodes(nodeIDs ...types.NodeID) (types.Nodes, error) {
 	nodes, err := m.state.ListNodes(nodeIDs...)
 	if err != nil {

hscontrol/mapper/mapper_test.go

@@ -80,7 +80,7 @@ func TestDNSConfigMapResponse(t *testing.T) {
 	}
 }
 
-// mockState is a mock implementation that provides the required methods
+// mockState is a mock implementation that provides the required methods.
 type mockState struct {
 	polMan  policy.PolicyManager
 	derpMap *tailcfg.DERPMap
@@ -133,6 +133,7 @@ func (m *mockState) ListPeers(nodeID types.NodeID, peerIDs ...types.NodeID) (typ
 				}
 			}
 		}
+
 		return filtered, nil
 	}
 	// Return all peers except the node itself
@@ -142,6 +143,7 @@ func (m *mockState) ListPeers(nodeID types.NodeID, peerIDs ...types.NodeID) (typ
 			filtered = append(filtered, peer)
 		}
 	}
+
 	return filtered, nil
 }
 
@@ -157,8 +159,10 @@ func (m *mockState) ListNodes(nodeIDs ...types.NodeID) (types.Nodes, error) {
 				}
 			}
 		}
+
 		return filtered, nil
 	}
+
 	return m.nodes, nil
 }
 

hscontrol/mapper/tail.go

@@ -11,7 +11,7 @@ import (
 	"tailscale.com/types/views"
 )
 
-// NodeCanHaveTagChecker is an interface for checking if a node can have a tag
+// NodeCanHaveTagChecker is an interface for checking if a node can have a tag.
 type NodeCanHaveTagChecker interface {
 	NodeCanHaveTag(node types.NodeView, tag string) bool
 }