Kristoffer Dalby
a6b19e85db
more linter fixups ( #2212 )
...
* linter fixes
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
* conf
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
* update nix hash
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
---------
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
2024-11-22 15:54:58 +00:00
greizgh
74d27ee5fa
Remove deprecated linters from golangci-lint ( #2009 )
...
When running lints, golangci-lint complained about removed
linters (which were already disabled).
This removes the relevant warnings.
2024-07-17 10:08:41 +02:00
Kristoffer Dalby
b7c6e0ec88
add annoying linter to golangci
...
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
2023-09-19 10:20:21 -05:00
Kristoffer Dalby
1766e6b5df
General fixups discovered by checking errors
...
There was a lot of tests that actually threw a lot of errors and that did
not pass all the way because we didnt check everything. This commit should
fix all of these cases.
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
2023-09-05 08:47:43 +02:00
Juan Font
50b706eeed
Remove deprecated linters + one casuing issues with imports
2023-04-04 22:37:27 +02:00
Juan Font Alonso
f5a5437917
disable interfacebloat linter
2022-11-13 18:30:00 +01:00
Juan Font Alonso
d038df2a88
Added ts2019 buildtag to CI config
...
Otherwise we are getting utils.go:119:6: `decode` is unused (deadcode)
Signed-off-by: Juan Font Alonso <juanfontalonso@gmail.com>
2022-11-13 15:42:54 +01:00
LiuHanCheng
07f92e647c
fix bug in #912 ( #914 )
2022-11-05 09:07:22 +01:00
Adrien Raffin-Caboisse
c4e69fe2c3
fix: ignore exhaust linter
2022-05-16 15:13:16 +02:00
Adrien Raffin-Caboisse
844ad15109
fix: revert previous commit and add exclusion of linter
2022-05-16 14:29:05 +02:00
Adrien Raffin-Caboisse
522e892099
fix: remove unknown linters:
...
When running in CI, I obtained the following error:
```
Running [/home/runner/golangci-lint-1.41.0-linux-amd64/golangci-lint run --out-format=github-actions --new-from-patch=/tmp/tmp-1795-28vaWZek2jfM/pull.patch --new=false --new-from-rev=] in [] ...
level=error msg="Running error: unknown linters: 'ireturn,maintidx', run 'golangci-lint linters' to see the list of supported linters"
```
2022-05-16 14:17:31 +02:00
Kristoffer Dalby
50053e616a
Ignore complexity linter
2022-02-28 16:35:08 +00:00
Adrien Raffin-Caboisse
211fe4034a
chore(linter): ignore tt var as it's generated code (vscode)
2022-02-21 16:10:20 +01:00
Kristoffer Dalby
9968992be0
Fix prettier
2021-11-24 10:47:20 +00:00
Kristoffer Dalby
2eca344f0e
Fix gocritic
2021-11-24 10:13:41 +00:00
Kristoffer Dalby
d6739386a0
Get rid of dynamic errors
2021-11-15 19:18:14 +00:00
Kristoffer Dalby
25b790d025
Add and fix forcetypeassert
2021-11-15 18:42:44 +00:00
Kristoffer Dalby
db8be91d8b
Add and fix forbidigo
2021-11-15 18:36:02 +00:00
Kristoffer Dalby
c4d4c9c4e4
Add and fix gosec
2021-11-15 18:31:52 +00:00
Kristoffer Dalby
715542ac1c
Add and fix stylecheck (golint replacement)
2021-11-15 17:24:24 +00:00
Kristoffer Dalby
0c005a6b01
Add and fix errname
2021-11-15 16:33:16 +00:00
Kristoffer Dalby
0c45f8d252
Add and fix errorlint
2021-11-15 16:26:41 +00:00
Kristoffer Dalby
78cfba0a31
Add exceptions to var name length
2021-11-15 16:16:16 +00:00
Kristoffer Dalby
471c0b4993
Initial work eliminating one/two letter variables
2021-11-14 20:32:03 +01:00
Kristoffer Dalby
53ed749f45
Start work on making gocritic pass
2021-11-14 18:44:37 +01:00
Kristoffer Dalby
85f28a3f4a
Remove all instances of undefined numbers (gonmd)
2021-11-14 18:31:51 +01:00
Kristoffer Dalby
796072a5a4
Add and fix ifshort
2021-11-14 18:09:22 +01:00
Kristoffer Dalby
9390348a65
Add and fix goconst
2021-11-14 18:06:25 +01:00
Kristoffer Dalby
c9c16c7fb8
Remove unused params or returns
2021-11-14 18:03:21 +01:00
Kristoffer Dalby
19cd7a4eac
Add and fix exhaustive
2021-11-14 17:52:55 +01:00
Kristoffer Dalby
0315f55fcd
Add and fix nilnil
2021-11-14 17:51:34 +01:00
Kristoffer Dalby
668e958d3e
Add and fix unconvert
2021-11-14 17:49:54 +01:00
Kristoffer Dalby
4ace54c4e1
Move wsl, might not be feasible
2021-11-14 16:49:54 +01:00
Kristoffer Dalby
89eb13c6cb
Add and fix nlreturn (new line return)
2021-11-14 16:46:09 +01:00
Kristoffer Dalby
d0ef850035
Add and fix noctx linter
2021-11-14 16:37:43 +01:00
Kristoffer Dalby
24e0c944b1
Align with update golangci-lint
2021-11-13 09:11:03 +00:00
Kristoffer Dalby
148437f716
Setup more linters and goals for golangci
2021-11-13 08:53:34 +00:00
Kristoffer Dalby
e91174e83f
Add gen explicitly to skip list
2021-10-27 07:08:24 +00:00
Kristoffer Dalby
f779372154
Add golangcilint config
2021-10-27 07:07:19 +00:00
