mirror of
https://github.com/juanfont/headscale.git
synced 2024-11-25 11:05:29 +00:00
218138afee
expand user, add claims to user This commit expands the user table with additional fields that can be retrieved from OIDC providers (and other places) and uses this data in various tailscale response objects if it is available. This is the beginning of implementing https://docs.google.com/document/d/1X85PMxIaVWDF6T_UPji3OeeUqVBcGj_uHRM5CI-AwlY/edit trying to make OIDC more coherant and maintainable in addition to giving the user a better experience and integration with a provider. remove usernames in magic dns, normalisation of emails this commit removes the option to have usernames as part of MagicDNS domains and headscale will now align with Tailscale, where there is a root domain, and the machine name. In addition, the various normalisation functions for dns names has been made lighter not caring about username and special character that wont occur. Email are no longer normalised as part of the policy processing. untagle oidc and regcache, use typed cache This commits stops reusing the registration cache for oidc purposes and switches the cache to be types and not use any allowing the removal of a bunch of casting. try to make reauth/register branches clearer in oidc Currently there was a function that did a bunch of stuff, finding the machine key, trying to find the node, reauthing the node, returning some status, and it was called validate which was very confusing. This commit tries to split this into what to do if the node exists, if it needs to register etc. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
1239 lines
26 KiB
Go
1239 lines
26 KiB
Go
package db
|
|
|
|
import (
|
|
"net/netip"
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/google/go-cmp/cmp/cmpopts"
|
|
"github.com/juanfont/headscale/hscontrol/types"
|
|
"github.com/juanfont/headscale/hscontrol/util"
|
|
"github.com/puzpuzpuz/xsync/v3"
|
|
"gopkg.in/check.v1"
|
|
"gorm.io/gorm"
|
|
"tailscale.com/tailcfg"
|
|
"tailscale.com/types/ptr"
|
|
)
|
|
|
|
var smap = func(m map[types.NodeID]bool) *xsync.MapOf[types.NodeID, bool] {
|
|
s := xsync.NewMapOf[types.NodeID, bool]()
|
|
|
|
for k, v := range m {
|
|
s.Store(k, v)
|
|
}
|
|
|
|
return s
|
|
}
|
|
|
|
var mp = func(p string) netip.Prefix {
|
|
return netip.MustParsePrefix(p)
|
|
}
|
|
|
|
func (s *Suite) TestGetRoutes(c *check.C) {
|
|
user, err := db.CreateUser("test")
|
|
c.Assert(err, check.IsNil)
|
|
|
|
pak, err := db.CreatePreAuthKey(user.Name, false, false, nil, nil)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
_, err = db.getNode("test", "test_get_route_node")
|
|
c.Assert(err, check.NotNil)
|
|
|
|
route, err := netip.ParsePrefix("10.0.0.0/24")
|
|
c.Assert(err, check.IsNil)
|
|
|
|
hostInfo := tailcfg.Hostinfo{
|
|
RoutableIPs: []netip.Prefix{route},
|
|
}
|
|
|
|
node := types.Node{
|
|
ID: 0,
|
|
Hostname: "test_get_route_node",
|
|
UserID: user.ID,
|
|
RegisterMethod: util.RegisterMethodAuthKey,
|
|
AuthKeyID: ptr.To(pak.ID),
|
|
Hostinfo: &hostInfo,
|
|
}
|
|
trx := db.DB.Save(&node)
|
|
c.Assert(trx.Error, check.IsNil)
|
|
|
|
su, err := db.SaveNodeRoutes(&node)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(su, check.Equals, false)
|
|
|
|
advertisedRoutes, err := db.GetAdvertisedRoutes(&node)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(advertisedRoutes), check.Equals, 1)
|
|
|
|
// TODO(kradalby): check state update
|
|
_, err = db.enableRoutes(&node, mp("192.168.0.0/24"))
|
|
c.Assert(err, check.NotNil)
|
|
|
|
_, err = db.enableRoutes(&node, mp("10.0.0.0/24"))
|
|
c.Assert(err, check.IsNil)
|
|
}
|
|
|
|
func (s *Suite) TestGetEnableRoutes(c *check.C) {
|
|
user, err := db.CreateUser("test")
|
|
c.Assert(err, check.IsNil)
|
|
|
|
pak, err := db.CreatePreAuthKey(user.Name, false, false, nil, nil)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
_, err = db.getNode("test", "test_enable_route_node")
|
|
c.Assert(err, check.NotNil)
|
|
|
|
route, err := netip.ParsePrefix(
|
|
"10.0.0.0/24",
|
|
)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
route2, err := netip.ParsePrefix(
|
|
"150.0.10.0/25",
|
|
)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
hostInfo := tailcfg.Hostinfo{
|
|
RoutableIPs: []netip.Prefix{route, route2},
|
|
}
|
|
|
|
node := types.Node{
|
|
ID: 0,
|
|
Hostname: "test_enable_route_node",
|
|
UserID: user.ID,
|
|
RegisterMethod: util.RegisterMethodAuthKey,
|
|
AuthKeyID: ptr.To(pak.ID),
|
|
Hostinfo: &hostInfo,
|
|
}
|
|
trx := db.DB.Save(&node)
|
|
c.Assert(trx.Error, check.IsNil)
|
|
|
|
sendUpdate, err := db.SaveNodeRoutes(&node)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(sendUpdate, check.Equals, false)
|
|
|
|
availableRoutes, err := db.GetAdvertisedRoutes(&node)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(availableRoutes), check.Equals, 2)
|
|
|
|
noEnabledRoutes, err := db.GetEnabledRoutes(&node)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(noEnabledRoutes), check.Equals, 0)
|
|
|
|
_, err = db.enableRoutes(&node, mp("192.168.0.0/24"))
|
|
c.Assert(err, check.NotNil)
|
|
|
|
_, err = db.enableRoutes(&node, mp("10.0.0.0/24"))
|
|
c.Assert(err, check.IsNil)
|
|
|
|
enabledRoutes, err := db.GetEnabledRoutes(&node)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(enabledRoutes), check.Equals, 1)
|
|
|
|
// Adding it twice will just let it pass through
|
|
_, err = db.enableRoutes(&node, mp("10.0.0.0/24"))
|
|
c.Assert(err, check.IsNil)
|
|
|
|
enableRoutesAfterDoubleApply, err := db.GetEnabledRoutes(&node)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(enableRoutesAfterDoubleApply), check.Equals, 1)
|
|
|
|
_, err = db.enableRoutes(&node, mp("150.0.10.0/25"))
|
|
c.Assert(err, check.IsNil)
|
|
|
|
enabledRoutesWithAdditionalRoute, err := db.GetEnabledRoutes(&node)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(enabledRoutesWithAdditionalRoute), check.Equals, 2)
|
|
}
|
|
|
|
func (s *Suite) TestIsUniquePrefix(c *check.C) {
|
|
user, err := db.CreateUser("test")
|
|
c.Assert(err, check.IsNil)
|
|
|
|
pak, err := db.CreatePreAuthKey(user.Name, false, false, nil, nil)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
_, err = db.getNode("test", "test_enable_route_node")
|
|
c.Assert(err, check.NotNil)
|
|
|
|
route, err := netip.ParsePrefix(
|
|
"10.0.0.0/24",
|
|
)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
route2, err := netip.ParsePrefix(
|
|
"150.0.10.0/25",
|
|
)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
hostInfo1 := tailcfg.Hostinfo{
|
|
RoutableIPs: []netip.Prefix{route, route2},
|
|
}
|
|
node1 := types.Node{
|
|
ID: 1,
|
|
Hostname: "test_enable_route_node",
|
|
UserID: user.ID,
|
|
RegisterMethod: util.RegisterMethodAuthKey,
|
|
AuthKeyID: ptr.To(pak.ID),
|
|
Hostinfo: &hostInfo1,
|
|
}
|
|
trx := db.DB.Save(&node1)
|
|
c.Assert(trx.Error, check.IsNil)
|
|
|
|
sendUpdate, err := db.SaveNodeRoutes(&node1)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(sendUpdate, check.Equals, false)
|
|
|
|
_, err = db.enableRoutes(&node1, route)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
_, err = db.enableRoutes(&node1, route2)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
hostInfo2 := tailcfg.Hostinfo{
|
|
RoutableIPs: []netip.Prefix{route2},
|
|
}
|
|
node2 := types.Node{
|
|
ID: 2,
|
|
Hostname: "test_enable_route_node",
|
|
UserID: user.ID,
|
|
RegisterMethod: util.RegisterMethodAuthKey,
|
|
AuthKeyID: ptr.To(pak.ID),
|
|
Hostinfo: &hostInfo2,
|
|
}
|
|
db.DB.Save(&node2)
|
|
|
|
sendUpdate, err = db.SaveNodeRoutes(&node2)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(sendUpdate, check.Equals, false)
|
|
|
|
_, err = db.enableRoutes(&node2, route2)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
enabledRoutes1, err := db.GetEnabledRoutes(&node1)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(enabledRoutes1), check.Equals, 2)
|
|
|
|
enabledRoutes2, err := db.GetEnabledRoutes(&node2)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(enabledRoutes2), check.Equals, 1)
|
|
|
|
routes, err := db.GetNodePrimaryRoutes(&node1)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(routes), check.Equals, 2)
|
|
|
|
routes, err = db.GetNodePrimaryRoutes(&node2)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(routes), check.Equals, 0)
|
|
}
|
|
|
|
func (s *Suite) TestDeleteRoutes(c *check.C) {
|
|
user, err := db.CreateUser("test")
|
|
c.Assert(err, check.IsNil)
|
|
|
|
pak, err := db.CreatePreAuthKey(user.Name, false, false, nil, nil)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
_, err = db.getNode("test", "test_enable_route_node")
|
|
c.Assert(err, check.NotNil)
|
|
|
|
prefix, err := netip.ParsePrefix(
|
|
"10.0.0.0/24",
|
|
)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
prefix2, err := netip.ParsePrefix(
|
|
"150.0.10.0/25",
|
|
)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
hostInfo1 := tailcfg.Hostinfo{
|
|
RoutableIPs: []netip.Prefix{prefix, prefix2},
|
|
}
|
|
|
|
now := time.Now()
|
|
node1 := types.Node{
|
|
ID: 1,
|
|
Hostname: "test_enable_route_node",
|
|
UserID: user.ID,
|
|
RegisterMethod: util.RegisterMethodAuthKey,
|
|
AuthKeyID: ptr.To(pak.ID),
|
|
Hostinfo: &hostInfo1,
|
|
LastSeen: &now,
|
|
}
|
|
trx := db.DB.Save(&node1)
|
|
c.Assert(trx.Error, check.IsNil)
|
|
|
|
sendUpdate, err := db.SaveNodeRoutes(&node1)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(sendUpdate, check.Equals, false)
|
|
|
|
_, err = db.enableRoutes(&node1, prefix)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
_, err = db.enableRoutes(&node1, prefix2)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
routes, err := db.GetNodeRoutes(&node1)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
// TODO(kradalby): check stateupdate
|
|
_, err = db.DeleteRoute(uint64(routes[0].ID), nil)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
enabledRoutes1, err := db.GetEnabledRoutes(&node1)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(len(enabledRoutes1), check.Equals, 1)
|
|
}
|
|
|
|
var (
|
|
ipp = func(s string) netip.Prefix { return netip.MustParsePrefix(s) }
|
|
mkNode = func(nid types.NodeID) types.Node {
|
|
return types.Node{ID: nid}
|
|
}
|
|
)
|
|
|
|
var np = func(nid types.NodeID) *types.Node {
|
|
no := mkNode(nid)
|
|
return &no
|
|
}
|
|
|
|
var r = func(id uint, nid types.NodeID, prefix netip.Prefix, enabled, primary bool) types.Route {
|
|
return types.Route{
|
|
Model: gorm.Model{
|
|
ID: id,
|
|
},
|
|
Node: mkNode(nid),
|
|
Prefix: prefix,
|
|
Enabled: enabled,
|
|
IsPrimary: primary,
|
|
}
|
|
}
|
|
|
|
var rp = func(id uint, nid types.NodeID, prefix netip.Prefix, enabled, primary bool) *types.Route {
|
|
ro := r(id, nid, prefix, enabled, primary)
|
|
return &ro
|
|
}
|
|
|
|
func dbForTest(t *testing.T, testName string) *HSDatabase {
|
|
t.Helper()
|
|
|
|
tmpDir, err := os.MkdirTemp("", testName)
|
|
if err != nil {
|
|
t.Fatalf("creating tempdir: %s", err)
|
|
}
|
|
|
|
dbPath := tmpDir + "/headscale_test.db"
|
|
|
|
db, err = NewHeadscaleDatabase(
|
|
types.DatabaseConfig{
|
|
Type: "sqlite3",
|
|
Sqlite: types.SqliteConfig{
|
|
Path: dbPath,
|
|
},
|
|
},
|
|
"",
|
|
emptyCache(),
|
|
)
|
|
if err != nil {
|
|
t.Fatalf("setting up database: %s", err)
|
|
}
|
|
|
|
t.Logf("database set up at: %s", dbPath)
|
|
|
|
return db
|
|
}
|
|
|
|
func TestFailoverNodeRoutesIfNeccessary(t *testing.T) {
|
|
su := func(nids ...types.NodeID) *types.StateUpdate {
|
|
return &types.StateUpdate{
|
|
ChangeNodes: nids,
|
|
}
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
nodes types.Nodes
|
|
routes types.Routes
|
|
isConnected []map[types.NodeID]bool
|
|
want []*types.StateUpdate
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "n1-down-n2-down-n1-up",
|
|
nodes: types.Nodes{
|
|
np(1),
|
|
np(2),
|
|
np(1),
|
|
},
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, false),
|
|
},
|
|
isConnected: []map[types.NodeID]bool{
|
|
// n1 goes down
|
|
{
|
|
1: false,
|
|
2: true,
|
|
},
|
|
// n2 goes down
|
|
{
|
|
1: false,
|
|
2: false,
|
|
},
|
|
// n1 comes up
|
|
{
|
|
1: true,
|
|
2: false,
|
|
},
|
|
},
|
|
want: []*types.StateUpdate{
|
|
// route changes from 1 -> 2
|
|
su(1, 2),
|
|
// both down, no change
|
|
nil,
|
|
// route changes from 2 -> 1
|
|
su(1, 2),
|
|
},
|
|
},
|
|
{
|
|
name: "n1-recon-n2-down-n1-recon-n2-up",
|
|
nodes: types.Nodes{
|
|
np(1),
|
|
np(2),
|
|
np(1),
|
|
np(2),
|
|
},
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, false),
|
|
},
|
|
isConnected: []map[types.NodeID]bool{
|
|
// n1 up recon = noop
|
|
{
|
|
1: true,
|
|
2: true,
|
|
},
|
|
// n2 goes down
|
|
{
|
|
1: true,
|
|
2: false,
|
|
},
|
|
// n1 up recon = noop
|
|
{
|
|
1: true,
|
|
2: false,
|
|
},
|
|
// n2 comes back up
|
|
{
|
|
1: true,
|
|
2: false,
|
|
},
|
|
},
|
|
want: []*types.StateUpdate{
|
|
nil,
|
|
nil,
|
|
nil,
|
|
nil,
|
|
},
|
|
},
|
|
{
|
|
name: "n1-recon-n2-down-n1-recon-n2-up",
|
|
nodes: types.Nodes{
|
|
np(1),
|
|
np(1),
|
|
np(3),
|
|
np(3),
|
|
np(2),
|
|
np(1),
|
|
},
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, false),
|
|
r(3, 3, ipp("10.0.0.0/24"), true, false),
|
|
},
|
|
isConnected: []map[types.NodeID]bool{
|
|
// n1 goes down
|
|
{
|
|
1: false,
|
|
2: false,
|
|
3: true,
|
|
},
|
|
// n1 comes up
|
|
{
|
|
1: true,
|
|
2: false,
|
|
3: true,
|
|
},
|
|
// n3 goes down
|
|
{
|
|
1: true,
|
|
2: false,
|
|
3: false,
|
|
},
|
|
// n3 comes up
|
|
{
|
|
1: true,
|
|
2: false,
|
|
3: true,
|
|
},
|
|
// n2 comes up
|
|
{
|
|
1: true,
|
|
2: true,
|
|
3: true,
|
|
},
|
|
// n1 goes down
|
|
{
|
|
1: false,
|
|
2: true,
|
|
3: true,
|
|
},
|
|
},
|
|
want: []*types.StateUpdate{
|
|
su(1, 3), // n1 -> n3
|
|
nil,
|
|
su(1, 3), // n3 -> n1
|
|
nil,
|
|
nil,
|
|
su(1, 2), // n1 -> n2
|
|
},
|
|
},
|
|
{
|
|
name: "n1-recon-n2-dis-n3-take",
|
|
nodes: types.Nodes{
|
|
np(1),
|
|
np(3),
|
|
},
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), false, false),
|
|
r(3, 3, ipp("10.0.0.0/24"), true, false),
|
|
},
|
|
isConnected: []map[types.NodeID]bool{
|
|
// n1 goes down
|
|
{
|
|
1: false,
|
|
2: true,
|
|
3: true,
|
|
},
|
|
// n3 goes down
|
|
{
|
|
1: false,
|
|
2: true,
|
|
3: false,
|
|
},
|
|
},
|
|
want: []*types.StateUpdate{
|
|
su(1, 3), // n1 -> n3
|
|
nil,
|
|
},
|
|
},
|
|
{
|
|
name: "multi-n1-oneforeach-n2-n3",
|
|
nodes: types.Nodes{
|
|
np(1),
|
|
},
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(4, 1, ipp("10.1.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, false),
|
|
r(3, 3, ipp("10.1.0.0/24"), true, false),
|
|
},
|
|
isConnected: []map[types.NodeID]bool{
|
|
// n1 goes down
|
|
{
|
|
1: false,
|
|
2: true,
|
|
3: true,
|
|
},
|
|
},
|
|
want: []*types.StateUpdate{
|
|
su(1, 2, 3), // n1 -> n2,n3
|
|
},
|
|
},
|
|
{
|
|
name: "multi-n1-onefor-n2-disabled-n3",
|
|
nodes: types.Nodes{
|
|
np(1),
|
|
},
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(4, 1, ipp("10.1.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, false),
|
|
r(3, 3, ipp("10.1.0.0/24"), false, false),
|
|
},
|
|
isConnected: []map[types.NodeID]bool{
|
|
// n1 goes down
|
|
{
|
|
1: false,
|
|
2: true,
|
|
3: true,
|
|
},
|
|
},
|
|
want: []*types.StateUpdate{
|
|
su(1, 2), // n1 -> n2, n3 is not enabled
|
|
},
|
|
},
|
|
{
|
|
name: "multi-n1-onefor-n2-offline-n3",
|
|
nodes: types.Nodes{
|
|
np(1),
|
|
},
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(4, 1, ipp("10.1.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, false),
|
|
r(3, 3, ipp("10.1.0.0/24"), true, false),
|
|
},
|
|
isConnected: []map[types.NodeID]bool{
|
|
// n1 goes down
|
|
{
|
|
1: false,
|
|
2: true,
|
|
3: false,
|
|
},
|
|
},
|
|
want: []*types.StateUpdate{
|
|
su(1, 2), // n1 -> n2, n3 is offline
|
|
},
|
|
},
|
|
{
|
|
name: "multi-n2-back-to-multi-n1",
|
|
nodes: types.Nodes{
|
|
np(1),
|
|
},
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, false),
|
|
r(4, 1, ipp("10.1.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, true),
|
|
r(3, 3, ipp("10.1.0.0/24"), true, false),
|
|
},
|
|
isConnected: []map[types.NodeID]bool{
|
|
// n1 goes down
|
|
{
|
|
1: true,
|
|
2: false,
|
|
3: true,
|
|
},
|
|
},
|
|
want: []*types.StateUpdate{
|
|
su(1, 2), // n2 -> n1
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if (len(tt.isConnected) != len(tt.want)) && len(tt.want) != len(tt.nodes) {
|
|
t.Fatalf("nodes (%d), isConnected updates (%d), wants (%d) must be equal", len(tt.nodes), len(tt.isConnected), len(tt.want))
|
|
}
|
|
|
|
db := dbForTest(t, tt.name)
|
|
|
|
user := types.User{Name: tt.name}
|
|
if err := db.DB.Save(&user).Error; err != nil {
|
|
t.Fatalf("failed to create user: %s", err)
|
|
}
|
|
|
|
for _, route := range tt.routes {
|
|
route.Node.User = user
|
|
if err := db.DB.Save(&route.Node).Error; err != nil {
|
|
t.Fatalf("failed to create node: %s", err)
|
|
}
|
|
if err := db.DB.Save(&route).Error; err != nil {
|
|
t.Fatalf("failed to create route: %s", err)
|
|
}
|
|
}
|
|
|
|
for step := range len(tt.isConnected) {
|
|
node := tt.nodes[step]
|
|
isConnected := tt.isConnected[step]
|
|
want := tt.want[step]
|
|
|
|
got, err := Write(db.DB, func(tx *gorm.DB) (*types.StateUpdate, error) {
|
|
return FailoverNodeRoutesIfNeccessary(tx, smap(isConnected), node)
|
|
})
|
|
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("failoverRoute() error = %v, wantErr %v", err, tt.wantErr)
|
|
|
|
return
|
|
}
|
|
|
|
if diff := cmp.Diff(want, got, cmpopts.IgnoreFields(types.StateUpdate{}, "Type", "Message")); diff != "" {
|
|
t.Errorf("failoverRoute() unexpected result (-want +got):\n%s", diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFailoverRouteTx(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
failingRoute types.Route
|
|
routes types.Routes
|
|
isConnected map[types.NodeID]bool
|
|
want []types.NodeID
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "no-route",
|
|
failingRoute: types.Route{},
|
|
routes: types.Routes{},
|
|
want: nil,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "no-prime",
|
|
failingRoute: types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{},
|
|
IsPrimary: false,
|
|
},
|
|
routes: types.Routes{},
|
|
want: nil,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "exit-node",
|
|
failingRoute: types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("0.0.0.0/0"),
|
|
Node: types.Node{},
|
|
IsPrimary: true,
|
|
},
|
|
routes: types.Routes{},
|
|
want: nil,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "no-failover-single-route",
|
|
failingRoute: types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
},
|
|
routes: types.Routes{
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
},
|
|
},
|
|
want: nil,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "failover-primary",
|
|
failingRoute: types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
routes: types.Routes{
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 2,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 2,
|
|
},
|
|
IsPrimary: false,
|
|
Enabled: true,
|
|
},
|
|
},
|
|
isConnected: map[types.NodeID]bool{
|
|
1: false,
|
|
2: true,
|
|
},
|
|
want: []types.NodeID{
|
|
1,
|
|
2,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "failover-none-primary",
|
|
failingRoute: types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: false,
|
|
Enabled: true,
|
|
},
|
|
routes: types.Routes{
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 2,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 2,
|
|
},
|
|
IsPrimary: false,
|
|
Enabled: true,
|
|
},
|
|
},
|
|
want: nil,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "failover-primary-multi-route",
|
|
failingRoute: types.Route{
|
|
Model: gorm.Model{
|
|
ID: 2,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 2,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
routes: types.Routes{
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: false,
|
|
Enabled: true,
|
|
},
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 2,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 2,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 3,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 3,
|
|
},
|
|
IsPrimary: false,
|
|
Enabled: true,
|
|
},
|
|
},
|
|
isConnected: map[types.NodeID]bool{
|
|
1: true,
|
|
2: true,
|
|
3: true,
|
|
},
|
|
want: []types.NodeID{
|
|
2, 1,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "failover-primary-no-online",
|
|
failingRoute: types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
routes: types.Routes{
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
// Offline
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 2,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 4,
|
|
},
|
|
IsPrimary: false,
|
|
Enabled: true,
|
|
},
|
|
},
|
|
isConnected: map[types.NodeID]bool{
|
|
1: true,
|
|
4: false,
|
|
},
|
|
want: nil,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "failover-primary-one-not-online",
|
|
failingRoute: types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
routes: types.Routes{
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
// Offline
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 2,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 4,
|
|
},
|
|
IsPrimary: false,
|
|
Enabled: true,
|
|
},
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 3,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 2,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
},
|
|
isConnected: map[types.NodeID]bool{
|
|
1: false,
|
|
2: true,
|
|
4: false,
|
|
},
|
|
want: []types.NodeID{
|
|
1,
|
|
2,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "failover-primary-none-enabled",
|
|
failingRoute: types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
routes: types.Routes{
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 1,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 1,
|
|
},
|
|
IsPrimary: true,
|
|
Enabled: true,
|
|
},
|
|
// not enabled
|
|
types.Route{
|
|
Model: gorm.Model{
|
|
ID: 2,
|
|
},
|
|
Prefix: ipp("10.0.0.0/24"),
|
|
Node: types.Node{
|
|
ID: 2,
|
|
},
|
|
IsPrimary: false,
|
|
Enabled: false,
|
|
},
|
|
},
|
|
want: nil,
|
|
wantErr: false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db := dbForTest(t, tt.name)
|
|
user := types.User{Name: "test"}
|
|
if err := db.DB.Save(&user).Error; err != nil {
|
|
t.Fatalf("failed to create user: %s", err)
|
|
}
|
|
|
|
for _, route := range tt.routes {
|
|
route.Node.User = user
|
|
if err := db.DB.Save(&route.Node).Error; err != nil {
|
|
t.Fatalf("failed to create node: %s", err)
|
|
}
|
|
if err := db.DB.Save(&route).Error; err != nil {
|
|
t.Fatalf("failed to create route: %s", err)
|
|
}
|
|
}
|
|
|
|
got, err := Write(db.DB, func(tx *gorm.DB) ([]types.NodeID, error) {
|
|
return failoverRouteTx(tx, smap(tt.isConnected), &tt.failingRoute)
|
|
})
|
|
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("failoverRoute() error = %v, wantErr %v", err, tt.wantErr)
|
|
|
|
return
|
|
}
|
|
|
|
if diff := cmp.Diff(tt.want, got, util.Comparers...); diff != "" {
|
|
t.Errorf("failoverRoute() unexpected result (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFailoverRoute(t *testing.T) {
|
|
r := func(id uint, nid types.NodeID, prefix netip.Prefix, enabled, primary bool) types.Route {
|
|
return types.Route{
|
|
Model: gorm.Model{
|
|
ID: id,
|
|
},
|
|
Node: types.Node{
|
|
ID: nid,
|
|
},
|
|
Prefix: prefix,
|
|
Enabled: enabled,
|
|
IsPrimary: primary,
|
|
}
|
|
}
|
|
rp := func(id uint, nid types.NodeID, prefix netip.Prefix, enabled, primary bool) *types.Route {
|
|
ro := r(id, nid, prefix, enabled, primary)
|
|
return &ro
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
failingRoute types.Route
|
|
routes types.Routes
|
|
isConnected map[types.NodeID]bool
|
|
want *failover
|
|
}{
|
|
{
|
|
name: "no-route",
|
|
failingRoute: types.Route{},
|
|
routes: types.Routes{},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "no-prime",
|
|
failingRoute: r(1, 1, ipp("10.0.0.0/24"), false, false),
|
|
|
|
routes: types.Routes{},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "exit-node",
|
|
failingRoute: r(1, 1, ipp("0.0.0.0/0"), false, true),
|
|
routes: types.Routes{},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "no-failover-single-route",
|
|
failingRoute: r(1, 1, ipp("10.0.0.0/24"), false, true),
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), false, true),
|
|
},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "failover-primary",
|
|
failingRoute: r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, false),
|
|
},
|
|
isConnected: map[types.NodeID]bool{
|
|
1: false,
|
|
2: true,
|
|
},
|
|
want: &failover{
|
|
old: rp(1, 1, ipp("10.0.0.0/24"), true, false),
|
|
new: rp(2, 2, ipp("10.0.0.0/24"), true, true),
|
|
},
|
|
},
|
|
{
|
|
name: "failover-none-primary",
|
|
failingRoute: r(1, 1, ipp("10.0.0.0/24"), true, false),
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, false),
|
|
},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "failover-primary-multi-route",
|
|
failingRoute: r(2, 2, ipp("10.0.0.0/24"), true, true),
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, false),
|
|
r(2, 2, ipp("10.0.0.0/24"), true, true),
|
|
r(3, 3, ipp("10.0.0.0/24"), true, false),
|
|
},
|
|
isConnected: map[types.NodeID]bool{
|
|
1: true,
|
|
2: true,
|
|
3: true,
|
|
},
|
|
want: &failover{
|
|
old: rp(2, 2, ipp("10.0.0.0/24"), true, false),
|
|
new: rp(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
},
|
|
},
|
|
{
|
|
name: "failover-primary-no-online",
|
|
failingRoute: r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(2, 4, ipp("10.0.0.0/24"), true, false),
|
|
},
|
|
isConnected: map[types.NodeID]bool{
|
|
1: true,
|
|
4: false,
|
|
},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "failover-primary-one-not-online",
|
|
failingRoute: r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
r(2, 4, ipp("10.0.0.0/24"), true, false),
|
|
r(3, 2, ipp("10.0.0.0/24"), true, false),
|
|
},
|
|
isConnected: map[types.NodeID]bool{
|
|
1: false,
|
|
2: true,
|
|
4: false,
|
|
},
|
|
want: &failover{
|
|
old: rp(1, 1, ipp("10.0.0.0/24"), true, false),
|
|
new: rp(3, 2, ipp("10.0.0.0/24"), true, true),
|
|
},
|
|
},
|
|
{
|
|
name: "failover-primary-none-enabled",
|
|
failingRoute: r(1, 1, ipp("10.0.0.0/24"), true, true),
|
|
routes: types.Routes{
|
|
r(1, 1, ipp("10.0.0.0/24"), true, false),
|
|
r(2, 2, ipp("10.0.0.0/24"), false, true),
|
|
},
|
|
want: nil,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
gotf := failoverRoute(smap(tt.isConnected), &tt.failingRoute, tt.routes)
|
|
|
|
if tt.want == nil && gotf != nil {
|
|
t.Fatalf("expected nil, got %+v", gotf)
|
|
}
|
|
|
|
if gotf == nil && tt.want != nil {
|
|
t.Fatalf("expected %+v, got nil", tt.want)
|
|
}
|
|
|
|
if tt.want != nil && gotf != nil {
|
|
want := map[string]*types.Route{
|
|
"new": tt.want.new,
|
|
"old": tt.want.old,
|
|
}
|
|
|
|
got := map[string]*types.Route{
|
|
"new": gotf.new,
|
|
"old": gotf.old,
|
|
}
|
|
|
|
if diff := cmp.Diff(want, got, util.Comparers...); diff != "" {
|
|
t.Fatalf("failoverRoute unexpected result (-want +got):\n%s", diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|