From 3dcfa4f8c1e3a23bd31f1f3572f11782e90e87e7 Mon Sep 17 00:00:00 2001
From: gullradriel <3157857+gullradriel@users.noreply.github.com>
Date: Mon, 25 Nov 2024 09:01:16 +0100
Subject: [PATCH] use full_reset_and_init return value in init and
 reset_learned (#2393)

* use full_reset_and_init return value in init and reset_learned

* do not uncomment status clear

---------

Co-authored-by: gullradriel <gullradriel@no-mail.com>
---
 firmware/common/i2cdev_max17055.cpp | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/firmware/common/i2cdev_max17055.cpp b/firmware/common/i2cdev_max17055.cpp
index 41b6eba4..7e6ea605 100644
--- a/firmware/common/i2cdev_max17055.cpp
+++ b/firmware/common/i2cdev_max17055.cpp
@@ -202,16 +202,14 @@ bool I2cDev_MAX17055::init(uint8_t addr_) {
     model = I2CDEVMDL_MAX17055;
     query_interval = BATTERY_WIDGET_REFRESH_INTERVAL;
     if (detect()) {
+        bool return_status = true;
         if (needsInitialization()) {
             // First-time or POR initialization
-            full_reset_and_init();
-        } else {
-            // Subsequent boot
-            partialInit();
+            return_status = full_reset_and_init();
         }
-        partialInit();
-        // statusClear(); I am not sure if this should be here or not
-        return true;
+        partialInit();  // If you always want hibernation disabled
+        // statusClear();  // I am not sure if this should be here or not (Clear all bits in the Status register (0x00))
+        return return_status;
     }
     return false;
 }
@@ -220,19 +218,15 @@ bool I2cDev_MAX17055::full_reset_and_init() {
     if (!soft_reset()) {
         return false;
     }
-
     if (!initialize_custom_parameters()) {
         return false;
     }
-
     if (!load_custom_parameters()) {
         return false;
     }
-
     if (!clear_por()) {
         return false;
     }
-
     return true;
 }
 
@@ -298,8 +292,7 @@ void I2cDev_MAX17055::partialInit() {
 bool I2cDev_MAX17055::reset_learned() {
     // this if for reset all the learned parameters by ic
     // the full inis should do this
-    full_reset_and_init();
-    return true;
+    return full_reset_and_init();
 }
 
 bool I2cDev_MAX17055::detect() {