From 52b951f705b5a3376b81249d46f2b9a739bac11c Mon Sep 17 00:00:00 2001 From: Erwin Ried <1091420+eried@users.noreply.github.com> Date: Mon, 1 Jun 2020 01:59:12 +0200 Subject: [PATCH 1/2] No space after question mark --- firmware/application/apps/ui_script.cpp | 2 +- firmware/application/apps/ui_sd_wipe.cpp | 2 +- firmware/application/ui_navigation.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/firmware/application/apps/ui_script.cpp b/firmware/application/apps/ui_script.cpp index d2e68ac49..702882a67 100644 --- a/firmware/application/apps/ui_script.cpp +++ b/firmware/application/apps/ui_script.cpp @@ -94,7 +94,7 @@ ScriptView::ScriptView( }; button_del.on_select = [this, &nav](Button&) { - nav.push("Confirm", "Are you sure ?", YESNO, + nav.push("Confirm", "Are you sure?", YESNO, [this](bool choice) { if (choice) { on_delete(); diff --git a/firmware/application/apps/ui_sd_wipe.cpp b/firmware/application/apps/ui_sd_wipe.cpp index 295789bd3..f17e76ae2 100644 --- a/firmware/application/apps/ui_sd_wipe.cpp +++ b/firmware/application/apps/ui_sd_wipe.cpp @@ -45,7 +45,7 @@ void WipeSDView::focus() { dummy.focus(); if (!confirmed) { - nav_.push("Warning !", "Wipe FAT of SD card ?", YESCANCEL, [this](bool choice) { + nav_.push("Warning !", "Wipe FAT of SD card?", YESCANCEL, [this](bool choice) { if (choice) confirmed = true; } diff --git a/firmware/application/ui_navigation.cpp b/firmware/application/ui_navigation.cpp index a7b7a92f1..937739f02 100644 --- a/firmware/application/ui_navigation.cpp +++ b/firmware/application/ui_navigation.cpp @@ -198,7 +198,7 @@ void SystemStatusView::on_stealth() { void SystemStatusView::on_bias_tee() { if (!portapack::antenna_bias) { - nav_.display_modal("Bias voltage", "Enable DC voltage on\nantenna connector ?", YESNO, [this](bool v) { + nav_.display_modal("Bias voltage", "Enable DC voltage on\nantenna connector?", YESNO, [this](bool v) { if (v) { portapack::set_antenna_bias(true); //radio::set_antenna_bias(true); From 59b310dff5b5a814c8bbd443aacb2657f6ca1ba8 Mon Sep 17 00:00:00 2001 From: Erwin Ried <1091420+eried@users.noreply.github.com> Date: Mon, 1 Jun 2020 01:59:40 +0200 Subject: [PATCH 2/2] Friendlier UI in fileman --- firmware/application/apps/ui_fileman.cpp | 6 +++--- firmware/application/apps/ui_fileman.hpp | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/firmware/application/apps/ui_fileman.cpp b/firmware/application/apps/ui_fileman.cpp index e10f61fb1..0e5eaf9e7 100644 --- a/firmware/application/apps/ui_fileman.cpp +++ b/firmware/application/apps/ui_fileman.cpp @@ -32,8 +32,8 @@ namespace ui { void FileManBaseView::load_directory_contents(const std::filesystem::path& dir_path) { current_path = dir_path; - text_current.set(dir_path.string().substr(0, 30 - 8)); - + text_current.set(dir_path.string().length()? dir_path.string().substr(0, 30 - 6):"(sd root)"); + entry_list.clear(); auto filtering = (bool)extension_filter.size(); @@ -315,7 +315,7 @@ FileManagerView::FileManagerView( button_delete.on_select = [this, &nav](Button&) { // Use display_modal ? - nav.push("Delete", "Delete " + entry_list[menu_view.highlighted_index()].entry_path.filename().string() + "\nAre you sure ?", YESNO, + nav.push("Delete", "Delete " + entry_list[menu_view.highlighted_index()].entry_path.filename().string() + "\nAre you sure?", YESNO, [this](bool choice) { if (choice) on_delete(); diff --git a/firmware/application/apps/ui_fileman.hpp b/firmware/application/apps/ui_fileman.hpp index 2ea385716..68c09db82 100644 --- a/firmware/application/apps/ui_fileman.hpp +++ b/firmware/application/apps/ui_fileman.hpp @@ -85,10 +85,10 @@ protected: void refresh_list(); Labels labels { - { { 0, 0 }, "Current:", Color::light_grey() } + { { 0, 0 }, "Path:", Color::light_grey() } }; Text text_current { - { 8 * 8, 0 * 8, 22 * 8, 16 }, + { 6 * 8, 0 * 8, 24 * 8, 16 }, "", };