Beep-on-packets option in Settings and updated ERT & Sonde apps (#2058)

* Beep-on-packets option in Settings
* Add beep to ERT app

firmware/application/apps/ert_app.cpp

@@ -23,7 +23,7 @@
 #include "ert_app.hpp"
 
 #include "baseband_api.hpp"
-
+#include "audio.hpp"
 #include "portapack.hpp"
 using namespace portapack;
 
@@ -33,6 +33,8 @@ using namespace portapack;
 #include "string_format.hpp"
 #include "file_path.hpp"
 
+namespace pmem = portapack::persistent_memory;
+
 namespace ert {
 
 namespace format {
@@ -121,6 +123,7 @@ ERTAppView::ERTAppView(NavigationView& nav)
         &field_lna,
         &field_vga,
         &rssi,
+        &field_volume,
         &recent_entries_view,
     });
 
@@ -132,9 +135,15 @@ ERTAppView::ERTAppView(NavigationView& nav)
     if (logger) {
         logger->append(logs_dir / u"ERT.TXT");
     }
+
+    if (pmem::beep_on_packets()) {
+        audio::set_rate(audio::Rate::Hz_24000);
+        audio::output::start();
+    }
 }
 
 ERTAppView::~ERTAppView() {
+    audio::output::stop();
     receiver_model.disable();
     baseband::shutdown();
 }
@@ -158,6 +167,10 @@ void ERTAppView::on_packet(const ert::Packet& packet) {
         entry.update(packet);
         recent_entries_view.set_dirty();
     }
+
+    if (pmem::beep_on_packets()) {
+        baseband::request_audio_beep(1000, 24000, 60);
+    }
 }
 
 void ERTAppView::on_show_list() {

firmware/application/apps/ert_app.hpp

@@ -165,6 +165,9 @@ class ERTAppView : public View {
         {21 * 8, 0, 6 * 8, 4},
     };
 
+    AudioVolumeField field_volume{
+        {28 * 8, 0 * 16}};
+
     MessageHandlerRegistration message_handler_packet{
         Message::ID::ERTPacket,
         [this](Message* const p) {

firmware/application/apps/ui_settings.cpp

@@ -635,13 +635,17 @@ void SetPersistentMemoryView::focus() {
 SetAudioView::SetAudioView(NavigationView& nav) {
     add_children({&labels,
                   &field_tone_mix,
+                  &checkbox_beep_on_packets,
                   &button_save,
                   &button_cancel});
 
     field_tone_mix.set_value(pmem::tone_mix());
 
+    checkbox_beep_on_packets.set_value(pmem::beep_on_packets());
+
     button_save.on_select = [&nav, this](Button&) {
         pmem::set_tone_mix(field_tone_mix.value());
+        pmem::set_beep_on_packets(checkbox_beep_on_packets.value());
         audio::output::update_audio_mute();
         nav.pop();
     };

firmware/application/apps/ui_settings.hpp

@@ -506,8 +506,12 @@ class SetAudioView : public View {
     Labels labels{
         {{1 * 8, 1 * 16}, "Controls the volume of the", Color::light_grey()},
         {{1 * 8, 2 * 16}, "tone when transmitting in", Color::light_grey()},
-        {{1 * 8, 3 * 16}, "Soundboard or Mic apps.", Color::light_grey()},
+        {{1 * 8, 3 * 16}, "Soundboard or Mic apps:", Color::light_grey()},
         {{2 * 8, 5 * 16}, "Tone key mix:   %", Color::light_grey()},
+        {{1 * 8, 8 * 16}, "Controls whether apps should", Color::light_grey()},
+        {{1 * 8, 9 * 16}, "beep on speaker & headphone", Color::light_grey()},
+        {{1 * 8, 10 * 16}, "when a packet is received", Color::light_grey()},
+        {{1 * 8, 11 * 16}, "(not all apps support this):", Color::light_grey()},
     };
 
     NumberField field_tone_mix{
@@ -517,6 +521,11 @@ class SetAudioView : public View {
         1,
         '0'};
 
+    Checkbox checkbox_beep_on_packets{
+        {3 * 8, 13 * 16},
+        16,
+        "Beep on RX packets"};
+
     Button button_save{
         {2 * 8, 16 * 16, 12 * 8, 32},
         "Save"};

firmware/application/apps/ui_sonde.cpp

@@ -32,6 +32,7 @@
 #include <stdio.h>
 
 using namespace portapack;
+namespace pmem = portapack::persistent_memory;
 
 #include "string_format.hpp"
 #include "complex.hpp"
@@ -54,7 +55,6 @@ SondeView::SondeView(NavigationView& nav)
                   &field_vga,
                   &rssi,
                   &field_volume,
-                  &check_beep,
                   &check_log,
                   &check_crc,
                   &text_signature,
@@ -72,13 +72,6 @@ SondeView::SondeView(NavigationView& nav)
 
     geopos.set_read_only(true);
 
-    check_beep.set_value(beep);
-    check_beep.on_select = [this](Checkbox&, bool v) {
-        beep = v;
-        if (beep)
-            baseband::request_audio_beep(1000, 24000, 60);  // 1khz tone for 60ms to acknowledge enablement
-    };
-
     check_log.set_value(logging);
     check_log.on_select = [this](Checkbox&, bool v) {
         logging = v;
@@ -115,7 +108,10 @@ SondeView::SondeView(NavigationView& nav)
     if (logger)
         logger->append(logs_dir / u"SONDE.TXT");
 
-    audio::output::start();
+    if (pmem::beep_on_packets()) {
+        audio::set_rate(audio::Rate::Hz_24000);
+        audio::output::start();
+    }
 
     // inject a PitchRSSIConfigureMessage in order to arm
     // the pitch rssi events that will be used by the
@@ -185,7 +181,7 @@ void SondeView::on_packet(const sonde::Packet& packet) {
             logger->on_packet(packet);
         }
 
-        if (beep) {
+        if (pmem::beep_on_packets()) {
             baseband::request_rssi_beep();
         }
     }

firmware/application/apps/ui_sonde.hpp

@@ -75,14 +75,12 @@ class SondeView : public View {
         1750000 /* bandwidth */,
         2457600 /* sampling rate */
     };
-    bool beep{false};
     bool logging{false};
     bool use_crc{false};
     app_settings::SettingsManager settings_{
         "rx_sonde",
         app_settings::Mode::RX,
         {
-            {"beep"sv, &beep},
             {"logging"sv, &logging},
             {"use_crc"sv, &use_crc},
         }};
@@ -124,11 +122,6 @@ class SondeView : public View {
     AudioVolumeField field_volume{
         {28 * 8, 0 * 16}};
 
-    Checkbox check_beep{
-        {22 * 8, 6 * 16},
-        3,
-        "Beep"};
-
     Checkbox check_log{
         {22 * 8, 8 * 16},
         3,