TheArchive/mayhem-firmware
1
0
Fork 0
mirror of https://github.com/portapack-mayhem/mayhem-firmware.git synced 2024-11-27 12:05:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updated PR process (markdown)

jLynx 2023-05-22 12:08:34 +12:00
parent e25cece3d4
commit 7c6e31d714
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
PR-process.md

@ -4,6 +4,6 @@ In order to get your PR merged into the code base, there are a few checks that n
* If any code reviewer left PR comments, then all those PR comments left by reviewers need to be marked as resolved. * If any code reviewer left PR comments, then all those PR comments left by reviewers need to be marked as resolved.
* All 3 code format gate checks need to complete successfully. (don't know how to format your code? Check out how to do it here https://github.com/eried/portapack-mayhem/wiki/Code-formatting) * All 3 code format gate checks need to complete successfully. (don't know how to format your code? Check out how to do it here https://github.com/eried/portapack-mayhem/wiki/Code-formatting)
Once these steps are all complete, you will notice you have a green merge button available, then means you are good to go and merge your code into the code base. Once these steps are all complete, if you are an approved contributor you will notice you have a green merge button available, then means you are good to go and merge your code into the code base. Everyone else will see that tests have passed and will need to ask an approved contributor to merge it in for them (You can as the dev that approved the changes).
If any of these steps are not complete or failed, then you will be blocked from merging your code until they have all been completed. If any of these steps are not complete or failed, then you will be blocked from merging your code until they have all been completed.