mirror of
https://github.com/portapack-mayhem/mayhem-firmware.git
synced 2025-02-17 12:18:29 +00:00
Updated PR process (markdown)
parent
9350d6ecb3
commit
7d1e09abf4
@ -1,7 +1,7 @@
|
|||||||
In order to get your PR merged into the code base, there are a few checks that need to happen first.
|
In order to get your PR merged into the code base, there are a few checks that need to happen first.
|
||||||
|
|
||||||
* At least one code approver needs to approve your code.
|
* At least one code approver needs to approve your code.
|
||||||
* All PR comments left by reviewers need to be marked as resolved.
|
* If any code reviewer left PR comments, then all those PR comments left by reviewers need to be marked as resolved.
|
||||||
* All 3 code format gate checks need to complete successfully. (don't know how to format your code? Check out how to do it here https://github.com/eried/portapack-mayhem/wiki/Code-formatting)
|
* All 3 code format gate checks need to complete successfully. (don't know how to format your code? Check out how to do it here https://github.com/eried/portapack-mayhem/wiki/Code-formatting)
|
||||||
|
|
||||||
Once these steps are all complete, you will notice you have a green merge button available, then means you are good to go and merge your code into the code base.
|
Once these steps are all complete, you will notice you have a green merge button available, then means you are good to go and merge your code into the code base.
|
||||||
|
Loading…
x
Reference in New Issue
Block a user