TheArchive/restic
1
0
Fork 0
mirror of https://github.com/restic/restic.git synced 2025-12-16 00:42:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

lock: Do not ignore invalid lock files

Browse Source 
While searching for lock file from concurrently running restic
instances, restic ignored unreadable lock files. These can either be
in fact invalid or just be temporarily unreadable. As it is not really
possible to differentiate between both cases, just err on the side of
caution and consider the repository as already locked.

The code retries searching for other locks up to three times to smooth
out temporarily unreadable lock files.
This commit is contained in:
Michael Eischer
2021-11-20 16:48:22 +01:00
parent aeed420e1a
commit 401e432e9d
3 changed files with 62 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
changelog/unreleased/issue-2715
View File

@@ -1,4 +1,4 @@
Enhancement: Cancel commands if lock is not refresh in time
Enhancement: Stricter repository lock handling
Restic commands kept running even if they failed to refresh their locks in
time. This can be a problem if a concurrent call to `unlock` and `prune`
@@ -8,5 +8,10 @@ be caused by a client switching to standby while running a backup.
Lock handling is now much stricter. Commands requiring a lock are canceled if
the lock is not refreshed successfully in time.
In addition, if a lock file is not readable restic will not allow starting a
command. It may be necessary to remove invalid lock file manually or using
`unlock --remove-all`. Please make sure that no other restic processes are
running concurrently.
https://github.com/restic/restic/issues/2715
https://github.com/restic/restic/pull/3569