mirror of
https://github.com/restic/restic.git
synced 2025-08-22 17:57:48 +00:00
Refactor node.go
This commit is contained in:
@@ -15,10 +15,10 @@ func (node *Node) OpenForReading() (*os.File, error) {
|
||||
return os.Open(node.path)
|
||||
}
|
||||
|
||||
func (node *Node) fillExtra(path string, fi os.FileInfo) (err error) {
|
||||
func (node *Node) fillExtra(path string, fi os.FileInfo) error {
|
||||
stat, ok := fi.Sys().(*syscall.Stat_t)
|
||||
if !ok {
|
||||
return
|
||||
return nil
|
||||
}
|
||||
|
||||
node.ChangeTime = time.Unix(stat.Ctimespec.Unix())
|
||||
@@ -26,24 +26,19 @@ func (node *Node) fillExtra(path string, fi os.FileInfo) (err error) {
|
||||
node.UID = stat.Uid
|
||||
node.GID = stat.Gid
|
||||
|
||||
// TODO: cache uid lookup
|
||||
if u, nil := user.LookupId(strconv.Itoa(int(stat.Uid))); err == nil {
|
||||
if u, err := user.LookupId(strconv.Itoa(int(stat.Uid))); err == nil {
|
||||
node.User = u.Username
|
||||
}
|
||||
|
||||
// TODO: implement getgrnam() or use https://github.com/kless/osutil
|
||||
// if g, nil := user.LookupId(strconv.Itoa(int(stat.Uid))); err == nil {
|
||||
// node.User = u.Username
|
||||
// }
|
||||
|
||||
node.Inode = stat.Ino
|
||||
|
||||
var err error
|
||||
|
||||
switch node.Type {
|
||||
case "file":
|
||||
node.Size = uint64(stat.Size)
|
||||
node.Links = uint64(stat.Nlink)
|
||||
case "dir":
|
||||
// nothing to do
|
||||
case "symlink":
|
||||
node.LinkTarget, err = os.Readlink(path)
|
||||
case "dev":
|
||||
@@ -51,11 +46,9 @@ func (node *Node) fillExtra(path string, fi os.FileInfo) (err error) {
|
||||
case "chardev":
|
||||
node.Device = uint64(stat.Rdev)
|
||||
case "fifo":
|
||||
// nothing to do
|
||||
case "socket":
|
||||
// nothing to do
|
||||
default:
|
||||
panic(fmt.Sprintf("invalid node type %q", node.Type))
|
||||
err = fmt.Errorf("invalid node type %q", node.Type)
|
||||
}
|
||||
|
||||
return err
|
||||
@@ -74,27 +67,22 @@ func (node *Node) createFifoAt(path string) error {
|
||||
}
|
||||
|
||||
func (node *Node) isNewer(path string, fi os.FileInfo) bool {
|
||||
// if this node has a type other than "file", treat as if content has changed
|
||||
if node.Type != "file" {
|
||||
debug.Log("node.isNewer", "node %v is newer: not file", path)
|
||||
return true
|
||||
}
|
||||
|
||||
// if the name or type has changed, this is surely something different
|
||||
tpe := nodeTypeFromFileInfo(path, fi)
|
||||
tpe := nodeTypeFromFileInfo(fi)
|
||||
if node.Name != fi.Name() || node.Type != tpe {
|
||||
debug.Log("node.isNewer", "node %v is newer: name or type changed", path)
|
||||
return false
|
||||
}
|
||||
|
||||
// collect extended stat
|
||||
stat := fi.Sys().(*syscall.Stat_t)
|
||||
extendedStat := fi.Sys().(*syscall.Stat_t)
|
||||
changeTime := time.Unix(extendedStat.Ctimespec.Unix())
|
||||
inode := extendedStat.Ino
|
||||
size := uint64(extendedStat.Size)
|
||||
|
||||
changeTime := time.Unix(stat.Ctimespec.Unix())
|
||||
inode := stat.Ino
|
||||
size := uint64(stat.Size)
|
||||
|
||||
// if timestamps or inodes differ, content has changed
|
||||
if node.ModTime != fi.ModTime() ||
|
||||
node.ChangeTime != changeTime ||
|
||||
node.Inode != inode ||
|
||||
@@ -103,7 +91,6 @@ func (node *Node) isNewer(path string, fi os.FileInfo) bool {
|
||||
return false
|
||||
}
|
||||
|
||||
// otherwise the node is assumed to have the same content
|
||||
debug.Log("node.isNewer", "node %v is not newer", path)
|
||||
return false
|
||||
}
|
||||
|
Reference in New Issue
Block a user