small cleanup:

- be explicit when discarding returned errors from .Close(), etc.
- remove named return values from funcs when naked return not used
- fix some "err" shadowing when redeclaration not needed
This commit is contained in:
George Armhold
2017-10-25 12:03:55 -04:00
parent 8d37b723ca
commit bcdebfb84e
8 changed files with 12 additions and 11 deletions

View File

@@ -70,7 +70,7 @@ func writeCachedirTag(dir string) error {
debug.Log("Create CACHEDIR.TAG at %v", dir)
if _, err := f.Write([]byte(cachedirTagSignature)); err != nil {
f.Close()
_ = f.Close()
return errors.Wrap(err, "Write")
}

View File

@@ -65,7 +65,7 @@ func (c *Cache) Load(h restic.Handle, length int, offset int64) (io.ReadCloser,
if offset > 0 {
if _, err = f.Seek(offset, io.SeekStart); err != nil {
f.Close()
_ = f.Close()
return nil, err
}
}