From d8da3d2f2d24b904ff75d1ad4ac103aaf980c445 Mon Sep 17 00:00:00 2001
From: Michael Eischer <michael.eischer@fau.de>
Date: Sun, 21 Sep 2025 20:16:29 +0200
Subject: [PATCH] termstatus: increase test coverage

---
 internal/ui/termstatus/status_test.go | 90 ++++++++++++++++++++++++---
 1 file changed, 80 insertions(+), 10 deletions(-)

diff --git a/internal/ui/termstatus/status_test.go b/internal/ui/termstatus/status_test.go
index bddb7c5d1..f6b885cee 100644
--- a/internal/ui/termstatus/status_test.go
+++ b/internal/ui/termstatus/status_test.go
@@ -6,6 +6,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"strings"
 	"testing"
 
 	"github.com/restic/restic/internal/terminal"
@@ -13,16 +14,7 @@ import (
 )
 
 func TestSetStatus(t *testing.T) {
-	var buf bytes.Buffer
-	term := New(nil, &buf, io.Discard, false)
-
-	term.canUpdateStatus = true
-	term.fd = ^uintptr(0)
-	term.clearCurrentLine = terminal.PosixClearCurrentLine
-	term.moveCursorUp = terminal.PosixMoveCursorUp
-
-	ctx, cancel := context.WithCancel(context.Background())
-	go term.Run(ctx)
+	buf, term, cancel := setupStatusTest()
 
 	const (
 		cl   = terminal.PosixControlClearLine
@@ -58,6 +50,39 @@ func TestSetStatus(t *testing.T) {
 	rtest.Equals(t, exp, buf.String())
 }
 
+func setupStatusTest() (*bytes.Buffer, *Terminal, context.CancelFunc) {
+	buf := &bytes.Buffer{}
+	term := New(nil, buf, buf, false)
+
+	term.canUpdateStatus = true
+	term.fd = ^uintptr(0)
+	term.clearCurrentLine = terminal.PosixClearCurrentLine
+	term.moveCursorUp = terminal.PosixMoveCursorUp
+
+	ctx, cancel := context.WithCancel(context.Background())
+	go term.Run(ctx)
+	return buf, term, cancel
+}
+
+func TestPrint(t *testing.T) {
+	buf, term, cancel := setupStatusTest()
+
+	const (
+		cl   = terminal.PosixControlClearLine
+		home = terminal.PosixControlMoveCursorHome
+	)
+
+	term.Print("test")
+	exp := home + cl + "test\n"
+	term.Error("error")
+	exp += home + cl + "error\n"
+
+	cancel()
+
+	<-term.closed
+	rtest.Equals(t, exp, buf.String())
+}
+
 func TestSanitizeLines(t *testing.T) {
 	var tests = []struct {
 		input  []string
@@ -87,3 +112,48 @@ func TestReadPassword(t *testing.T) {
 	_, err := readPassword(&errorReader{want})
 	rtest.Assert(t, errors.Is(err, want), "wrong error %v", err)
 }
+
+func TestReadPasswordTerminal(t *testing.T) {
+	expected := "password"
+	term := New(io.NopCloser(strings.NewReader(expected)), io.Discard, io.Discard, false)
+	pw, err := term.ReadPassword(context.Background(), "test")
+	rtest.OK(t, err)
+	rtest.Equals(t, expected, pw)
+}
+
+func TestRawInputOutput(t *testing.T) {
+	input := io.NopCloser(strings.NewReader("password"))
+	var output bytes.Buffer
+	term := New(input, &output, io.Discard, false)
+	rtest.Equals(t, input, term.InputRaw())
+	rtest.Equals(t, false, term.InputIsTerminal())
+	rtest.Equals(t, &output, term.OutputRaw())
+	rtest.Equals(t, false, term.OutputIsTerminal())
+	rtest.Equals(t, false, term.CanUpdateStatus())
+}
+
+func TestDisableStatus(t *testing.T) {
+	var output bytes.Buffer
+	term, cancel := Setup(nil, &output, &output, true)
+	rtest.Equals(t, false, term.CanUpdateStatus())
+
+	term.Print("test")
+	term.Error("error")
+	term.SetStatus([]string{"status"})
+
+	cancel()
+	rtest.Equals(t, "test\nerror\nstatus\n", output.String())
+}
+
+func TestOutputWriter(t *testing.T) {
+	var output bytes.Buffer
+	term, cancel := Setup(nil, &output, &output, true)
+
+	_, err := term.OutputWriter().Write([]byte("output\npartial"))
+	rtest.OK(t, err)
+	term.Print("test")
+	term.Error("error")
+
+	cancel()
+	rtest.Equals(t, "output\ntest\nerror\npartial\n", output.String())
+}