Fix for occasional NPE

This commit is contained in:
Moxie Marlinspike 2012-11-30 19:48:48 -08:00
parent 575341704e
commit 0e5ff9bdac

View File

@ -25,10 +25,11 @@ import org.thoughtcrime.securesms.R;
import org.thoughtcrime.securesms.database.DatabaseFactory; import org.thoughtcrime.securesms.database.DatabaseFactory;
import org.thoughtcrime.securesms.util.NumberUtil; import org.thoughtcrime.securesms.util.NumberUtil;
import java.util.ArrayList;
import java.util.Collections; import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.LinkedHashMap; import java.util.LinkedHashMap;
import java.util.LinkedList;
import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.StringTokenizer; import java.util.StringTokenizer;
@ -54,7 +55,10 @@ public class RecipientFactory {
} }
public static Recipients getRecipientsForIds(Context context, String recipientIds) { public static Recipients getRecipientsForIds(Context context, String recipientIds) {
ArrayList<Recipient> results = new ArrayList<Recipient>(); if (recipientIds == null || recipientIds.trim().length() == 0)
return new Recipients(new LinkedList<Recipient>());
List<Recipient> results = new LinkedList<Recipient>();
StringTokenizer tokenizer = new StringTokenizer(recipientIds.trim(), " "); StringTokenizer tokenizer = new StringTokenizer(recipientIds.trim(), " ");
while (tokenizer.hasMoreTokens()) { while (tokenizer.hasMoreTokens()) {
@ -87,7 +91,7 @@ public class RecipientFactory {
} }
public static Recipients getRecipientsFromString(Context context, String rawText) throws RecipientFormattingException { public static Recipients getRecipientsFromString(Context context, String rawText) throws RecipientFormattingException {
ArrayList<Recipient> results = new ArrayList<Recipient>(); List<Recipient> results = new LinkedList<Recipient>();
StringTokenizer tokenizer = new StringTokenizer(rawText, ","); StringTokenizer tokenizer = new StringTokenizer(rawText, ",");
while (tokenizer.hasMoreTokens()) { while (tokenizer.hasMoreTokens()) {