From c4d302e3ac925a76af3ea84df0f7826608badf22 Mon Sep 17 00:00:00 2001 From: Niels Andriesse Date: Thu, 12 Mar 2020 10:49:17 +1100 Subject: [PATCH 1/7] Fix group conversation layout --- res/layout/conversation_item_received.xml | 4 ++-- .../thoughtcrime/securesms/conversation/ConversationItem.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/res/layout/conversation_item_received.xml b/res/layout/conversation_item_received.xml index 179f4b2798..400377e17c 100644 --- a/res/layout/conversation_item_received.xml +++ b/res/layout/conversation_item_received.xml @@ -18,7 +18,7 @@ android:id="@+id/container" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingStart="@dimen/large_spacing" + android:paddingStart="12dp" android:clipToPadding="false" android:clipChildren="false"> @@ -58,7 +58,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="@dimen/massive_spacing" - android:layout_marginStart="@dimen/large_spacing" + android:layout_marginStart="12dp" android:paddingTop="@dimen/medium_spacing" android:paddingBottom="@dimen/medium_spacing" android:orientation="vertical" diff --git a/src/org/thoughtcrime/securesms/conversation/ConversationItem.java b/src/org/thoughtcrime/securesms/conversation/ConversationItem.java index d63da04f01..e3131dc875 100644 --- a/src/org/thoughtcrime/securesms/conversation/ConversationItem.java +++ b/src/org/thoughtcrime/securesms/conversation/ConversationItem.java @@ -798,7 +798,7 @@ public class ConversationItem extends LinearLayout private void setContactPhoto(@NonNull Recipient recipient) { LinearLayout.LayoutParams layoutParams = (LinearLayout.LayoutParams)bodyBubble.getLayoutParams(); - int groupThreadMargin = (int)(getResources().getDimension(R.dimen.large_spacing) + getResources().getDimension(R.dimen.small_profile_picture_size)); + int groupThreadMargin = (int)((12 * getResources().getDisplayMetrics().density) + getResources().getDimension(R.dimen.small_profile_picture_size)); int defaultMargin = 0; String threadName = DatabaseFactory.getThreadDatabase(context).getRecipientForThreadId(messageRecord.getThreadId()).getName(); boolean isRSSFeed = threadName != null && (threadName.equals("Loki News") || threadName.equals("Session Updates")); From 8ff4688de136ba18b30f04f3c82c32d0a17a3a7b Mon Sep 17 00:00:00 2001 From: Niels Andriesse Date: Thu, 12 Mar 2020 11:16:07 +1100 Subject: [PATCH 2/7] Handle new closed group screen empty state --- res/layout/activity_create_closed_group.xml | 94 +++++++++++++------ .../activities/CreateClosedGroupActivity.kt | 16 +++- .../loki/redesign/activities/HomeActivity.kt | 9 +- 3 files changed, 86 insertions(+), 33 deletions(-) diff --git a/res/layout/activity_create_closed_group.xml b/res/layout/activity_create_closed_group.xml index d0c31bb112..67d64f3697 100644 --- a/res/layout/activity_create_closed_group.xml +++ b/res/layout/activity_create_closed_group.xml @@ -1,42 +1,74 @@ - + android:background="@drawable/default_session_background" > - + + + + + + + + + + + + + android:gravity="center_horizontal" + android:orientation="vertical" + android:layout_centerInParent="true"> - + - +