From 12d9d7741b0c1b2bd82407be46f62803157e49a5 Mon Sep 17 00:00:00 2001
From: Greyson Parrelli <greyson@signal.org>
Date: Thu, 27 Sep 2018 10:16:40 -0700
Subject: [PATCH] Clean up batch saving.

- Post a better string for when batch saving completes successfully
- Exit multi-select after saving
---
 res/values/strings.xml                                    | 1 +
 src/org/thoughtcrime/securesms/MediaOverviewActivity.java | 1 +
 .../thoughtcrime/securesms/util/SaveAttachmentTask.java   | 8 ++++----
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/res/values/strings.xml b/res/values/strings.xml
index 0a8287dfc3..9702a58763 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -701,6 +701,7 @@
 
     <!-- SaveAttachmentTask -->
     <string name="SaveAttachmentTask_saved_to">Saved to %s</string>
+    <string name="SaveAttachmentTask_saved">Saved</string>
 
     <!-- SearchToolbar -->
     <string name="SearchToolbar_search">Search</string>
diff --git a/src/org/thoughtcrime/securesms/MediaOverviewActivity.java b/src/org/thoughtcrime/securesms/MediaOverviewActivity.java
index ace8539e29..7014fe366a 100644
--- a/src/org/thoughtcrime/securesms/MediaOverviewActivity.java
+++ b/src/org/thoughtcrime/securesms/MediaOverviewActivity.java
@@ -360,6 +360,7 @@ public class MediaOverviewActivity extends PassphraseRequiredActionBarActivity {
                                                                               attachments.size());
                          saveTask.executeOnExecutor(THREAD_POOL_EXECUTOR,
                                                     attachments.toArray(new SaveAttachmentTask.Attachment[attachments.size()]));
+                         exitMultiSelect();
                        }
                      }.execute();
                    })
diff --git a/src/org/thoughtcrime/securesms/util/SaveAttachmentTask.java b/src/org/thoughtcrime/securesms/util/SaveAttachmentTask.java
index c9de722e0f..8a7ae7e062 100644
--- a/src/org/thoughtcrime/securesms/util/SaveAttachmentTask.java
+++ b/src/org/thoughtcrime/securesms/util/SaveAttachmentTask.java
@@ -7,6 +7,7 @@ import android.net.Uri;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.support.v7.app.AlertDialog;
+import android.text.TextUtils;
 import android.webkit.MimeTypeMap;
 import android.widget.Toast;
 
@@ -188,10 +189,9 @@ public class SaveAttachmentTask extends ProgressDialogAsyncTask<SaveAttachmentTa
                        Toast.LENGTH_LONG).show();
         break;
       case SUCCESS:
-        Toast.makeText(context,
-                       context.getResources().getString(R.string.SaveAttachmentTask_saved_to,
-                                                        result.second()),
-                       Toast.LENGTH_LONG).show();
+        String message = !TextUtils.isEmpty(result.second())  ? context.getResources().getString(R.string.SaveAttachmentTask_saved_to, result.second())
+                                                              : context.getResources().getString(R.string.SaveAttachmentTask_saved);
+        Toast.makeText(context, message, Toast.LENGTH_LONG).show();
         break;
       case WRITE_ACCESS_FAILURE:
         Toast.makeText(context, R.string.ConversationFragment_unable_to_write_to_sd_card_exclamation,