mirror of
				https://github.com/oxen-io/session-android.git
				synced 2025-11-04 01:01:22 +00:00 
			
		
		
		
	Disable forwarding for shared contacts.
Forwarding of shared contacts currently just creates an empty draft. You can't preview a shared contact before you send, which would make the forwarding flow inconsistent across media types. So it's easier to just hide it for now. Fixes #8195
This commit is contained in:
		@@ -242,6 +242,7 @@ public class ConversationFragment extends Fragment
 | 
			
		||||
    Set<MessageRecord> messageRecords = getListAdapter().getSelectedItems();
 | 
			
		||||
    boolean            actionMessage  = false;
 | 
			
		||||
    boolean            hasText        = false;
 | 
			
		||||
    boolean            sharedContact  = false;
 | 
			
		||||
 | 
			
		||||
    if (actionMode != null && messageRecords.size() == 0) {
 | 
			
		||||
      actionMode.finish();
 | 
			
		||||
@@ -256,11 +257,13 @@ public class ConversationFragment extends Fragment
 | 
			
		||||
      {
 | 
			
		||||
        actionMessage = true;
 | 
			
		||||
      }
 | 
			
		||||
 | 
			
		||||
      if (messageRecord.getBody().length() > 0) {
 | 
			
		||||
        hasText = true;
 | 
			
		||||
      }
 | 
			
		||||
      if (actionMessage && hasText) {
 | 
			
		||||
        break;
 | 
			
		||||
 | 
			
		||||
      if (messageRecord.isMms() && !((MmsMessageRecord) messageRecord).getSharedContacts().isEmpty()) {
 | 
			
		||||
        sharedContact = true;
 | 
			
		||||
      }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
@@ -279,7 +282,7 @@ public class ConversationFragment extends Fragment
 | 
			
		||||
                                                                  !messageRecord.isMmsNotification() &&
 | 
			
		||||
                                                                  ((MediaMmsMessageRecord)messageRecord).containsMediaSlide());
 | 
			
		||||
 | 
			
		||||
      menu.findItem(R.id.menu_context_forward).setVisible(!actionMessage);
 | 
			
		||||
      menu.findItem(R.id.menu_context_forward).setVisible(!actionMessage && !sharedContact);
 | 
			
		||||
      menu.findItem(R.id.menu_context_details).setVisible(!actionMessage);
 | 
			
		||||
      menu.findItem(R.id.menu_context_reply).setVisible(!actionMessage             &&
 | 
			
		||||
                                                        !messageRecord.isPending() &&
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user