From 1ff4fd842c7a978e4d7eaf6423654d354b9d6c10 Mon Sep 17 00:00:00 2001 From: Moxie Marlinspike Date: Sun, 17 Feb 2013 15:07:37 -0800 Subject: [PATCH] Pass on incoming messages until DB is imported. --- .../securesms/service/MmsListener.java | 44 ++++++++++--------- .../securesms/service/SmsListener.java | 3 ++ 2 files changed, 27 insertions(+), 20 deletions(-) diff --git a/src/org/thoughtcrime/securesms/service/MmsListener.java b/src/org/thoughtcrime/securesms/service/MmsListener.java index 0dae2827f9..ab8f57af2d 100644 --- a/src/org/thoughtcrime/securesms/service/MmsListener.java +++ b/src/org/thoughtcrime/securesms/service/MmsListener.java @@ -1,6 +1,6 @@ -/** +/** * Copyright (C) 2011 Whisper Systems - * + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or @@ -10,12 +10,19 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * + * * You should have received a copy of the GNU General Public License * along with this program. If not, see . */ package org.thoughtcrime.securesms.service; +import android.content.BroadcastReceiver; +import android.content.Context; +import android.content.Intent; +import android.os.Build; +import android.preference.PreferenceManager; +import android.util.Log; + import org.thoughtcrime.securesms.ApplicationPreferencesActivity; import org.thoughtcrime.securesms.protocol.WirePrefix; @@ -23,51 +30,48 @@ import ws.com.google.android.mms.pdu.GenericPdu; import ws.com.google.android.mms.pdu.NotificationInd; import ws.com.google.android.mms.pdu.PduHeaders; import ws.com.google.android.mms.pdu.PduParser; -import android.content.BroadcastReceiver; -import android.content.Context; -import android.content.Intent; -import android.os.Build; -import android.preference.PreferenceManager; -import android.util.Log; public class MmsListener extends BroadcastReceiver { private boolean isRelevent(Context context, Intent intent) { if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.DONUT) return false; - + + if (!ApplicationMigrationService.isDatabaseImported(context)) + return false; + if (PreferenceManager.getDefaultSharedPreferences(context).getBoolean(ApplicationPreferencesActivity.ALL_MMS_PERF, true)) return true; - + byte[] mmsData = intent.getByteArrayExtra("data"); PduParser parser = new PduParser(mmsData); GenericPdu pdu = parser.parse(); - + if (pdu.getMessageType() != PduHeaders.MESSAGE_TYPE_NOTIFICATION_IND) return false; - + NotificationInd notificationPdu = (NotificationInd)pdu; - + if (notificationPdu.getSubject() == null) return false; - + return WirePrefix.isEncryptedMmsSubject(notificationPdu.getSubject().getString()); } - + @Override public void onReceive(Context context, Intent intent) { Log.w("MmsListener", "Got MMS broadcast..."); - + if (isRelevent(context, intent)) { intent.setAction(SendReceiveService.RECEIVE_MMS_ACTION); intent.putExtra("ResultCode", this.getResultCode()); intent.setClass(context, SendReceiveService.class); - + context.startService(intent); abortBroadcast(); } } - - + + } diff --git a/src/org/thoughtcrime/securesms/service/SmsListener.java b/src/org/thoughtcrime/securesms/service/SmsListener.java index 002f404ca6..f468abee23 100644 --- a/src/org/thoughtcrime/securesms/service/SmsListener.java +++ b/src/org/thoughtcrime/securesms/service/SmsListener.java @@ -82,6 +82,9 @@ public class SmsListener extends BroadcastReceiver { if (isExemption(message, messageBody)) return false; + if (!ApplicationMigrationService.isDatabaseImported(context)) + return false; + if (PreferenceManager.getDefaultSharedPreferences(context).getBoolean("pref_all_sms", true)) return true;