Add support for handling unknown protobuf fields.

This commit is contained in:
Greyson Parrelli
2020-08-20 16:05:50 -04:00
committed by Alex Hart
parent ffcb90da52
commit 2cf9eb69eb
15 changed files with 631 additions and 47 deletions

View File

@@ -4,6 +4,7 @@ import com.google.protobuf.ByteString;
import org.whispersystems.libsignal.util.guava.Optional;
import org.whispersystems.signalservice.api.util.OptionalUtil;
import org.whispersystems.signalservice.api.util.ProtoUtil;
import org.whispersystems.signalservice.internal.storage.protos.AccountRecord;
import java.util.Objects;
@@ -12,6 +13,7 @@ public final class SignalAccountRecord implements SignalRecord {
private final StorageId id;
private final AccountRecord proto;
private final boolean hasUnknownFields;
private final Optional<String> givenName;
private final Optional<String> familyName;
@@ -19,8 +21,9 @@ public final class SignalAccountRecord implements SignalRecord {
private final Optional<byte[]> profileKey;
public SignalAccountRecord(StorageId id, AccountRecord proto) {
this.id = id;
this.proto = proto;
this.id = id;
this.proto = proto;
this.hasUnknownFields = ProtoUtil.hasUnknownFields(proto);
this.givenName = OptionalUtil.absentIfEmpty(proto.getGivenName());
this.familyName = OptionalUtil.absentIfEmpty(proto.getFamilyName());
@@ -33,6 +36,14 @@ public final class SignalAccountRecord implements SignalRecord {
return id;
}
public boolean hasUnknownFields() {
return hasUnknownFields;
}
public byte[] serializeUnknownFields() {
return hasUnknownFields ? proto.toByteArray() : null;
}
public Optional<String> getGivenName() {
return givenName;
}
@@ -91,11 +102,18 @@ public final class SignalAccountRecord implements SignalRecord {
private final StorageId id;
private final AccountRecord.Builder builder;
private byte[] unknownFields;
public Builder(byte[] rawId) {
this.id = StorageId.forAccount(rawId);
this.builder = AccountRecord.newBuilder();
}
public Builder setUnknownFields(byte[] serializedUnknowns) {
this.unknownFields = serializedUnknowns;
return this;
}
public Builder setGivenName(String givenName) {
builder.setGivenName(givenName == null ? "" : givenName);
return this;
@@ -142,7 +160,13 @@ public final class SignalAccountRecord implements SignalRecord {
}
public SignalAccountRecord build() {
return new SignalAccountRecord(id, builder.build());
AccountRecord proto = builder.build();
if (unknownFields != null) {
proto = ProtoUtil.combineWithUnknownFields(proto, unknownFields);
}
return new SignalAccountRecord(id, proto);
}
}
}

View File

@@ -5,6 +5,7 @@ import com.google.protobuf.ByteString;
import org.whispersystems.libsignal.util.guava.Optional;
import org.whispersystems.signalservice.api.push.SignalServiceAddress;
import org.whispersystems.signalservice.api.util.OptionalUtil;
import org.whispersystems.signalservice.api.util.ProtoUtil;
import org.whispersystems.signalservice.api.util.UuidUtil;
import org.whispersystems.signalservice.internal.storage.protos.ContactRecord;
import org.whispersystems.signalservice.internal.storage.protos.ContactRecord.IdentityState;
@@ -15,6 +16,7 @@ public final class SignalContactRecord implements SignalRecord {
private final StorageId id;
private final ContactRecord proto;
private final boolean hasUnknownFields;
private final SignalServiceAddress address;
private final Optional<String> givenName;
@@ -24,8 +26,9 @@ public final class SignalContactRecord implements SignalRecord {
private final Optional<byte[]> identityKey;
public SignalContactRecord(StorageId id, ContactRecord proto) {
this.id = id;
this.proto = proto;
this.id = id;
this.proto = proto;
this.hasUnknownFields = ProtoUtil.hasUnknownFields(proto);
this.address = new SignalServiceAddress(UuidUtil.parseOrNull(proto.getServiceUuid()), proto.getServiceE164());
this.givenName = OptionalUtil.absentIfEmpty(proto.getGivenName());
@@ -40,6 +43,14 @@ public final class SignalContactRecord implements SignalRecord {
return id;
}
public boolean hasUnknownFields() {
return hasUnknownFields;
}
public byte[] serializeUnknownFields() {
return hasUnknownFields ? proto.toByteArray() : null;
}
public SignalServiceAddress getAddress() {
return address;
}
@@ -102,6 +113,8 @@ public final class SignalContactRecord implements SignalRecord {
private final StorageId id;
private final ContactRecord.Builder builder;
private byte[] unknownFields;
public Builder(byte[] rawId, SignalServiceAddress address) {
this.id = StorageId.forContact(rawId);
this.builder = ContactRecord.newBuilder();
@@ -110,6 +123,11 @@ public final class SignalContactRecord implements SignalRecord {
builder.setServiceE164(address.getNumber().or(""));
}
public Builder setUnknownFields(byte[] serializedUnknowns) {
this.unknownFields = serializedUnknowns;
return this;
}
public Builder setGivenName(String givenName) {
builder.setGivenName(givenName == null ? "" : givenName);
return this;
@@ -156,7 +174,13 @@ public final class SignalContactRecord implements SignalRecord {
}
public SignalContactRecord build() {
return new SignalContactRecord(id, builder.build());
ContactRecord proto = builder.build();
if (unknownFields != null) {
proto = ProtoUtil.combineWithUnknownFields(proto, unknownFields);
}
return new SignalContactRecord(id, proto);
}
}
}

View File

@@ -2,6 +2,7 @@ package org.whispersystems.signalservice.api.storage;
import com.google.protobuf.ByteString;
import org.whispersystems.signalservice.api.util.ProtoUtil;
import org.whispersystems.signalservice.internal.storage.protos.GroupV1Record;
import java.util.Objects;
@@ -11,11 +12,13 @@ public final class SignalGroupV1Record implements SignalRecord {
private final StorageId id;
private final GroupV1Record proto;
private final byte[] groupId;
private final boolean hasUnknownFields;
public SignalGroupV1Record(StorageId id, GroupV1Record proto) {
this.id = id;
this.proto = proto;
this.groupId = proto.getId().toByteArray();
this.id = id;
this.proto = proto;
this.groupId = proto.getId().toByteArray();
this.hasUnknownFields = ProtoUtil.hasUnknownFields(proto);
}
@Override
@@ -23,6 +26,14 @@ public final class SignalGroupV1Record implements SignalRecord {
return id;
}
public boolean hasUnknownFields() {
return hasUnknownFields;
}
public byte[] serializeUnknownFields() {
return hasUnknownFields ? proto.toByteArray() : null;
}
public byte[] getGroupId() {
return groupId;
}
@@ -61,6 +72,8 @@ public final class SignalGroupV1Record implements SignalRecord {
private final StorageId id;
private final GroupV1Record.Builder builder;
private byte[] unknownFields;
public Builder(byte[] rawId, byte[] groupId) {
this.id = StorageId.forGroupV1(rawId);
this.builder = GroupV1Record.newBuilder();
@@ -68,6 +81,11 @@ public final class SignalGroupV1Record implements SignalRecord {
builder.setId(ByteString.copyFrom(groupId));
}
public Builder setUnknownFields(byte[] serializedUnknowns) {
this.unknownFields = serializedUnknowns;
return this;
}
public Builder setBlocked(boolean blocked) {
builder.setBlocked(blocked);
return this;
@@ -84,7 +102,13 @@ public final class SignalGroupV1Record implements SignalRecord {
}
public SignalGroupV1Record build() {
return new SignalGroupV1Record(id, builder.build());
GroupV1Record proto = builder.build();
if (unknownFields != null) {
proto = ProtoUtil.combineWithUnknownFields(proto, unknownFields);
}
return new SignalGroupV1Record(id, proto);
}
}
}

View File

@@ -4,7 +4,7 @@ import com.google.protobuf.ByteString;
import org.signal.zkgroup.InvalidInputException;
import org.signal.zkgroup.groups.GroupMasterKey;
import org.whispersystems.signalservice.internal.storage.protos.GroupV1Record;
import org.whispersystems.signalservice.api.util.ProtoUtil;
import org.whispersystems.signalservice.internal.storage.protos.GroupV2Record;
import java.util.Objects;
@@ -14,10 +14,12 @@ public final class SignalGroupV2Record implements SignalRecord {
private final StorageId id;
private final GroupV2Record proto;
private final GroupMasterKey masterKey;
private final boolean hasUnknownFields;
public SignalGroupV2Record(StorageId id, GroupV2Record proto) {
this.id = id;
this.proto = proto;
this.id = id;
this.proto = proto;
this.hasUnknownFields = ProtoUtil.hasUnknownFields(proto);
try {
this.masterKey = new GroupMasterKey(proto.getMasterKey().toByteArray());
} catch (InvalidInputException e) {
@@ -30,6 +32,14 @@ public final class SignalGroupV2Record implements SignalRecord {
return id;
}
public boolean hasUnknownFields() {
return hasUnknownFields;
}
public byte[] serializeUnknownFields() {
return hasUnknownFields ? proto.toByteArray() : null;
}
public GroupMasterKey getMasterKey() {
return masterKey;
}
@@ -68,6 +78,8 @@ public final class SignalGroupV2Record implements SignalRecord {
private final StorageId id;
private final GroupV2Record.Builder builder;
private byte[] unknownFields;
public Builder(byte[] rawId, GroupMasterKey masterKey) {
this.id = StorageId.forGroupV2(rawId);
this.builder = GroupV2Record.newBuilder();
@@ -75,6 +87,11 @@ public final class SignalGroupV2Record implements SignalRecord {
builder.setMasterKey(ByteString.copyFrom(masterKey.serialize()));
}
public Builder setUnknownFields(byte[] serializedUnknowns) {
this.unknownFields = serializedUnknowns;
return this;
}
public Builder setBlocked(boolean blocked) {
builder.setBlocked(blocked);
return this;
@@ -91,7 +108,13 @@ public final class SignalGroupV2Record implements SignalRecord {
}
public SignalGroupV2Record build() {
return new SignalGroupV2Record(id, builder.build());
GroupV2Record proto = builder.build();
if (unknownFields != null) {
proto = ProtoUtil.combineWithUnknownFields(proto, unknownFields);
}
return new SignalGroupV2Record(id, proto);
}
}
}

View File

@@ -0,0 +1,134 @@
package org.whispersystems.signalservice.api.util;
import com.google.protobuf.CodedOutputStream;
import com.google.protobuf.GeneratedMessageLite;
import com.google.protobuf.InvalidProtocolBufferException;
import com.google.protobuf.UnknownFieldSetLite;
import org.whispersystems.libsignal.logging.Log;
import org.whispersystems.libsignal.util.ByteUtil;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.lang.reflect.Field;
import java.util.LinkedList;
import java.util.List;
public final class ProtoUtil {
private static final String TAG = ProtoUtil.class.getSimpleName();
private static final String DEFAULT_INSTANCE = "DEFAULT_INSTANCE";
private ProtoUtil() { }
/**
* True if there are unknown fields anywhere inside the proto or its nested protos.
*/
@SuppressWarnings("rawtypes")
public static boolean hasUnknownFields(GeneratedMessageLite rootProto) {
try {
List<GeneratedMessageLite> allProtos = getInnerProtos(rootProto);
allProtos.add(rootProto);
for (GeneratedMessageLite proto : allProtos) {
Field field = GeneratedMessageLite.class.getDeclaredField("unknownFields");
field.setAccessible(true);
UnknownFieldSetLite unknownFields = (UnknownFieldSetLite) field.get(proto);
if (unknownFields != null && unknownFields.getSerializedSize() > 0) {
return true;
}
}
} catch (NoSuchFieldException | IllegalAccessException e) {
Log.w(TAG, "Failed to read proto private fields! Assuming no unknown fields.");
}
return false;
}
/**
* This takes two arguments: A proto model, and the bytes of another proto model of the same type.
* This will take the proto model and append onto it any unknown fields from the serialized proto
* model. Why is this useful? Well, if you do {@code myProto.parseFrom(data).toBuilder().build()},
* you will lose any unknown fields that were in {@code data}. This lets you create a new model
* and plop the unknown fields back on from some other instance.
*
* A notable limitation of the current implementation is, however, that it does not support adding
* back unknown fields to *inner* messages. Unknown fields on inner messages will simply not be
* acknowledged.
*/
@SuppressWarnings({"rawtypes", "unchecked"})
public static <Proto extends GeneratedMessageLite> Proto combineWithUnknownFields(Proto proto, byte[] serializedWithUnknownFields) {
if (serializedWithUnknownFields == null) {
return proto;
}
try {
Proto protoWithUnknownFields = (Proto) proto.getParserForType().parseFrom(serializedWithUnknownFields);
byte[] unknownFields = getUnknownFields(protoWithUnknownFields);
if (unknownFields == null) {
return proto;
}
byte[] combined = ByteUtil.combine(proto.toByteArray(), unknownFields);
return (Proto) proto.getParserForType().parseFrom(combined);
} catch (InvalidProtocolBufferException e) {
throw new IllegalArgumentException();
}
}
@SuppressWarnings("rawtypes")
private static byte[] getUnknownFields(GeneratedMessageLite proto) {
try {
Field field = GeneratedMessageLite.class.getDeclaredField("unknownFields");
field.setAccessible(true);
UnknownFieldSetLite unknownFields = (UnknownFieldSetLite) field.get(proto);
if (unknownFields == null || unknownFields.getSerializedSize() == 0) {
return null;
}
ByteArrayOutputStream byteStream = new ByteArrayOutputStream();
CodedOutputStream outputStream = CodedOutputStream.newInstance(byteStream);
unknownFields.writeTo(outputStream);
outputStream.flush();
return byteStream.toByteArray();
} catch (NoSuchFieldException | IllegalAccessException | IOException e) {
Log.w(TAG, "Failed to retrieve unknown fields.", e);
return null;
}
}
/**
* Recursively retrieves all inner complex proto types inside a given proto.
*/
@SuppressWarnings("rawtypes")
private static List<GeneratedMessageLite> getInnerProtos(GeneratedMessageLite proto) {
List<GeneratedMessageLite> innerProtos = new LinkedList<>();
try {
Field[] fields = proto.getClass().getDeclaredFields();
for (Field field : fields) {
if (!field.getName().equals(DEFAULT_INSTANCE) && GeneratedMessageLite.class.isAssignableFrom(field.getType())) {
field.setAccessible(true);
GeneratedMessageLite inner = (GeneratedMessageLite) field.get(proto);
innerProtos.add(inner);
innerProtos.addAll(getInnerProtos(inner));
}
}
} catch (IllegalAccessException e) {
Log.w(TAG, "Failed to get inner protos!", e);
}
return innerProtos;
}
}

View File

@@ -0,0 +1,229 @@
package org.whispersystems.signalservice.api.util;
import com.google.protobuf.InvalidProtocolBufferException;
import org.junit.Assert;
import org.junit.Test;
import org.thoughtcrime.securesms.util.testprotos.TestInnerMessage;
import org.thoughtcrime.securesms.util.testprotos.TestInnerMessageWithNewString;
import org.thoughtcrime.securesms.util.testprotos.TestPerson;
import org.thoughtcrime.securesms.util.testprotos.TestPersonWithNewFieldOnMessage;
import org.thoughtcrime.securesms.util.testprotos.TestPersonWithNewMessage;
import org.thoughtcrime.securesms.util.testprotos.TestPersonWithNewRepeatedString;
import org.thoughtcrime.securesms.util.testprotos.TestPersonWithNewString;
import org.thoughtcrime.securesms.util.testprotos.TestPersonWithNewStringAndInt;
import org.whispersystems.signalservice.api.util.ProtoUtil;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
public class ProtoUtilTest {
@Test
public void hasUnknownFields_noUnknowns() {
TestPerson person = TestPerson.newBuilder()
.setName("Peter Parker")
.setAge(23)
.build();
assertFalse(ProtoUtil.hasUnknownFields(person));
}
@Test
public void hasUnknownFields_unknownString() throws InvalidProtocolBufferException {
TestPersonWithNewString person = TestPersonWithNewString.newBuilder()
.setName("Peter Parker")
.setAge(23)
.setJob("Reporter")
.build();
TestPerson personWithUnknowns = TestPerson.parseFrom(person.toByteArray());
assertTrue(ProtoUtil.hasUnknownFields(personWithUnknowns));
}
@Test
public void hasUnknownFields_multipleUnknowns() throws InvalidProtocolBufferException {
TestPersonWithNewStringAndInt person = TestPersonWithNewStringAndInt.newBuilder()
.setName("Peter Parker")
.setAge(23)
.setJob("Reporter")
.setSalary(75_000)
.build();
TestPerson personWithUnknowns = TestPerson.parseFrom(person.toByteArray());
assertTrue(ProtoUtil.hasUnknownFields(personWithUnknowns));
}
@Test
public void hasUnknownFields_unknownMessage() throws InvalidProtocolBufferException {
TestPersonWithNewMessage person = TestPersonWithNewMessage.newBuilder()
.setName("Peter Parker")
.setAge(23)
.setJob(TestPersonWithNewMessage.Job.newBuilder()
.setTitle("Reporter")
.setSalary(75_000))
.build();
TestPerson personWithUnknowns = TestPerson.parseFrom(person.toByteArray());
assertTrue(ProtoUtil.hasUnknownFields(personWithUnknowns));
}
@Test
public void hasUnknownFields_unknownInsideMessage() throws InvalidProtocolBufferException {
TestPersonWithNewFieldOnMessage person = TestPersonWithNewFieldOnMessage.newBuilder()
.setName("Peter Parker")
.setAge(23)
.setJob(TestPersonWithNewFieldOnMessage.Job.newBuilder()
.setTitle("Reporter")
.setSalary(75_000)
.setStartDate(100))
.build();
TestPersonWithNewMessage personWithUnknowns = TestPersonWithNewMessage.parseFrom(person.toByteArray());
assertTrue(ProtoUtil.hasUnknownFields(personWithUnknowns));
}
@Test
public void combineWithUnknownFields_noUnknowns() throws InvalidProtocolBufferException {
TestPerson personWithUnknowns = TestPerson.newBuilder()
.setName("Peter Parker")
.setAge(23)
.build();
TestPerson localRepresentation = TestPerson.newBuilder()
.setName("Spider-Man")
.setAge(23)
.build();
TestPerson combinedWithUnknowns = ProtoUtil.combineWithUnknownFields(localRepresentation, personWithUnknowns.toByteArray());
TestPersonWithNewString reparsedPerson = TestPersonWithNewString.parseFrom(combinedWithUnknowns.toByteArray());
Assert.assertEquals("Spider-Man", reparsedPerson.getName());
Assert.assertEquals(23, reparsedPerson.getAge());
}
@Test
public void combineWithUnknownFields_appendedString() throws InvalidProtocolBufferException {
TestPersonWithNewString personWithUnknowns = TestPersonWithNewString.newBuilder()
.setName("Peter Parker")
.setAge(23)
.setJob("Reporter")
.build();
TestPerson localRepresentation = TestPerson.newBuilder()
.setName("Spider-Man")
.setAge(23)
.build();
TestPerson combinedWithUnknowns = ProtoUtil.combineWithUnknownFields(localRepresentation, personWithUnknowns.toByteArray());
TestPersonWithNewString reparsedPerson = TestPersonWithNewString.parseFrom(combinedWithUnknowns.toByteArray());
Assert.assertEquals("Spider-Man", reparsedPerson.getName());
Assert.assertEquals(23, reparsedPerson.getAge());
Assert.assertEquals("Reporter", reparsedPerson.getJob());
}
@Test
public void combineWithUnknownFields_appendedRepeatedString() throws InvalidProtocolBufferException {
TestPersonWithNewRepeatedString personWithUnknowns = TestPersonWithNewRepeatedString.newBuilder()
.setName("Peter Parker")
.setAge(23)
.addJobs("Reporter")
.addJobs("Super Hero")
.build();
TestPerson localRepresentation = TestPerson.newBuilder()
.setName("Spider-Man")
.setAge(23)
.build();
TestPerson combinedWithUnknowns = ProtoUtil.combineWithUnknownFields(localRepresentation, personWithUnknowns.toByteArray());
TestPersonWithNewRepeatedString reparsedPerson = TestPersonWithNewRepeatedString.parseFrom(combinedWithUnknowns.toByteArray());
Assert.assertEquals("Spider-Man", reparsedPerson.getName());
Assert.assertEquals(23, reparsedPerson.getAge());
Assert.assertEquals(2, reparsedPerson.getJobsCount());
Assert.assertEquals("Reporter", reparsedPerson.getJobs(0));
Assert.assertEquals("Super Hero", reparsedPerson.getJobs(1));
}
@Test
public void combineWithUnknownFields_appendedStringAndInt() throws InvalidProtocolBufferException {
TestPersonWithNewStringAndInt personWithUnknowns = TestPersonWithNewStringAndInt.newBuilder()
.setName("Peter Parker")
.setAge(23)
.setJob("Reporter")
.setSalary(75_000)
.build();
TestPerson localRepresentation = TestPerson.newBuilder()
.setName("Spider-Man")
.setAge(23)
.build();
TestPerson combinedWithUnknowns = ProtoUtil.combineWithUnknownFields(localRepresentation, personWithUnknowns.toByteArray());
TestPersonWithNewStringAndInt reparsedPerson = TestPersonWithNewStringAndInt.parseFrom(combinedWithUnknowns.toByteArray());
Assert.assertEquals("Spider-Man", reparsedPerson.getName());
Assert.assertEquals(23, reparsedPerson.getAge());
Assert.assertEquals("Reporter", reparsedPerson.getJob());
Assert.assertEquals(75_000, reparsedPerson.getSalary());
}
@Test
public void combineWithUnknownFields_appendedMessage() throws InvalidProtocolBufferException {
TestPersonWithNewMessage personWithUnknowns = TestPersonWithNewMessage.newBuilder()
.setName("Peter Parker")
.setAge(23)
.setJob(TestPersonWithNewMessage.Job.newBuilder()
.setTitle("Reporter")
.setSalary(75_000))
.build();
TestPerson localRepresentation = TestPerson.newBuilder()
.setName("Spider-Man")
.setAge(23)
.build();
TestPerson combinedWithUnknowns = ProtoUtil.combineWithUnknownFields(localRepresentation, personWithUnknowns.toByteArray());
TestPersonWithNewMessage reparsedPerson = TestPersonWithNewMessage.parseFrom(combinedWithUnknowns.toByteArray());
Assert.assertEquals("Spider-Man", reparsedPerson.getName());
Assert.assertEquals(23, reparsedPerson.getAge());
Assert.assertEquals("Reporter", reparsedPerson.getJob().getTitle());
Assert.assertEquals(75_000, reparsedPerson.getJob().getSalary());
}
/**
* This isn't ideal behavior. This is more to show how something works. In the future, it'd be
* nice to support inner unknown fields.
*/
@Test
public void combineWithUnknownFields_innerMessagesUnknownsIgnored() throws InvalidProtocolBufferException {
TestInnerMessageWithNewString test = TestInnerMessageWithNewString.newBuilder()
.setInner(TestInnerMessageWithNewString.Inner.newBuilder()
.setA("a1")
.setB("b1")
.build())
.build();
TestInnerMessage localRepresentation = TestInnerMessage.newBuilder()
.setInner(TestInnerMessage.Inner.newBuilder()
.setA("a2")
.build())
.build();
TestInnerMessage combined = ProtoUtil.combineWithUnknownFields(localRepresentation, test.toByteArray());
TestInnerMessageWithNewString reparsedTest = TestInnerMessageWithNewString.parseFrom(combined.toByteArray());
Assert.assertEquals("a2", reparsedTest.getInner().getA());
Assert.assertEquals("", reparsedTest.getInner().getB());
}
}

View File

@@ -0,0 +1,70 @@
syntax = "proto3";
package signal;
option java_package = "org.thoughtcrime.securesms.util.testprotos";
option java_multiple_files = true;
message TestPerson {
string name = 1;
int32 age = 2;
}
message TestPersonWithNewString {
string name = 1;
int32 age = 2;
string job = 3;
}
message TestPersonWithNewRepeatedString {
string name = 1;
int32 age = 2;
repeated string jobs = 3;
}
message TestPersonWithNewStringAndInt {
string name = 1;
int32 age = 2;
string job = 3;
int32 salary = 4;
}
message TestPersonWithNewMessage {
message Job {
string title = 1;
uint32 salary = 2;
}
string name = 1;
int32 age = 2;
Job job = 3;
}
message TestPersonWithNewFieldOnMessage {
message Job {
string title = 1;
uint32 salary = 2;
uint64 startDate = 3;
}
string name = 1;
int32 age = 2;
Job job = 3;
}
message TestInnerMessage {
message Inner {
string a = 1;
}
Inner inner = 1;
}
message TestInnerMessageWithNewString {
message Inner {
string a = 1;
string b = 2;
}
Inner inner = 1;
}