Add back proper support for unknown recipients.

Fixes #9085

src/org/thoughtcrime/securesms/database/MmsDatabase.java

@@ -1542,7 +1542,7 @@ public class MmsDatabase extends MessagingDatabase {
       List<? extends Attachment> quoteAttachments = Stream.of(attachments).filter(Attachment::isQuote).toList();
       SlideDeck                  quoteDeck        = new SlideDeck(context, quoteAttachments);
 
-      if (quoteId > 0) {
+      if (quoteId > 0 && !quoteAuthor.isUnknown()) {
         return new Quote(quoteId, quoteAuthor, quoteText, quoteMissing, quoteDeck);
       } else {
         return null;

src/org/thoughtcrime/securesms/database/RecipientDatabase.java

@@ -625,9 +625,9 @@ public class RecipientDatabase extends Database {
         } else {
           throw new AssertionError("Failed to insert recipient!");
         }
+      } else {
+        return RecipientId.from(id);
       }
-
-      return RecipientId.from(id);
     }
   }
 

src/org/thoughtcrime/securesms/database/SmsMigrator.java

@@ -221,7 +221,7 @@ public class SmsMigrator {
       while (cursor != null && cursor.moveToNext()) {
         long                theirThreadId   = cursor.getLong(cursor.getColumnIndexOrThrow("_id"));
         String              theirRecipients = cursor.getString(cursor.getColumnIndexOrThrow("recipient_ids"));
-        Set<Recipient>     ourRecipients   = getOurRecipients(context, theirRecipients);
+        Set<Recipient>      ourRecipients   = getOurRecipients(context, theirRecipients);
         ProgressDescription progress        = new ProgressDescription(cursor.getCount(), cursor.getPosition(), 100, 0);
 
         if (ourRecipients != null) {

src/org/thoughtcrime/securesms/database/ThreadDatabase.java

@@ -117,6 +117,10 @@ public class ThreadDatabase extends Database {
   }
 
   private long createThreadForRecipient(@NonNull RecipientId recipientId, boolean group, int distributionType) {
+    if (recipientId.isUnknown()) {
+      throw new AssertionError("Cannot create a thread for an unknown recipient!");
+    }
+
     ContentValues contentValues = new ContentValues(4);
     long date                   = System.currentTimeMillis();
 

src/org/thoughtcrime/securesms/database/loaders/ThreadMediaLoader.java

@@ -24,6 +24,8 @@ public class ThreadMediaLoader extends AbstractCursorLoader {
 
   @Override
   public Cursor getCursor() {
+    if (recipientId.isUnknown()) return null;
+
     long threadId = DatabaseFactory.getThreadDatabase(getContext()).getThreadIdFor(Recipient.resolved(recipientId));
 
     if (gallery) return DatabaseFactory.getMediaDatabase(getContext()).getGalleryMediaForThread(threadId);

src/org/thoughtcrime/securesms/jobs/MmsDownloadJob.java

@@ -212,7 +212,6 @@ public class MmsDownloadJob extends BaseJob {
     if (from != null) {
       members.add(from);
     }
-
     members.add(Recipient.self().getId());
 
     if (retrieved.getBody() != null) {

src/org/thoughtcrime/securesms/notifications/NotificationChannels.java

@@ -140,7 +140,9 @@ public class NotificationChannels {
    * Creates a channel for the specified recipient.
    * @return The channel ID for the newly-created channel.
    */
-  public static synchronized String createChannelFor(@NonNull Context context, @NonNull Recipient recipient) {
+  public static synchronized @Nullable String createChannelFor(@NonNull Context context, @NonNull Recipient recipient) {
+    if (recipient.getId().isUnknown()) return null;
+
     VibrateState vibrateState     = recipient.getMessageVibrate();
     boolean      vibrationEnabled = vibrateState == VibrateState.DEFAULT ? TextSecurePreferences.isNotificationVibrateEnabled(context) : vibrateState == VibrateState.ENABLED;
     Uri          messageRingtone  = recipient.getMessageRingtone() != null ? recipient.getMessageRingtone() : getMessageRingtone(context);
@@ -152,11 +154,11 @@ public class NotificationChannels {
   /**
    * More verbose version of {@link #createChannelFor(Context, Recipient)}.
    */
-  public static synchronized  @Nullable String createChannelFor(@NonNull Context context,
+  public static synchronized @Nullable String createChannelFor(@NonNull Context context,
-                                                                @NonNull Address address,
+                                                               @NonNull Address address,
-                                                                @NonNull String displayName,
+                                                               @NonNull String displayName,
-                                                                @Nullable Uri messageSound,
+                                                               @Nullable Uri messageSound,
-                                                                boolean vibrationEnabled)
+                                                               boolean vibrationEnabled)
   {
     if (!supported()) {
       return null;

src/org/thoughtcrime/securesms/recipients/LiveRecipient.java

@@ -119,7 +119,7 @@ public final class LiveRecipient {
   public @NonNull Recipient resolve() {
     Recipient current = recipient.get();
 
-    if (!current.isResolving()) {
+    if (!current.isResolving() || current.getId().isUnknown()) {
       return current;
     }
 
@@ -150,6 +150,8 @@ public final class LiveRecipient {
    */
   @WorkerThread
   public void refresh() {
+    if (getId().isUnknown()) return;
+
     if (Util.isMainThread()) {
       Log.w(TAG, "[Refresh][MAIN] " + getId(), new Throwable());
     } else {
@@ -189,7 +191,7 @@ public final class LiveRecipient {
 
     if (groupRecord.isPresent()) {
       String          title    = groupRecord.get().getTitle();
-      List<Recipient> members  = Stream.of(groupRecord.get().getMembers()).map(this::fetchRecipientFromDisk).toList();
+      List<Recipient> members  = Stream.of(groupRecord.get().getMembers()).filterNot(RecipientId::isUnknown).map(this::fetchRecipientFromDisk).toList();
       Optional<Long>  avatarId = Optional.absent();
 
       if (!settings.getAddress().isMmsGroup() && title == null) {

src/org/thoughtcrime/securesms/recipients/LiveRecipientCache.java

@@ -23,6 +23,7 @@ public final class LiveRecipientCache {
   private final Context                         context;
   private final RecipientDatabase               recipientDatabase;
   private final Map<RecipientId, LiveRecipient> recipients;
+  private final LiveRecipient                   unknown;
 
   private RecipientId localRecipientId;
 
@@ -31,10 +32,13 @@ public final class LiveRecipientCache {
     this.context           = context.getApplicationContext();
     this.recipientDatabase = DatabaseFactory.getRecipientDatabase(context);
     this.recipients        = new LRUCache<>(1000);
+    this.unknown           = new LiveRecipient(context, new MutableLiveData<>(), Recipient.UNKNOWN);
   }
 
   @AnyThread
   synchronized @NonNull LiveRecipient getLive(@NonNull RecipientId id) {
+    if (id.isUnknown()) return unknown;
+
     LiveRecipient live = recipients.get(id);
 
     if (live == null) {

src/org/thoughtcrime/securesms/recipients/Recipient.java

@@ -44,6 +44,8 @@ import java.util.Objects;
 
 public class Recipient {
 
+  public static final Recipient UNKNOWN = new Recipient(RecipientId.UNKNOWN, new RecipientDetails());
+
   private final RecipientId            id;
   private final boolean                resolving;
   private final Address                address;

src/org/thoughtcrime/securesms/recipients/RecipientDetails.java

@@ -87,4 +87,34 @@ public class RecipientDetails {
     if (name == null) this.name = settings.getSystemDisplayName();
     else              this.name = name;
   }
+
+  public RecipientDetails() {
+    this.groupAvatarId          = null;
+    this.systemContactPhoto     = null;
+    this.customLabel            = null;
+    this.contactUri             = null;
+    this.address                = Address.UNKNOWN;
+    this.color                  = null;
+    this.messageRingtone        = null;
+    this.callRingtone           = null;
+    this.mutedUntil             = 0;
+    this.messageVibrateState    = VibrateState.DEFAULT;
+    this.callVibrateState       = VibrateState.DEFAULT;
+    this.blocked                = false;
+    this.expireMessages         = 0;
+    this.participants           = new LinkedList<>();
+    this.profileName            = null;
+    this.seenInviteReminder     = true;
+    this.defaultSubscriptionId  = Optional.absent();
+    this.registered             = RegisteredState.UNKNOWN;
+    this.profileKey             = null;
+    this.profileAvatar          = null;
+    this.profileSharing         = false;
+    this.systemContact          = true;
+    this.isLocalNumber          = false;
+    this.notificationChannel    = null;
+    this.unidentifiedAccessMode = UnidentifiedAccessMode.UNKNOWN;
+    this.forceSmsSelection      = false;
+    this.name                   = null;
+  }
 }

src/org/thoughtcrime/securesms/recipients/RecipientId.java

@@ -15,7 +15,10 @@ import java.util.List;
 
 public class RecipientId implements Parcelable, Comparable<RecipientId> {
 
-  private static final char DELIMITER = ',';
+  private static final long UNKNOWN_ID = -1;
+  private static final char DELIMITER  = ',';
+
+  public static final RecipientId UNKNOWN = RecipientId.from(UNKNOWN_ID);
 
   private final long id;
 
@@ -51,6 +54,10 @@ public class RecipientId implements Parcelable, Comparable<RecipientId> {
     return out;
   }
 
+  public boolean isUnknown() {
+    return id == UNKNOWN_ID;
+  }
+
   public @NonNull String serialize() {
     return String.valueOf(id);
   }