From 3e166ef92700b61ebaf399eb60d4b2d3f3193336 Mon Sep 17 00:00:00 2001
From: Greyson Parrelli <greyson@signal.org>
Date: Thu, 30 Jul 2020 23:05:09 -0400
Subject: [PATCH] Fix issue where group updates were mis-rendered.

---
 .../org/thoughtcrime/securesms/mms/MessageGroupContext.java   | 4 +++-
 .../main/java/org/thoughtcrime/securesms/util/GroupUtil.java  | 2 +-
 .../main/java/org/thoughtcrime/securesms/util/StringUtil.java | 4 ++++
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/org/thoughtcrime/securesms/mms/MessageGroupContext.java b/app/src/main/java/org/thoughtcrime/securesms/mms/MessageGroupContext.java
index 9083b79454..c2b4c8b19e 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/mms/MessageGroupContext.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/mms/MessageGroupContext.java
@@ -128,7 +128,9 @@ public final class MessageGroupContext {
     public @NonNull List<RecipientId> getMembersListExcludingSelf() {
       RecipientId selfId = Recipient.self().getId();
 
-      return Stream.of(groupContext.getMembersE164List())
+      return Stream.of(groupContext.getMembersList())
+                   .map(GroupContext.Member::getE164)
+                   .withoutNulls()
                    .map(e164 -> new SignalServiceAddress(null, e164))
                    .map(RecipientId::from)
                    .filterNot(selfId::equals)
diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/GroupUtil.java b/app/src/main/java/org/thoughtcrime/securesms/util/GroupUtil.java
index 8cece8d996..73da984d02 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/util/GroupUtil.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/util/GroupUtil.java
@@ -133,7 +133,7 @@ public final class GroupUtil {
                                                                     members.size(), toString(members)));
       }
 
-      if (title != null && !title.trim().isEmpty()) {
+      if (!title.trim().isEmpty()) {
         if (members != null) description.append(" ");
         else                 description.append("\n");
         description.append(context.getString(R.string.GroupUtil_group_name_is_now, title));
diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/StringUtil.java b/app/src/main/java/org/thoughtcrime/securesms/util/StringUtil.java
index 986b8da9e8..779bf39619 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/util/StringUtil.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/util/StringUtil.java
@@ -137,6 +137,10 @@ public final class StringUtil {
    * https://www.w3.org/International/questions/qa-bidi-unicode-controls
    */
   public static @NonNull String isolateBidi(@NonNull String text) {
+    if (text.isEmpty()) {
+      return text;
+    }
+
     int overrideCount      = 0;
     int overrideCloseCount = 0;
     int isolateCount       = 0;