Fix bug related to gallery selection state.

TreeSets are annoying. contains() is calculated with the comparator,
which can lead to some weird bugs. Made sure the comparator didn't think
two items with the same date were identical.

Also fixed stableId generation to avoid any potential weirdness there.
This commit is contained in:
Greyson Parrelli
2019-01-14 15:40:38 -08:00
parent 5450967d00
commit 4952b4470d
3 changed files with 66 additions and 21 deletions

View File

@@ -0,0 +1,31 @@
package org.thoughtcrime.securesms.util;
import android.support.annotation.MainThread;
import android.support.annotation.NonNull;
import java.util.HashMap;
import java.util.Map;
/**
* Useful for generate ID's to be used with
* {@link android.support.v7.widget.RecyclerView.Adapter#getItemId(int)} when you otherwise don't
* have a good way to generate an ID.
*/
public class StableIdGenerator<E> {
private final Map<E, Long> keys = new HashMap<>();
private long index = 1;
@MainThread
public long getId(@NonNull E item) {
if (keys.containsKey(item)) {
return keys.get(item);
}
long key = index++;
keys.put(item, key);
return key;
}
}