From 4b939358e9f257c092af7b02057f7b532b6381d3 Mon Sep 17 00:00:00 2001 From: Anton Chekulaev Date: Wed, 2 Sep 2020 12:47:56 +1000 Subject: [PATCH] Themes & styles cleanup. --- AndroidManifest.xml | 29 +- res/layout/conversation_input_panel.xml | 2 +- res/layout/mediasend_fragment.xml | 2 +- res/values-notnight-v21/themes.xml | 5 +- res/values/styles.xml | 63 +-- res/values/themes.xml | 359 +----------------- .../securesms/CreateProfileActivity.java | 5 - .../securesms/PassphrasePromptActivity.java | 4 - .../lock/RegistrationLockDialog.java | 2 +- .../mediasend/MediaSendFragment.java | 3 +- .../permissions/RationaleDialog.java | 2 +- .../securesms/util/DynamicIntroTheme.java | 16 - .../util/DynamicRegistrationTheme.java | 12 - .../securesms/util/DynamicTheme.java | 4 +- 14 files changed, 73 insertions(+), 435 deletions(-) delete mode 100644 src/org/thoughtcrime/securesms/util/DynamicIntroTheme.java delete mode 100644 src/org/thoughtcrime/securesms/util/DynamicRegistrationTheme.java diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 67a18de2a0..0a6f5f9ace 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -173,7 +173,6 @@ android:name="org.thoughtcrime.securesms.InviteActivity" android:configChanges="touchscreen|keyboard|keyboardHidden|orientation|screenLayout|screenSize" android:parentActivityName="org.thoughtcrime.securesms.loki.activities.HomeActivity" - android:theme="@style/TextSecure.HighlightTheme" android:windowSoftInputMode="stateHidden"> @@ -296,7 +295,6 @@ android:excludeFromRecents="true" android:launchMode="singleTask" android:taskAffinity="" - android:theme="@style/TextSecure.LightTheme.Popup" android:windowSoftInputMode="stateVisible" /> + android:launchMode="singleTask" /> + android:theme="@style/Theme.Session.DayNight.NoActionBar" /> + android:configChanges="touchscreen|keyboard|keyboardHidden|orientation|screenLayout|screenSize" /> + android:configChanges="touchscreen|keyboard|keyboardHidden|orientation|screenLayout|screenSize" /> + android:theme="@style/Theme.Session.DayNight.NoActionBar" /> + android:theme="@style/Theme.Session.DayNight.NoActionBar" /> + android:theme="@style/Theme.Session.DayNight.NoActionBar" /> - + + - - - @@ -112,6 +112,30 @@ @android:color/white + + + + - - - - + + diff --git a/res/values/themes.xml b/res/values/themes.xml index f8f749f0bb..5f35982520 100644 --- a/res/values/themes.xml +++ b/res/values/themes.xml @@ -3,7 +3,10 @@ - - @@ -101,10 +102,9 @@ @style/Widget.Session.ActionBar.Flat - - - - + - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/src/org/thoughtcrime/securesms/CreateProfileActivity.java b/src/org/thoughtcrime/securesms/CreateProfileActivity.java index 92d631f576..1c9af4f4c6 100644 --- a/src/org/thoughtcrime/securesms/CreateProfileActivity.java +++ b/src/org/thoughtcrime/securesms/CreateProfileActivity.java @@ -48,8 +48,6 @@ import org.thoughtcrime.securesms.profiles.SystemProfileUtil; import org.thoughtcrime.securesms.util.BitmapDecodingException; import org.thoughtcrime.securesms.util.BitmapUtil; import org.thoughtcrime.securesms.util.DynamicLanguage; -import org.thoughtcrime.securesms.util.DynamicRegistrationTheme; -import org.thoughtcrime.securesms.util.DynamicTheme; import org.thoughtcrime.securesms.util.TextSecurePreferences; import org.thoughtcrime.securesms.util.Util; import org.thoughtcrime.securesms.util.ViewUtil; @@ -85,7 +83,6 @@ public class CreateProfileActivity extends BaseActionBarActivity implements Inje public static final String NEXT_INTENT = "next_intent"; public static final String EXCLUDE_SYSTEM = "exclude_system"; - private final DynamicTheme dynamicTheme = new DynamicRegistrationTheme(); private final DynamicLanguage dynamicLanguage = new DynamicLanguage(); @Inject SignalServiceAccountManager accountManager; @@ -107,7 +104,6 @@ public class CreateProfileActivity extends BaseActionBarActivity implements Inje public void onCreate(Bundle bundle) { super.onCreate(bundle); - dynamicTheme.onCreate(this); dynamicLanguage.onCreate(this); setContentView(R.layout.profile_create_activity); @@ -125,7 +121,6 @@ public class CreateProfileActivity extends BaseActionBarActivity implements Inje @Override public void onResume() { super.onResume(); - dynamicTheme.onResume(this); dynamicLanguage.onResume(this); } diff --git a/src/org/thoughtcrime/securesms/PassphrasePromptActivity.java b/src/org/thoughtcrime/securesms/PassphrasePromptActivity.java index f4e881c057..1e8f089d72 100644 --- a/src/org/thoughtcrime/securesms/PassphrasePromptActivity.java +++ b/src/org/thoughtcrime/securesms/PassphrasePromptActivity.java @@ -55,7 +55,6 @@ import org.thoughtcrime.securesms.crypto.InvalidPassphraseException; import org.thoughtcrime.securesms.crypto.MasterSecret; import org.thoughtcrime.securesms.crypto.MasterSecretUtil; import org.thoughtcrime.securesms.logging.Log; -import org.thoughtcrime.securesms.util.DynamicIntroTheme; import org.thoughtcrime.securesms.util.DynamicLanguage; import org.thoughtcrime.securesms.util.TextSecurePreferences; @@ -70,7 +69,6 @@ public class PassphrasePromptActivity extends PassphraseActivity { private static final String TAG = PassphrasePromptActivity.class.getSimpleName(); - private DynamicIntroTheme dynamicTheme = new DynamicIntroTheme(); private DynamicLanguage dynamicLanguage = new DynamicLanguage(); private View passphraseAuthContainer; @@ -92,7 +90,6 @@ public class PassphrasePromptActivity extends PassphraseActivity { @Override public void onCreate(Bundle savedInstanceState) { Log.i(TAG, "onCreate()"); - dynamicTheme.onCreate(this); dynamicLanguage.onCreate(this); getWindow().addFlags(WindowManager.LayoutParams.FLAG_TRANSLUCENT_STATUS); getWindow().addFlags(WindowManager.LayoutParams.FLAG_TRANSLUCENT_NAVIGATION); @@ -105,7 +102,6 @@ public class PassphrasePromptActivity extends PassphraseActivity { @Override public void onResume() { super.onResume(); - dynamicTheme.onResume(this); dynamicLanguage.onResume(this); setLockTypeVisibility(); diff --git a/src/org/thoughtcrime/securesms/lock/RegistrationLockDialog.java b/src/org/thoughtcrime/securesms/lock/RegistrationLockDialog.java index 7dc4f2c296..44e109ff37 100644 --- a/src/org/thoughtcrime/securesms/lock/RegistrationLockDialog.java +++ b/src/org/thoughtcrime/securesms/lock/RegistrationLockDialog.java @@ -45,7 +45,7 @@ public class RegistrationLockDialog { if (!RegistrationLockReminders.needsReminder(context)) return; if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) return; - AlertDialog dialog = new AlertDialog.Builder(context, R.style.RationaleDialog) + AlertDialog dialog = new AlertDialog.Builder(context, R.style.Theme_TextSecure_Dialog_Rationale) .setView(R.layout.registration_lock_reminder_view) .setCancelable(true) .setOnCancelListener(d -> RegistrationLockReminders.scheduleReminder(context, false)) diff --git a/src/org/thoughtcrime/securesms/mediasend/MediaSendFragment.java b/src/org/thoughtcrime/securesms/mediasend/MediaSendFragment.java index 219252d6ef..a563f3546f 100644 --- a/src/org/thoughtcrime/securesms/mediasend/MediaSendFragment.java +++ b/src/org/thoughtcrime/securesms/mediasend/MediaSendFragment.java @@ -49,7 +49,6 @@ import org.thoughtcrime.securesms.util.CharacterCalculator.CharacterState; import org.thoughtcrime.securesms.util.MediaUtil; import org.thoughtcrime.securesms.util.Stopwatch; import org.thoughtcrime.securesms.util.TextSecurePreferences; -import org.thoughtcrime.securesms.util.ThemeUtil; import org.thoughtcrime.securesms.util.Util; import org.thoughtcrime.securesms.util.concurrent.ListenableFuture; import org.thoughtcrime.securesms.util.concurrent.SettableFuture; @@ -448,7 +447,7 @@ public class MediaSendFragment extends Fragment implements ViewTreeObserver.OnGl protected void onPreExecute() { renderTimer = new Stopwatch("ProcessMedia"); progressTimer = () -> { - dialog = new AlertDialog.Builder(new ContextThemeWrapper(requireContext(), R.style.TextSecure_MediaSendProgressDialog)) + dialog = new AlertDialog.Builder(new ContextThemeWrapper(requireContext(), R.style.Theme_TextSecure_Dialog_MediaSendProgress)) .setView(R.layout.progress_dialog) .setCancelable(false) .create(); diff --git a/src/org/thoughtcrime/securesms/permissions/RationaleDialog.java b/src/org/thoughtcrime/securesms/permissions/RationaleDialog.java index ccacd0873f..135cf6c077 100644 --- a/src/org/thoughtcrime/securesms/permissions/RationaleDialog.java +++ b/src/org/thoughtcrime/securesms/permissions/RationaleDialog.java @@ -47,7 +47,7 @@ public class RationaleDialog { text.setText(message); - return new AlertDialog.Builder(context, R.style.RationaleDialog).setView(view); + return new AlertDialog.Builder(context, R.style.Theme_TextSecure_Dialog_Rationale).setView(view); } } diff --git a/src/org/thoughtcrime/securesms/util/DynamicIntroTheme.java b/src/org/thoughtcrime/securesms/util/DynamicIntroTheme.java deleted file mode 100644 index ee5d82968c..0000000000 --- a/src/org/thoughtcrime/securesms/util/DynamicIntroTheme.java +++ /dev/null @@ -1,16 +0,0 @@ -package org.thoughtcrime.securesms.util; - -import android.app.Activity; - -import network.loki.messenger.R; - -public class DynamicIntroTheme extends DynamicTheme { - @Override - protected int getSelectedTheme(Activity activity) { - String theme = TextSecurePreferences.getTheme(activity); - - if (theme.equals("dark")) return R.style.TextSecure_DarkIntroTheme; - - return R.style.TextSecure_LightIntroTheme; - } -} diff --git a/src/org/thoughtcrime/securesms/util/DynamicRegistrationTheme.java b/src/org/thoughtcrime/securesms/util/DynamicRegistrationTheme.java deleted file mode 100644 index e4eebc15a0..0000000000 --- a/src/org/thoughtcrime/securesms/util/DynamicRegistrationTheme.java +++ /dev/null @@ -1,12 +0,0 @@ -package org.thoughtcrime.securesms.util; - -import android.app.Activity; - -import network.loki.messenger.R; - -public class DynamicRegistrationTheme extends DynamicTheme { - @Override - protected int getSelectedTheme(Activity activity) { - return R.style.TextSecure_DarkRegistrationTheme; - } -} diff --git a/src/org/thoughtcrime/securesms/util/DynamicTheme.java b/src/org/thoughtcrime/securesms/util/DynamicTheme.java index 346604e139..5668b310f6 100644 --- a/src/org/thoughtcrime/securesms/util/DynamicTheme.java +++ b/src/org/thoughtcrime/securesms/util/DynamicTheme.java @@ -6,7 +6,9 @@ import android.content.Intent; import network.loki.messenger.R; /** - * @deprecated Use conventional DayNight app themes to support dark/light modes. + * @deprecated Use one of the Theme.Session.DayNight.* + * (or Theme.TextSecure.DayNight.* for old Signal activities) + * app themes to support dark/light modes. */ @Deprecated public class DynamicTheme {