From 4fb8d1fa49a6b080bbd1d5e324536e28c2ed5af2 Mon Sep 17 00:00:00 2001 From: Moxie Marlinspike Date: Sun, 29 Jan 2017 13:16:10 -0800 Subject: [PATCH] Fix for NPE when MMS From is absent Fixes #6115 // FREEBIE --- src/org/thoughtcrime/securesms/database/MmsDatabase.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/org/thoughtcrime/securesms/database/MmsDatabase.java b/src/org/thoughtcrime/securesms/database/MmsDatabase.java index 9c186c7104..7075107c5f 100644 --- a/src/org/thoughtcrime/securesms/database/MmsDatabase.java +++ b/src/org/thoughtcrime/securesms/database/MmsDatabase.java @@ -832,7 +832,10 @@ public class MmsDatabase extends MessagingDatabase { contentValues.put(DATE_SENT, contentValues.getAsLong(DATE_RECEIVED)); long messageId = db.insert(TABLE_NAME, null, contentValues); - addressDatabase.insertAddressesForId(messageId, MmsAddresses.forFrom(Util.toIsoString(notification.getFrom().getTextString()))); + + if (headers.getEncodedStringValue(PduHeaders.FROM) != null) { + addressDatabase.insertAddressesForId(messageId, MmsAddresses.forFrom(Util.toIsoString(notification.getFrom().getTextString()))); + } return new Pair<>(messageId, threadId); }