From 6455c66a0b4bd7dee683ea9b12d733290849c892 Mon Sep 17 00:00:00 2001 From: Moxie Marlinspike Date: Wed, 6 Sep 2017 17:54:32 -0700 Subject: [PATCH] Fix bug that prevented selecting insecure SMS Fixes #6929 // FREEBIE --- .../securesms/ConversationActivity.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/org/thoughtcrime/securesms/ConversationActivity.java b/src/org/thoughtcrime/securesms/ConversationActivity.java index a46f7046b3..ef1b1292e9 100644 --- a/src/org/thoughtcrime/securesms/ConversationActivity.java +++ b/src/org/thoughtcrime/securesms/ConversationActivity.java @@ -238,8 +238,9 @@ public class ConversationActivity extends PassphraseRequiredActionBarActivity private int distributionType; private boolean archived; private boolean isSecureText; - private boolean isDefaultSms = true; - private boolean isMmsEnabled = true; + private boolean isDefaultSms = true; + private boolean isMmsEnabled = true; + private boolean isSecurityInitialized = false; private final IdentityRecordList identityRecords = new IdentityRecordList(); private final DynamicTheme dynamicTheme = new DynamicTheme(); @@ -918,8 +919,13 @@ public class ConversationActivity extends PassphraseRequiredActionBarActivity } private void handleSecurityChange(boolean isSecureText, boolean isDefaultSms) { - this.isSecureText = isSecureText; - this.isDefaultSms = isDefaultSms; + if (isSecurityInitialized && isSecureText == this.isSecureText && isDefaultSms == this.isDefaultSms) { + return; + } + + this.isSecureText = isSecureText; + this.isDefaultSms = isDefaultSms; + this.isSecurityInitialized = true; boolean isMediaMessage = recipient.isMmsGroupRecipient() || attachmentManager.isAttachmentPresent();