Message details activity styling fixes.

Message details activity is available form the conversation context menu.

src/org/thoughtcrime/securesms/MessageDetailsActivity.java

@@ -24,10 +24,6 @@ import android.database.Cursor;
 import android.graphics.drawable.ColorDrawable;
 import android.os.AsyncTask;
 import android.os.Bundle;
-import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-import androidx.loader.app.LoaderManager.LoaderCallbacks;
-import androidx.loader.content.Loader;
 import android.view.LayoutInflater;
 import android.view.MenuItem;
 import android.view.View;
@@ -35,6 +31,11 @@ import android.view.ViewGroup;
 import android.widget.ListView;
 import android.widget.TextView;
 
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
+import androidx.loader.app.LoaderManager.LoaderCallbacks;
+import androidx.loader.content.Loader;
+
 import org.thoughtcrime.securesms.MessageDetailsRecipientAdapter.RecipientDeliveryStatus;
 import org.thoughtcrime.securesms.color.MaterialColor;
 import org.thoughtcrime.securesms.conversation.ConversationItem;
@@ -55,7 +56,6 @@ import org.thoughtcrime.securesms.recipients.RecipientModifiedListener;
 import org.thoughtcrime.securesms.sms.MessageSender;
 import org.thoughtcrime.securesms.util.DateUtils;
 import org.thoughtcrime.securesms.util.DynamicLanguage;
-import org.thoughtcrime.securesms.util.DynamicTheme;
 import org.thoughtcrime.securesms.util.ExpirationUtil;
 import org.thoughtcrime.securesms.util.Util;
 import org.whispersystems.libsignal.util.guava.Optional;
@@ -100,14 +100,12 @@ public class MessageDetailsActivity extends PassphraseRequiredActionBarActivity
   private ListView         recipientsList;
   private LayoutInflater   inflater;
 
-  private DynamicTheme     dynamicTheme    = new DynamicTheme();
   private DynamicLanguage  dynamicLanguage = new DynamicLanguage();
 
   private boolean running;
 
   @Override
   protected void onPreCreate() {
-    dynamicTheme.onCreate(this);
     dynamicLanguage.onCreate(this);
   }
 
@@ -119,14 +117,12 @@ public class MessageDetailsActivity extends PassphraseRequiredActionBarActivity
 
     initializeResources();
     initializeActionBar();
-    getWindow().setNavigationBarColor(getResources().getColor(R.color.navigation_bar_background));
     getSupportLoaderManager().initLoader(0, null, this);
   }
 
   @Override
   protected void onResume() {
     super.onResume();
-    dynamicTheme.onResume(this);
     dynamicLanguage.onResume(this);
 
     assert getSupportActionBar() != null;

src/org/thoughtcrime/securesms/ShareActivity.java

@@ -103,8 +103,6 @@ public class ShareActivity extends PassphraseRequiredActionBarActivity
     initializeResources();
     initializeSearch();
     initializeMedia();
-
-    getWindow().setNavigationBarColor(getResources().getColor(R.color.navigation_bar_background));
   }
 
   @Override

src/org/thoughtcrime/securesms/components/AvatarImageView.java

@@ -6,6 +6,7 @@ import android.graphics.Canvas;
 import android.graphics.Color;
 import android.graphics.Outline;
 import android.graphics.Paint;
+import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.Drawable;
 import android.provider.ContactsContract;
 import androidx.annotation.NonNull;
@@ -21,6 +22,7 @@ import org.thoughtcrime.securesms.contacts.avatars.ContactColors;
 import org.thoughtcrime.securesms.contacts.avatars.ContactPhoto;
 import org.thoughtcrime.securesms.contacts.avatars.ResourceContactPhoto;
 import org.thoughtcrime.securesms.database.Address;
+import org.thoughtcrime.securesms.loki.utilities.AvatarPlaceholderGenerator;
 import org.thoughtcrime.securesms.mms.GlideApp;
 import org.thoughtcrime.securesms.mms.GlideRequests;
 import org.thoughtcrime.securesms.recipients.Recipient;
@@ -128,17 +130,21 @@ public class AvatarImageView extends AppCompatImageView {
           requestManager.clear(this);
           recipientContactPhoto = photo;
 
-          Drawable fallbackContactPhotoDrawable = photo.recipient.getFallbackContactPhotoDrawable(getContext(), inverted);
+          Drawable photoPlaceholderDrawable = AvatarPlaceholderGenerator.generate(
+                  getContext(), 128, recipient.getAddress().serialize(), recipient.getName());
 
           if (photo.contactPhoto != null) {
             requestManager.load(photo.contactPhoto)
-                          .fallback(fallbackContactPhotoDrawable)
-                          .error(fallbackContactPhotoDrawable)
+                          .fallback(photoPlaceholderDrawable)
+                          .error(photoPlaceholderDrawable)
                           .diskCacheStrategy(DiskCacheStrategy.ALL)
                           .circleCrop()
                           .into(this);
           } else {
-            setImageDrawable(fallbackContactPhotoDrawable);
+            requestManager.load(photoPlaceholderDrawable)
+                    .circleCrop()
+                    .into(this);
+//            setImageDrawable(photoPlaceholderDrawable);
           }
         }
       }

src/org/thoughtcrime/securesms/conversation/ConversationFragment.java

@@ -374,12 +374,14 @@ public class ConversationFragment extends Fragment
     }
 
     if (messageRecords.size() > 1) {
+      menu.findItem(R.id.menu_context_details).setVisible(false);
       menu.findItem(R.id.menu_context_reply).setVisible(false);
       menu.findItem(R.id.menu_context_save_attachment).setVisible(false);
       menu.findItem(R.id.menu_context_resend).setVisible(false);
     } else {
       MessageRecord messageRecord = messageRecords.iterator().next();
 
+      menu.findItem(R.id.menu_context_details).setVisible(true);
       menu.findItem(R.id.menu_context_resend).setVisible(messageRecord.isFailed());
       menu.findItem(R.id.menu_context_save_attachment).setVisible(!actionMessage                                              &&
                                                                   messageRecord.isMms()                                       &&
@@ -1126,16 +1128,14 @@ public class ConversationFragment extends Fragment
           handleDeleteMessages(getListAdapter().getSelectedItems());
           actionMode.finish();
           return true;
-        /*
         case R.id.menu_context_details:
           handleDisplayDetails(getSelectedMessageRecord());
           actionMode.finish();
           return true;
-        case R.id.menu_context_forward:
-          handleForwardMessage(getSelectedMessageRecord());
-          actionMode.finish();
-          return true;
-         */
+//        case R.id.menu_context_forward:
+//          handleForwardMessage(getSelectedMessageRecord());
+//          actionMode.finish();
+//          return true;
         case R.id.menu_context_resend:
           handleResendMessage(getSelectedMessageRecord());
           actionMode.finish();

src/org/thoughtcrime/securesms/loki/utilities/AvatarPlaceholderGenerator.kt

@@ -15,6 +15,7 @@ object AvatarPlaceholderGenerator {
 
     private const val EMPTY_LABEL = "0";
 
+    @JvmStatic
     fun generate(context: Context, pixelSize: Int, hashString: String, displayName: String?): BitmapDrawable {
         //TODO That should be replaced with a proper hash extraction code.
         val hash: Long

src/org/thoughtcrime/securesms/notifications/SingleRecipientNotificationBuilder.java

@@ -326,6 +326,6 @@ public class SingleRecipientNotificationBuilder extends AbstractNotificationBuil
             ? TextSecurePreferences.getMasterHexEncodedPublicKey(context)
             : publicKey;
     String displayName = recipient.getName();
-    return AvatarPlaceholderGenerator.INSTANCE.generate(context, 128, hepk, displayName);
+    return AvatarPlaceholderGenerator.generate(context, 128, hepk, displayName);
   }
 }