disambiguate send

This commit is contained in:
Moxie Marlinspike 2012-10-31 18:00:59 -07:00
parent f26dbb2f34
commit 6b18f66e19

View File

@ -19,7 +19,6 @@ package org.thoughtcrime.securesms.mms;
import android.content.Context; import android.content.Context;
import android.util.Log; import android.util.Log;
import org.apache.http.HttpHost;
import org.apache.http.HttpResponse; import org.apache.http.HttpResponse;
import org.apache.http.StatusLine; import org.apache.http.StatusLine;
import org.apache.http.client.ClientProtocolException; import org.apache.http.client.ClientProtocolException;
@ -30,17 +29,12 @@ import org.apache.http.entity.ByteArrayEntity;
import ws.com.google.android.mms.MmsException; import ws.com.google.android.mms.MmsException;
import java.io.IOException; import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
public class MmsSendHelper extends MmsCommunication { public class MmsSendHelper extends MmsCommunication {
private static byte[] makePost(MmsConnectionParameters parameters, byte[] mms) throws ClientProtocolException, IOException { private static byte[] makePost(MmsConnectionParameters parameters, byte[] mms) throws ClientProtocolException, IOException {
Log.w("MmsSender", "Sending MMS1 of length: " + mms.length); Log.w("MmsSender", "Sending MMS1 of length: " + mms.length);
try {
HttpClient client = constructHttpClient(parameters); HttpClient client = constructHttpClient(parameters);
URI hostUrl = new URI(parameters.getMmsc());
HttpHost target = new HttpHost(hostUrl.getHost(), hostUrl.getPort(), HttpHost.DEFAULT_SCHEME_NAME);
HttpPost request = new HttpPost(parameters.getMmsc()); HttpPost request = new HttpPost(parameters.getMmsc());
ByteArrayEntity entity = new ByteArrayEntity(mms); ByteArrayEntity entity = new ByteArrayEntity(mms);
@ -50,17 +44,13 @@ public class MmsSendHelper extends MmsCommunication {
request.setParams(client.getParams()); request.setParams(client.getParams());
request.addHeader("Accept", "*/*, application/vnd.wap.mms-message, application/vnd.wap.sic"); request.addHeader("Accept", "*/*, application/vnd.wap.mms-message, application/vnd.wap.sic");
HttpResponse response = client.execute(target, request); HttpResponse response = client.execute(request);
StatusLine status = response.getStatusLine(); StatusLine status = response.getStatusLine();
if (status.getStatusCode() != 200) if (status.getStatusCode() != 200)
throw new IOException("Non-successful HTTP response: " + status.getReasonPhrase()); throw new IOException("Non-successful HTTP response: " + status.getReasonPhrase());
return parseResponse(response.getEntity()); return parseResponse(response.getEntity());
} catch (URISyntaxException use) {
Log.w("MmsDownlader", use);
throw new IOException("Bad URI syntax");
}
} }
public static byte[] sendMms(Context context, byte[] mms, String apn) throws IOException { public static byte[] sendMms(Context context, byte[] mms, String apn) throws IOException {