Merge pull request #155 from loki-project/multi-device

Improve Threading & Ditch Long Polling

AndroidManifest.xml

@@ -666,7 +666,7 @@
                 <action android:name="android.intent.action.BOOT_COMPLETED" />
             </intent-filter>
         </receiver>
-        <receiver android:name="org.thoughtcrime.securesms.loki.redesign.messaging.BackgroundPublicChatPollWorker">
+        <receiver android:name="org.thoughtcrime.securesms.loki.redesign.messaging.BackgroundOpenGroupPollWorker">
             <intent-filter>
                 <action android:name="android.intent.action.BOOT_COMPLETED" />
             </intent-filter>

src/org/thoughtcrime/securesms/ApplicationContext.java

@@ -63,8 +63,8 @@ import org.thoughtcrime.securesms.logging.UncaughtExceptionLogger;
 import org.thoughtcrime.securesms.loki.LokiPublicChatManager;
 import org.thoughtcrime.securesms.loki.MultiDeviceUtilities;
 import org.thoughtcrime.securesms.loki.redesign.activities.HomeActivity;
+import org.thoughtcrime.securesms.loki.redesign.messaging.BackgroundOpenGroupPollWorker;
 import org.thoughtcrime.securesms.loki.redesign.messaging.BackgroundPollWorker;
-import org.thoughtcrime.securesms.loki.redesign.messaging.BackgroundPublicChatPollWorker;
 import org.thoughtcrime.securesms.loki.redesign.messaging.LokiAPIDatabase;
 import org.thoughtcrime.securesms.loki.redesign.messaging.LokiRSSFeedPoller;
 import org.thoughtcrime.securesms.loki.redesign.messaging.LokiUserDatabase;
@@ -94,9 +94,9 @@ import org.whispersystems.signalservice.api.util.StreamDetails;
 import org.whispersystems.signalservice.internal.push.SignalServiceProtos;
 import org.whispersystems.signalservice.loki.api.LokiAPIDatabaseProtocol;
 import org.whispersystems.signalservice.loki.api.LokiFileServerAPI;
-import org.whispersystems.signalservice.loki.api.LokiLongPoller;
 import org.whispersystems.signalservice.loki.api.LokiP2PAPI;
 import org.whispersystems.signalservice.loki.api.LokiP2PAPIDelegate;
+import org.whispersystems.signalservice.loki.api.LokiPoller;
 import org.whispersystems.signalservice.loki.api.LokiPublicChat;
 import org.whispersystems.signalservice.loki.api.LokiPublicChatAPI;
 import org.whispersystems.signalservice.loki.api.LokiRSSFeed;
@@ -140,7 +140,7 @@ public class ApplicationContext extends MultiDexApplication implements Dependenc
   private PersistentLogger        persistentLogger;
 
   // Loki
-  private LokiLongPoller lokiLongPoller = null;
+  private LokiPoller lokiPoller = null;
   private LokiRSSFeedPoller lokiNewsFeedPoller = null;
   private LokiRSSFeedPoller lokiMessengerUpdatesFeedPoller = null;
   private LokiPublicChatManager lokiPublicChatManager = null;
@@ -205,8 +205,8 @@ public class ApplicationContext extends MultiDexApplication implements Dependenc
     Log.i(TAG, "App is now visible.");
     executePendingContactSync();
     KeyCachingService.onAppForegrounded(this);
-    // Loki - Start long polling if needed
+    // Loki - Start polling if needed
-    startLongPollingIfNeeded();
+    startPollingIfNeeded();
     // Loki - Start open group polling if needed
     lokiPublicChatManager.startPollersIfNeeded();
   }
@@ -217,8 +217,8 @@ public class ApplicationContext extends MultiDexApplication implements Dependenc
     Log.i(TAG, "App is no longer visible.");
     KeyCachingService.onAppBackgrounded(this);
     MessageNotifier.setVisibleThread(-1);
-    // Loki - Stop long polling if needed
+    // Loki - Stop polling if needed
-    if (lokiLongPoller != null) { lokiLongPoller.stopIfNeeded(); }
+    if (lokiPoller != null) { lokiPoller.stopIfNeeded(); }
     if (lokiPublicChatManager != null) { lokiPublicChatManager.stopPollers(); }
   }
 
@@ -355,7 +355,7 @@ public class ApplicationContext extends MultiDexApplication implements Dependenc
     LocalBackupListener.schedule(this);
     RotateSenderCertificateListener.schedule(this);
     BackgroundPollWorker.schedule(this); // Session
-    BackgroundPublicChatPollWorker.schedule(this); // Session
+    BackgroundOpenGroupPollWorker.schedule(this); // Session
 
     if (BuildConfig.PLAY_STORE_DISABLED) {
       UpdateApkRefreshListener.schedule(this);
@@ -458,13 +458,13 @@ public class ApplicationContext extends MultiDexApplication implements Dependenc
     // TODO: Implement
   }
 
-  private void setUpLongPollingIfNeeded() {
+  private void setUpPollingIfNeeded() {
-    if (lokiLongPoller != null) return;
+    if (lokiPoller != null) return;
     String userHexEncodedPublicKey = TextSecurePreferences.getLocalNumber(this);
     if (userHexEncodedPublicKey == null) return;
     LokiAPIDatabase lokiAPIDatabase = DatabaseFactory.getLokiAPIDatabase(this);
     Context context = this;
-    lokiLongPoller = new LokiLongPoller(userHexEncodedPublicKey, lokiAPIDatabase, broadcaster, protos -> {
+    lokiPoller = new LokiPoller(userHexEncodedPublicKey, lokiAPIDatabase, broadcaster, protos -> {
       for (SignalServiceProtos.Envelope proto : protos) {
         new PushContentReceiveJob(context).processEnvelope(new SignalServiceEnvelope(proto));
       }
@@ -472,9 +472,9 @@ public class ApplicationContext extends MultiDexApplication implements Dependenc
     });
   }
 
-  public void startLongPollingIfNeeded() {
+  public void startPollingIfNeeded() {
-    setUpLongPollingIfNeeded();
+    setUpPollingIfNeeded();
-    if (lokiLongPoller != null) { lokiLongPoller.startIfNeeded(); }
+    if (lokiPoller != null) { lokiPoller.startIfNeeded(); }
   }
 
   private LokiRSSFeed lokiNewsFeed() {

src/org/thoughtcrime/securesms/loki/redesign/activities/HomeActivity.kt

@@ -78,7 +78,7 @@ class HomeActivity : PassphraseRequiredActionBarActivity, ConversationClickListe
             }
         }
         // Double check that the long poller is up
-        (applicationContext as ApplicationContext).startLongPollingIfNeeded()
+        (applicationContext as ApplicationContext).startPollingIfNeeded()
         // Set content view
         setContentView(R.layout.activity_home)
         // Set custom toolbar

src/org/thoughtcrime/securesms/loki/redesign/activities/LandingActivity.kt

@@ -27,7 +27,6 @@ import org.whispersystems.libsignal.ecc.Curve
 import org.whispersystems.libsignal.ecc.ECKeyPair
 import org.whispersystems.libsignal.util.KeyHelper
 import org.whispersystems.signalservice.loki.api.DeviceLink
-import org.whispersystems.signalservice.loki.api.LokiFileServerAPI
 import org.whispersystems.signalservice.loki.utilities.hexEncodedPublicKey
 import org.whispersystems.signalservice.loki.utilities.retryIfNeeded
 
@@ -100,7 +99,7 @@ class LandingActivity : BaseActionBarActivity(), LinkDeviceSlaveModeDialogDelega
             return Toast.makeText(application, "Couldn't link device.", Toast.LENGTH_LONG).show()
         }
         val application = ApplicationContext.getInstance(this)
-        application.startLongPollingIfNeeded()
+        application.startPollingIfNeeded()
         application.setUpP2PAPI()
         application.setUpStorageAPIIfNeeded()
         val linkDeviceDialog = LinkDeviceSlaveModeDialog()

src/org/thoughtcrime/securesms/loki/redesign/messaging/BackgroundOpenGroupPollWorker.kt

@@ -7,32 +7,32 @@ import org.thoughtcrime.securesms.service.PersistentAlarmManagerListener
 import org.thoughtcrime.securesms.util.TextSecurePreferences
 import java.util.concurrent.TimeUnit
 
-class BackgroundPublicChatPollWorker : PersistentAlarmManagerListener() {
+class BackgroundOpenGroupPollWorker : PersistentAlarmManagerListener() {
 
     companion object {
         private val pollInterval = TimeUnit.MINUTES.toMillis(4)
 
         @JvmStatic
         fun schedule(context: Context) {
-            BackgroundPublicChatPollWorker().onReceive(context, Intent())
+            BackgroundOpenGroupPollWorker().onReceive(context, Intent())
         }
     }
 
     override fun getNextScheduledExecutionTime(context: Context): Long {
-        return TextSecurePreferences.getPublicChatBackgroundPollTime(context)
+        return TextSecurePreferences.getOpenGroupBackgroundPollTime(context)
     }
 
     override fun onAlarm(context: Context, scheduledTime: Long): Long {
         if (scheduledTime != 0L) {
-            val publicChats = DatabaseFactory.getLokiThreadDatabase(context).getAllPublicChats().map { it.value }
+            val openGroups = DatabaseFactory.getLokiThreadDatabase(context).getAllPublicChats().map { it.value }
-            for (publicChat in publicChats) {
+            for (openGroup in openGroups) {
-                val poller = LokiPublicChatPoller(context, publicChat)
+                val poller = LokiPublicChatPoller(context, openGroup)
                 poller.stop()
                 poller.pollForNewMessages()
             }
         }
         val nextTime = System.currentTimeMillis() + pollInterval
-        TextSecurePreferences.setPublicChatBackgroundPollTime(context, nextTime)
+        TextSecurePreferences.setOpenGroupBackgroundPollTime(context, nextTime)
         return nextTime
     }
 }

src/org/thoughtcrime/securesms/loki/redesign/messaging/BackgroundPollWorker.kt

@@ -32,7 +32,9 @@ class BackgroundPollWorker : PersistentAlarmManagerListener() {
             val userHexEncodedPublicKey = TextSecurePreferences.getLocalNumber(context)
             val lokiAPIDatabase = DatabaseFactory.getLokiAPIDatabase(context)
             try {
-                LokiAPI(userHexEncodedPublicKey, lokiAPIDatabase, (context.applicationContext as ApplicationContext).broadcaster).getMessages().map { messages ->
+                val applicationContext = context.applicationContext as ApplicationContext
+                val broadcaster = applicationContext.broadcaster
+                LokiAPI(userHexEncodedPublicKey, lokiAPIDatabase, broadcaster).getMessages().map { messages ->
                     messages.forEach {
                         PushContentReceiveJob(context).processEnvelope(SignalServiceEnvelope(it))
                     }

src/org/thoughtcrime/securesms/loki/redesign/messaging/LokiPublicChatPoller.kt

@@ -23,7 +23,6 @@ import org.whispersystems.signalservice.api.messages.multidevice.SentTranscriptM
 import org.whispersystems.signalservice.api.push.SignalServiceAddress
 import org.whispersystems.signalservice.loki.api.*
 import org.whispersystems.signalservice.loki.messaging.LokiThreadFriendRequestStatus
-import org.whispersystems.signalservice.loki.utilities.successBackground
 import java.security.MessageDigest
 import java.util.*
 
@@ -70,6 +69,7 @@ class LokiPublicChatPoller(private val context: Context, private val group: Loki
     }
 
     private val pollForDisplayNamesTask = object : Runnable {
+
         override fun run() {
             pollForDisplayNames()
             handler.postDelayed(this, pollForDisplayNamesInterval)
@@ -217,6 +217,7 @@ class LokiPublicChatPoller(private val context: Context, private val group: Loki
         val userPrivateKey = IdentityKeyUtil.getIdentityKeyPair(context).privateKey.serialize()
         val database = DatabaseFactory.getLokiAPIDatabase(context)
         LokiFileServerAPI.configure(false, userHexEncodedPublicKey, userPrivateKey, database)
+        // Kovenant propagates a context to chained promises, so LokiPublicChatAPI.sharedContext should be used for all of the below
         LokiDeviceLinkUtilities.getAllLinkedDeviceHexEncodedPublicKeys(userHexEncodedPublicKey).bind(LokiPublicChatAPI.sharedContext) { devices ->
             userDevices = devices
             api.getMessages(group.channel, group.server)
@@ -235,15 +236,16 @@ class LokiPublicChatPoller(private val context: Context, private val group: Loki
                 }
             }
             Promise.of(messages)
-        }.successBackground {
+        }.success {
             val newDisplayNameUpdatees = uniqueDevices.mapNotNull {
                 // This will return null if the current device is a master device
                 LokiDeviceLinkUtilities.getMasterHexEncodedPublicKey(it).get()
             }.toSet()
             // Fetch the display names of the master devices
             displayNameUpdatees = displayNameUpdatees.union(newDisplayNameUpdatees)
-        }.successBackground { messages ->
+        }.success { messages ->
             // Process messages in the background
+            Thread {
                 messages.forEach { message ->
                     if (userDevices.contains(message.hexEncodedPublicKey)) {
                         processOutgoingMessage(message)
@@ -251,6 +253,7 @@ class LokiPublicChatPoller(private val context: Context, private val group: Loki
                         processIncomingMessage(message)
                     }
                 }
+            }.start()
         }.fail {
             Log.d("Loki", "Failed to get messages for group chat with ID: ${group.channel} on server: ${group.server}.")
         }
@@ -260,11 +263,13 @@ class LokiPublicChatPoller(private val context: Context, private val group: Loki
         if (displayNameUpdatees.isEmpty()) { return }
         val hexEncodedPublicKeys = displayNameUpdatees
         displayNameUpdatees = setOf()
-        api.getDisplayNames(hexEncodedPublicKeys, group.server).successBackground { mapping ->
+        api.getDisplayNames(hexEncodedPublicKeys, group.server).success { mapping ->
+            Thread {
                 for (pair in mapping.entries) {
                     val senderDisplayName = "${pair.value} (...${pair.key.takeLast(8)})"
                     DatabaseFactory.getLokiUserDatabase(context).setServerDisplayName(group.id, pair.key, senderDisplayName)
                 }
+            }.start()
         }.fail {
             displayNameUpdatees = displayNameUpdatees.union(hexEncodedPublicKeys)
         }
@@ -272,6 +277,7 @@ class LokiPublicChatPoller(private val context: Context, private val group: Loki
 
     private fun pollForDeletedMessages() {
         api.getDeletedMessageServerIDs(group.channel, group.server).success { deletedMessageServerIDs ->
+            Thread {
                 val lokiMessageDatabase = DatabaseFactory.getLokiMessageDatabase(context)
                 val deletedMessageIDs = deletedMessageServerIDs.mapNotNull { lokiMessageDatabase.getMessageID(it) }
                 val smsMessageDatabase = DatabaseFactory.getSmsDatabase(context)
@@ -280,6 +286,7 @@ class LokiPublicChatPoller(private val context: Context, private val group: Loki
                     smsMessageDatabase.deleteMessage(it)
                     mmsMessageDatabase.delete(it)
                 }
+            }.start()
         }.fail {
             Log.d("Loki", "Failed to get deleted messages for group chat with ID: ${group.channel} on server: ${group.server}.")
         }

src/org/thoughtcrime/securesms/loki/redesign/messaging/LokiRSSFeedPoller.kt

@@ -25,6 +25,7 @@ class LokiRSSFeedPoller(private val context: Context, private val feed: LokiRSSF
     private var hasStarted = false
 
     private val task = object : Runnable {
+
         override fun run() {
             poll()
             handler.postDelayed(this, interval)
@@ -69,7 +70,7 @@ class LokiRSSFeedPoller(private val context: Context, private val feed: LokiRSSF
                 PushDecryptJob(context).handleTextMessage(x3, x2, Optional.absent(), Optional.absent())
             }
         }.fail { exception ->
-            Log.d("Loki", "Couldn't update RSS feed with ID: $feed.id. $exception")
+            Log.d("Loki", "Couldn't update RSS feed with ID: $feed.id due to exception: $exception.")
         }
     }
 }

src/org/thoughtcrime/securesms/util/TextSecurePreferences.java

@@ -1185,11 +1185,11 @@ public class TextSecurePreferences {
     setLongPreference(context, "background_poll_time", backgroundPollTime);
   }
 
-  public static long getPublicChatBackgroundPollTime(Context context) {
+  public static long getOpenGroupBackgroundPollTime(Context context) {
     return getLongPreference(context, "public_chat_background_poll_time", 0L);
   }
 
-  public static void setPublicChatBackgroundPollTime(Context context, long backgroundPollTime) {
+  public static void setOpenGroupBackgroundPollTime(Context context, long backgroundPollTime) {
     setLongPreference(context, "public_chat_background_poll_time", backgroundPollTime);
   }