From 7aeb4c96eea89f3a4372ccce1b8500cc698d1d11 Mon Sep 17 00:00:00 2001
From: Jake McGinty <me@jake.su>
Date: Wed, 18 Nov 2015 18:24:47 -0800
Subject: [PATCH] fix crash on null Android contact name

fixes #4592
Closes #4594
// FREEBIE
---
 .../contacts/ContactSelectionListAdapter.java | 20 +++++++++----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/src/org/thoughtcrime/securesms/contacts/ContactSelectionListAdapter.java b/src/org/thoughtcrime/securesms/contacts/ContactSelectionListAdapter.java
index d882f02ac1..6405827c94 100644
--- a/src/org/thoughtcrime/securesms/contacts/ContactSelectionListAdapter.java
+++ b/src/org/thoughtcrime/securesms/contacts/ContactSelectionListAdapter.java
@@ -26,6 +26,7 @@ import android.support.annotation.Nullable;
 import android.support.v7.widget.RecyclerView;
 import android.text.SpannableString;
 import android.text.Spanned;
+import android.text.TextUtils;
 import android.text.style.ImageSpan;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -160,22 +161,19 @@ public class ContactSelectionListAdapter extends CursorRecyclerViewAdapter<ViewH
     }
   }
 
-  private String getHeaderString(int position) {
+  private @NonNull String getHeaderString(int position) {
     Cursor cursor = getCursorAtPositionOrThrow(position);
-
+    String letter = cursor.getString(cursor.getColumnIndexOrThrow(ContactsDatabase.NAME_COLUMN));
     if (cursor.getInt(cursor.getColumnIndexOrThrow(ContactsDatabase.CONTACT_TYPE_COLUMN)) == ContactsDatabase.PUSH_TYPE) {
       return getContext().getString(R.string.app_name);
-    } else {
-      String letter = cursor.getString(cursor.getColumnIndexOrThrow(ContactsDatabase.NAME_COLUMN))
-                            .trim()
-                            .substring(0,1)
-                            .toUpperCase();
-      if (Character.isLetterOrDigit(letter.codePointAt(0))) {
-        return letter;
-      } else {
-        return "#";
+    } else if (!TextUtils.isEmpty(letter)) {
+      String firstChar = letter.trim().substring(0, 1).toUpperCase();
+      if (Character.isLetterOrDigit(firstChar.codePointAt(0))) {
+        return firstChar;
       }
     }
+
+    return "#";
   }
 
   private Cursor getCursorAtPositionOrThrow(int position) {