Fix control messages

app/src/main/java/org/thoughtcrime/securesms/conversation/disappearingmessages/DisappearingMessagesViewModel.kt

@@ -61,7 +61,7 @@ class DisappearingMessagesViewModel(
 
     init {
         viewModelScope.launch {
-            val expiryMode = storage.getExpirationConfiguration(threadId)?.expiryMode ?: ExpiryMode.NONE
+            val expiryMode = storage.getExpirationConfiguration(threadId)?.expiryMode?.maybeConvertToLegacy(isNewConfigEnabled) ?: ExpiryMode.NONE
             val recipient = threadDb.getRecipientForThreadId(threadId)
             val groupRecord = recipient?.takeIf { it.isClosedGroupRecipient }
                 ?.run { groupDb.getGroup(address.toGroupString()).orNull() }
@@ -83,7 +83,7 @@ class DisappearingMessagesViewModel(
 
     override fun onSetClick() = viewModelScope.launch {
         val state = _state.value
-        val mode = state.expiryMode
+        val mode = state.expiryMode?.coerceLegacyToAfterSend()
         val address = state.address
         if (address == null || mode == null) {
             _event.send(Event.FAIL)
@@ -93,8 +93,9 @@ class DisappearingMessagesViewModel(
         val expiryChangeTimestampMs = SnodeAPI.nowWithOffset
         storage.setExpirationConfiguration(ExpirationConfiguration(threadId, mode, expiryChangeTimestampMs))
 
-        val message = ExpirationTimerUpdate(mode.expirySeconds.toInt()).apply {
+        val message = ExpirationTimerUpdate(mode).apply {
             sender = textSecurePreferences.getLocalNumber()
+            isSenderSelf = true
             recipient = address.serialize()
             sentTimestamp = expiryChangeTimestampMs
         }
@@ -106,6 +107,8 @@ class DisappearingMessagesViewModel(
         _event.send(Event.SUCCESS)
     }
 
+    private fun ExpiryMode.coerceLegacyToAfterSend() = takeUnless { it is ExpiryMode.Legacy } ?: ExpiryMode.AfterSend(expirySeconds)
+
     @dagger.assisted.AssistedFactory
     interface AssistedFactory {
         fun create(threadId: Long): Factory
@@ -135,3 +138,5 @@ class DisappearingMessagesViewModel(
         ) as T
     }
 }
+
+private fun ExpiryMode.maybeConvertToLegacy(isNewConfigEnabled: Boolean): ExpiryMode = takeIf { isNewConfigEnabled } ?: ExpiryMode.Legacy(expirySeconds)

app/src/main/java/org/thoughtcrime/securesms/conversation/v2/components/ExpirationTimerView.kt

@@ -3,8 +3,6 @@ package org.thoughtcrime.securesms.conversation.v2.components
 import android.content.Context
 import android.graphics.drawable.AnimationDrawable
 import android.util.AttributeSet
-import android.util.Log
-import android.widget.ImageView
 import androidx.appcompat.widget.AppCompatImageView
 import androidx.core.content.ContextCompat
 import network.loki.messenger.R

app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageView.kt

@@ -30,6 +30,7 @@ import network.loki.messenger.databinding.ViewVisibleMessageBinding
 import org.session.libsession.messaging.contacts.Contact
 import org.session.libsession.messaging.contacts.Contact.ContactContext
 import org.session.libsession.messaging.open_groups.OpenGroupApi
+import org.session.libsession.snode.SnodeAPI
 import org.session.libsession.utilities.Address
 import org.session.libsession.utilities.ViewUtil
 import org.session.libsession.utilities.getColorFromAttr
@@ -348,23 +349,18 @@ class VisibleMessageView : LinearLayout {
     }
 
     private fun updateExpirationTimer(message: MessageRecord) {
-        val expirationTimerView = binding.expirationTimerView
-
         if (!message.isOutgoing) binding.messageStatusTextView.bringToFront()
 
-        if (message.expiresIn > 0) {
-            if (message.expireStarted > 0) {
-                expirationTimerView.setExpirationTime(message.expireStarted, message.expiresIn)
-                ApplicationContext.getInstance(context).expiringMessageManager.checkSchedule()
-            } else {
-                ThreadUtils.queue {
-                    val expirationManager = ApplicationContext.getInstance(context).expiringMessageManager
-                    val id = message.getId()
-                    val mms = message.isMms
-                    if (mms) mmsDb.markExpireStarted(id) else smsDb.markExpireStarted(id)
-                    expirationManager.scheduleDeletion(id, mms, message.expiresIn)
-                }
-            }
+        val expireStarted = message.expireStarted.takeIf { it > 0 } ?: SnodeAPI.nowWithOffset
+
+        val id = message.getId()
+        val mms = message.isMms
+        binding.expirationTimerView.setExpirationTime(expireStarted, message.expiresIn)
+        ThreadUtils.queue {
+            val db = if (mms) mmsDb else smsDb
+            db.markExpireStarted(id, expireStarted)
+            ApplicationContext.getInstance(context).expiringMessageManager
+                .scheduleDeletion(id, mms, expireStarted, message.expiresIn)
         }
     }
 

app/src/main/java/org/thoughtcrime/securesms/database/ExpirationInfo.kt

@@ -0,0 +1,3 @@
+package org.thoughtcrime.securesms.database
+
+data class ExpirationInfo(val id: Long, val expiresIn: Long, val expireStarted: Long, val isMms: Boolean)

app/src/main/java/org/thoughtcrime/securesms/database/MarkedMessageInfo.kt

@@ -0,0 +1,14 @@
+package org.thoughtcrime.securesms.database
+
+import org.thoughtcrime.securesms.conversation.disappearingmessages.ExpiryType
+import org.thoughtcrime.securesms.database.MessagingDatabase.SyncMessageId
+
+data class MarkedMessageInfo(val syncMessageId: SyncMessageId, val expirationInfo: ExpirationInfo) {
+    fun guessExpiryType(): ExpiryType = expirationInfo.run {
+        when {
+            syncMessageId.timetamp == expireStarted -> ExpiryType.AFTER_SEND
+            expiresIn > 0 -> ExpiryType.AFTER_READ
+            else -> ExpiryType.NONE
+        }
+    }
+}

app/src/main/java/org/thoughtcrime/securesms/database/MessagingDatabase.java

@@ -12,7 +12,6 @@ import org.session.libsession.utilities.Document;
 import org.session.libsession.utilities.IdentityKeyMismatch;
 import org.session.libsession.utilities.IdentityKeyMismatchList;
 import org.session.libsignal.crypto.IdentityKey;
-import org.session.libsignal.protos.SignalServiceProtos;
 import org.session.libsignal.utilities.JsonUtil;
 import org.session.libsignal.utilities.Log;
 import org.thoughtcrime.securesms.conversation.disappearingmessages.ExpiryType;
@@ -227,66 +226,6 @@ public abstract class MessagingDatabase extends Database implements MmsSmsColumn
     }
   }
 
-  public static class ExpirationInfo {
-
-    private final long    id;
-    private final long    expiresIn;
-    private final long    expireStarted;
-    private final boolean mms;
-
-    public ExpirationInfo(long id, long expiresIn, long expireStarted, boolean mms) {
-      this.id            = id;
-      this.expiresIn     = expiresIn;
-      this.expireStarted = expireStarted;
-      this.mms           = mms;
-    }
-
-    public long getId() {
-      return id;
-    }
-
-    public long getExpiresIn() {
-      return expiresIn;
-    }
-
-    public long getExpireStarted() {
-      return expireStarted;
-    }
-
-    public boolean isMms() {
-      return mms;
-    }
-  }
-
-  public static class MarkedMessageInfo {
-
-    private final SyncMessageId  syncMessageId;
-    private final ExpirationInfo expirationInfo;
-
-    public MarkedMessageInfo(SyncMessageId syncMessageId, ExpirationInfo expirationInfo) {
-      this.syncMessageId  = syncMessageId;
-      this.expirationInfo = expirationInfo;
-    }
-
-    public SyncMessageId getSyncMessageId() {
-      return syncMessageId;
-    }
-
-    public ExpirationInfo getExpirationInfo() {
-      return expirationInfo;
-    }
-
-    public ExpiryType guessExpiryType() {
-      long expireStarted = expirationInfo.expireStarted;
-      long expiresIn = expirationInfo.expiresIn;
-      long timestamp = syncMessageId.timetamp;
-
-      if (timestamp == expireStarted) return ExpiryType.AFTER_SEND;
-      if (expiresIn > 0) return ExpiryType.AFTER_READ;
-      return ExpiryType.NONE;
-    }
-  }
-
   public static class InsertResult {
     private final long messageId;
     private final long threadId;

app/src/main/java/org/thoughtcrime/securesms/database/Storage.kt

@@ -1718,9 +1718,7 @@ open class Storage(
                     ?.run { disappearingTimer.takeIf { it != 0L }?.let(ExpiryMode::AfterSend) ?: ExpiryMode.NONE }
             }
             else -> null
-        }
-            ?.run { takeIf { isNewConfigEnabled || it is ExpiryMode.NONE } ?: ExpiryMode.Legacy(expirySeconds) }
-            ?.let { ExpirationConfiguration(threadId, it, dbExpirationMetadata.updatedTimestampMs) }
+        }?.let { ExpirationConfiguration(threadId, it, dbExpirationMetadata.updatedTimestampMs) }
     }
 
     override fun setExpirationConfiguration(config: ExpirationConfiguration) {
@@ -1729,12 +1727,7 @@ open class Storage(
         val expirationDb = DatabaseComponent.get(context).expirationConfigurationDatabase()
         val currentConfig = expirationDb.getExpirationConfiguration(config.threadId)
         if (currentConfig != null && currentConfig.updatedTimestampMs >= config.updatedTimestampMs) return
-
-        val expiryMode = config.expiryMode.run {
-            takeUnless { it is ExpiryMode.Legacy }
-                ?: if (recipient.isContactRecipient) ExpiryMode.AfterRead(expirySeconds)
-                else ExpiryMode.AfterSend(expirySeconds)
-        }
+        val expiryMode = config.expiryMode
 
         if (recipient.isClosedGroupRecipient) {
             val userGroups = configFactory.userGroups ?: return

app/src/main/java/org/thoughtcrime/securesms/database/ThreadDatabase.java

@@ -51,7 +51,6 @@ import org.session.libsignal.utilities.Pair;
 import org.session.libsignal.utilities.guava.Optional;
 import org.thoughtcrime.securesms.ApplicationContext;
 import org.thoughtcrime.securesms.contacts.ContactUtil;
-import org.thoughtcrime.securesms.database.MessagingDatabase.MarkedMessageInfo;
 import org.thoughtcrime.securesms.database.helpers.SQLCipherOpenHelper;
 import org.thoughtcrime.securesms.database.model.MediaMmsMessageRecord;
 import org.thoughtcrime.securesms.database.model.MessageRecord;

app/src/main/java/org/thoughtcrime/securesms/notifications/AndroidAutoHeardReceiver.java

@@ -27,7 +27,7 @@ import androidx.core.app.NotificationManagerCompat;
 
 import org.session.libsignal.utilities.Log;
 import org.thoughtcrime.securesms.ApplicationContext;
-import org.thoughtcrime.securesms.database.MessagingDatabase.MarkedMessageInfo;
+import org.thoughtcrime.securesms.database.MarkedMessageInfo;
 import org.thoughtcrime.securesms.dependencies.DatabaseComponent;
 
 import java.util.LinkedList;

app/src/main/java/org/thoughtcrime/securesms/notifications/AndroidAutoReplyReceiver.java

@@ -36,7 +36,7 @@ import org.session.libsession.utilities.Address;
 import org.session.libsession.utilities.recipients.Recipient;
 import org.session.libsignal.utilities.Log;
 import org.thoughtcrime.securesms.ApplicationContext;
-import org.thoughtcrime.securesms.database.MessagingDatabase.MarkedMessageInfo;
+import org.thoughtcrime.securesms.database.MarkedMessageInfo;
 import org.thoughtcrime.securesms.dependencies.DatabaseComponent;
 import org.thoughtcrime.securesms.mms.MmsException;
 

app/src/main/java/org/thoughtcrime/securesms/notifications/MarkReadReceiver.kt

@@ -18,8 +18,8 @@ import org.session.libsession.utilities.recipients.Recipient
 import org.session.libsignal.utilities.Log
 import org.thoughtcrime.securesms.ApplicationContext
 import org.thoughtcrime.securesms.conversation.disappearingmessages.ExpiryType
-import org.thoughtcrime.securesms.database.MessagingDatabase.ExpirationInfo
-import org.thoughtcrime.securesms.database.MessagingDatabase.MarkedMessageInfo
+import org.thoughtcrime.securesms.database.ExpirationInfo
+import org.thoughtcrime.securesms.database.MarkedMessageInfo
 import org.thoughtcrime.securesms.dependencies.DatabaseComponent
 import org.thoughtcrime.securesms.util.SessionMetaProtocol.shouldSendReadReceipt
 
@@ -129,16 +129,18 @@ class MarkReadReceiver : BroadcastReceiver() {
             expirationInfo: ExpirationInfo,
             expiresIn: Long = expirationInfo.expiresIn
         ) {
-            if (expiresIn > 0 && expirationInfo.expireStarted <= 0) {
-                if (expirationInfo.isMms) DatabaseComponent.get(context!!).mmsDatabase().markExpireStarted(expirationInfo.id)
-                else DatabaseComponent.get(context!!).smsDatabase().markExpireStarted(expirationInfo.id)
+            if (expiresIn <= 0 || expirationInfo.expireStarted > 0) return
 
-                ApplicationContext.getInstance(context).expiringMessageManager.scheduleDeletion(
-                    expirationInfo.id,
-                    expirationInfo.isMms,
-                    expiresIn
-                )
-            }
+            val now = SnodeAPI.nowWithOffset
+            val db = DatabaseComponent.get(context!!).run { if (expirationInfo.isMms) mmsDatabase() else smsDatabase() }
+            db.markExpireStarted(expirationInfo.id, now)
+
+            ApplicationContext.getInstance(context).expiringMessageManager.scheduleDeletion(
+                expirationInfo.id,
+                expirationInfo.isMms,
+                now,
+                expiresIn
+            )
         }
     }
 }

app/src/main/java/org/thoughtcrime/securesms/notifications/RemoteReplyReceiver.java

@@ -36,7 +36,7 @@ import org.session.libsession.utilities.Address;
 import org.session.libsession.utilities.recipients.Recipient;
 import org.session.libsignal.utilities.Log;
 import org.thoughtcrime.securesms.ApplicationContext;
-import org.thoughtcrime.securesms.database.MessagingDatabase.MarkedMessageInfo;
+import org.thoughtcrime.securesms.database.MarkedMessageInfo;
 import org.thoughtcrime.securesms.database.MmsDatabase;
 import org.thoughtcrime.securesms.database.SmsDatabase;
 import org.thoughtcrime.securesms.database.Storage;

app/src/main/java/org/thoughtcrime/securesms/service/ExpiringMessageManager.java

@@ -9,6 +9,7 @@ import org.session.libsession.messaging.messages.ExpirationConfiguration;
 import org.session.libsession.messaging.messages.control.ExpirationTimerUpdate;
 import org.session.libsession.messaging.messages.signal.IncomingMediaMessage;
 import org.session.libsession.messaging.messages.signal.OutgoingExpirationUpdateMessage;
+import org.session.libsession.snode.SnodeAPI;
 import org.session.libsession.utilities.Address;
 import org.session.libsession.utilities.GroupUtil;
 import org.session.libsession.utilities.SSKEnvironment;
@@ -54,10 +55,6 @@ public class ExpiringMessageManager implements SSKEnvironment.MessageExpirationM
     executor.execute(new ProcessTask());
   }
 
-  public void scheduleDeletion(long id, boolean mms, long expiresInMillis) {
-    scheduleDeletion(id, mms, System.currentTimeMillis(), expiresInMillis);
-  }
-
   public void scheduleDeletion(long id, boolean mms, long startedAtTimestamp, long expiresInMillis) {
     long expiresAtMillis = startedAtTimestamp + expiresInMillis;
 
@@ -78,8 +75,7 @@ public class ExpiringMessageManager implements SSKEnvironment.MessageExpirationM
     String userPublicKey = TextSecurePreferences.getLocalNumber(context);
     String senderPublicKey = message.getSender();
     long sentTimestamp = message.getSentTimestamp() == null ? 0 : message.getSentTimestamp();
-    long expireStartedAt = (expiryMode instanceof ExpiryMode.AfterSend)
-            ? sentTimestamp : 0;
+    long expireStartedAt = (expiryMode instanceof ExpiryMode.AfterSend || message.isSenderSelf()) ? sentTimestamp : 0;
 
     // Notify the user
     if (senderPublicKey == null || userPublicKey.equals(senderPublicKey)) {
@@ -88,7 +84,7 @@ public class ExpiringMessageManager implements SSKEnvironment.MessageExpirationM
     } else {
       insertIncomingExpirationTimerMessage(message, expireStartedAt);
     }
-    if (expiryMode instanceof ExpiryMode.AfterSend && message.getSentTimestamp() != null && senderPublicKey != null) {
+    if (expiryMode.getExpirySeconds() > 0 && message.getSentTimestamp() != null && senderPublicKey != null) {
       startAnyExpiration(message.getSentTimestamp(), senderPublicKey, expireStartedAt);
     }
   }
@@ -98,7 +94,7 @@ public class ExpiringMessageManager implements SSKEnvironment.MessageExpirationM
     String senderPublicKey = message.getSender();
     Long sentTimestamp = message.getSentTimestamp();
     String groupId = message.getGroupPublicKey();
-    long expiresInMillis = message.getDuration() * 1000L;
+    long expiresInMillis = message.getExpiryMode().getExpiryMillis();
 
     Optional<SignalServiceGroup> groupInfo = Optional.absent();
     Address address = Address.fromSerialized(senderPublicKey);
@@ -144,7 +140,7 @@ public class ExpiringMessageManager implements SSKEnvironment.MessageExpirationM
 
     Long sentTimestamp = message.getSentTimestamp();
     String groupId = message.getGroupPublicKey();
-    int duration = message.getDuration();
+    long duration = message.getExpiryMode().getExpiryMillis();
 
     Address address;
 
@@ -159,7 +155,7 @@ public class ExpiringMessageManager implements SSKEnvironment.MessageExpirationM
       StorageProtocol storage = MessagingModuleConfiguration.getShared().getStorage();
       message.setThreadID(storage.getOrCreateThreadIdFor(address));
 
-      OutgoingExpirationUpdateMessage timerUpdateMessage = new OutgoingExpirationUpdateMessage(recipient, sentTimestamp, duration * 1000L, expireStartedAt, groupId);
+      OutgoingExpirationUpdateMessage timerUpdateMessage = new OutgoingExpirationUpdateMessage(recipient, sentTimestamp, duration, expireStartedAt, groupId);
       mmsDatabase.insertSecureDecryptedMessageOutbox(timerUpdateMessage, message.getThreadID(), sentTimestamp, true);
     } catch (MmsException | IOException ioe) {
       Log.e("Loki", "Failed to insert expiration update message.", ioe);
@@ -169,18 +165,17 @@ public class ExpiringMessageManager implements SSKEnvironment.MessageExpirationM
   @Override
   public void startAnyExpiration(long timestamp, @NotNull String author, long expireStartedAt) {
     MessageRecord messageRecord = mmsSmsDatabase.getMessageFor(timestamp, author);
-    if (messageRecord != null) {
-      boolean mms = messageRecord.isMms();
-      ExpirationConfiguration config = DatabaseComponent.get(context).storage().getExpirationConfiguration(messageRecord.getThreadId());
-      if (config == null || !config.isEnabled()) return;
-      ExpiryMode mode = config.getExpiryMode();
-      if (mms) {
-        mmsDatabase.markExpireStarted(messageRecord.getId(), expireStartedAt);
-      } else {
-        smsDatabase.markExpireStarted(messageRecord.getId(), expireStartedAt);
-      }
-      scheduleDeletion(messageRecord.getId(), mms, expireStartedAt, (mode != null ? mode.getExpiryMillis() : 0));
+    if (messageRecord == null) return;
+    boolean mms = messageRecord.isMms();
+    ExpirationConfiguration config = DatabaseComponent.get(context).storage().getExpirationConfiguration(messageRecord.getThreadId());
+    if (config == null || !config.isEnabled()) return;
+    ExpiryMode mode = config.getExpiryMode();
+    if (mms) {
+      mmsDatabase.markExpireStarted(messageRecord.getId(), expireStartedAt);
+    } else {
+      smsDatabase.markExpireStarted(messageRecord.getId(), expireStartedAt);
     }
+    scheduleDeletion(messageRecord.getId(), mms, expireStartedAt, (mode != null ? mode.getExpiryMillis() : 0));
   }
 
   private class LoadTask implements Runnable {
@@ -219,7 +214,7 @@ public class ExpiringMessageManager implements SSKEnvironment.MessageExpirationM
             while (expiringMessageReferences.isEmpty()) expiringMessageReferences.wait();
 
             ExpiringMessageReference nextReference = expiringMessageReferences.first();
-            long                     waitTime      = nextReference.expiresAtMillis - System.currentTimeMillis();
+            long                     waitTime      = nextReference.expiresAtMillis - SnodeAPI.getNowWithOffset();
 
             if (waitTime > 0) {
               ExpirationListener.setAlarm(context, waitTime);