From 7dd3efeb53b395eedf3e46b6a626c2c67f23e9cb Mon Sep 17 00:00:00 2001 From: Cody Henthorne Date: Fri, 5 Jun 2020 18:29:55 -0400 Subject: [PATCH] Remove listeners when detaching conversation item views. --- .../securesms/conversation/ConversationItem.java | 1 + .../securesms/conversation/ConversationUpdateItem.java | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java index dd5b266d13..7d8c6075c2 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java @@ -285,6 +285,7 @@ public class ConversationItem extends LinearLayout implements BindableConversati @Override protected void onDetachedFromWindow() { ConversationSwipeAnimationHelper.update(this, 0f, 1f); + unbind(); super.onDetachedFromWindow(); } diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationUpdateItem.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationUpdateItem.java index 4f3a91ad66..45f421a325 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationUpdateItem.java +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationUpdateItem.java @@ -87,6 +87,12 @@ public class ConversationUpdateItem extends LinearLayout bind(messageRecord, locale); } + @Override + protected void onDetachedFromWindow() { + unbind(); + super.onDetachedFromWindow(); + } + @Override public void setEventListener(@Nullable EventListener listener) { // No events to report yet