From 8b3a3d163f4f329c970d161a2dc1af476cf78655 Mon Sep 17 00:00:00 2001 From: Moxie Marlinspike Date: Sat, 2 Dec 2017 12:23:14 -0800 Subject: [PATCH] Don't check subscription info on dual sim devices wihout permission Fixes #7239 --- src/org/thoughtcrime/securesms/ConversationItem.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/org/thoughtcrime/securesms/ConversationItem.java b/src/org/thoughtcrime/securesms/ConversationItem.java index 38561718ba..47fdc21497 100644 --- a/src/org/thoughtcrime/securesms/ConversationItem.java +++ b/src/org/thoughtcrime/securesms/ConversationItem.java @@ -16,6 +16,7 @@ */ package org.thoughtcrime.securesms; +import android.Manifest; import android.content.ActivityNotFoundException; import android.content.Context; import android.content.DialogInterface; @@ -70,6 +71,7 @@ import org.thoughtcrime.securesms.mms.GlideRequests; import org.thoughtcrime.securesms.mms.PartAuthority; import org.thoughtcrime.securesms.mms.Slide; import org.thoughtcrime.securesms.mms.SlideClickListener; +import org.thoughtcrime.securesms.permissions.Permissions; import org.thoughtcrime.securesms.recipients.Recipient; import org.thoughtcrime.securesms.recipients.RecipientModifiedListener; import org.thoughtcrime.securesms.service.ExpiringMessageManager; @@ -454,7 +456,7 @@ public class ConversationItem extends LinearLayout private void setSimInfo(MessageRecord messageRecord) { SubscriptionManagerCompat subscriptionManager = new SubscriptionManagerCompat(context); - if (messageRecord.getSubscriptionId() == -1 || subscriptionManager.getActiveSubscriptionInfoList().size() < 2) { + if (messageRecord.getSubscriptionId() == -1 || !Permissions.hasAll(context, Manifest.permission.READ_PHONE_STATE) || subscriptionManager.getActiveSubscriptionInfoList().size() < 2) { simInfoText.setVisibility(View.GONE); } else { Optional subscriptionInfo = subscriptionManager.getActiveSubscriptionInfo(messageRecord.getSubscriptionId());